You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@tinkerpop.apache.org by dkuppitz <gi...@git.apache.org> on 2015/02/14 01:24:06 UTC

[GitHub] incubator-tinkerpop pull request: minor fixes

GitHub user dkuppitz opened a pull request:

    https://github.com/apache/incubator-tinkerpop/pull/14

    minor fixes

    * replaced `Double.MIN_VALUE` with `-Double.MAX_VALUE` in `MaxGlobalStep` cause `Double.MIN_VALUE` is just the smallest **positive** number
    * renamed `DedupStep` to `DedupGlobalStep` and `SampleStep` to `SampleGlobalStep` so that these steps are in line with the other steps that support a global and a local scope

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/dkuppitz/incubator-tinkerpop code-review

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/incubator-tinkerpop/pull/14.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #14
    
----
commit c93e1e21774be13a5c6585a42acef65db6892dd4
Author: Daniel Kuppitz <da...@hotmail.com>
Date:   2015-02-14T00:05:56Z

    replaced Double.MIN_VALUE with -Double.MAX_VALUE

commit 874f474cd1d0ff16810565e2b869258c992c346b
Author: Daniel Kuppitz <da...@hotmail.com>
Date:   2015-02-14T00:19:27Z

    renamed DedupStep -> DedupGlobalStep and SampleStep -> SampleGlobalStep

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-tinkerpop pull request: minor fixes

Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:

    https://github.com/apache/incubator-tinkerpop/pull/14


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---