You are viewing a plain text version of this content. The canonical link for it is here.
Posted to solr-dev@lucene.apache.org by "Kay Kay (JIRA)" <ji...@apache.org> on 2009/01/15 19:22:59 UTC

[jira] Created: (SOLR-961) Efficient array copy in ModifiableSolrParams#add(String, String...)

Efficient array copy in ModifiableSolrParams#add(String, String...) 
--------------------------------------------------------------------

                 Key: SOLR-961
                 URL: https://issues.apache.org/jira/browse/SOLR-961
             Project: Solr
          Issue Type: Improvement
          Components: clients - java
         Environment: Java 6, Tomcat 6 
            Reporter: Kay Kay
            Priority: Minor
         Attachments: SOLR-961.patch

Prefer System.arrayCopy as opposed to iterating and copying the array. 

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Assigned: (SOLR-961) Efficient array copy in ModifiableSolrParams#add(String, String...)

Posted by "Ryan McKinley (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/SOLR-961?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Ryan McKinley reassigned SOLR-961:
----------------------------------

    Assignee: Ryan McKinley

> Efficient array copy in ModifiableSolrParams#add(String, String...) 
> --------------------------------------------------------------------
>
>                 Key: SOLR-961
>                 URL: https://issues.apache.org/jira/browse/SOLR-961
>             Project: Solr
>          Issue Type: Improvement
>          Components: clients - java
>    Affects Versions: 1.3
>         Environment: Java 6, Tomcat 6 
>            Reporter: Kay Kay
>            Assignee: Ryan McKinley
>            Priority: Minor
>             Fix For: 1.4
>
>         Attachments: SOLR-961.patch
>
>   Original Estimate: 2h
>  Remaining Estimate: 2h
>
> Prefer System.arrayCopy as opposed to iterating and copying the array. 

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Closed: (SOLR-961) Efficient array copy in ModifiableSolrParams#add(String, String...)

Posted by "Kay Kay (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/SOLR-961?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Kay Kay closed SOLR-961.
------------------------


Thanks Ryan . 

> Efficient array copy in ModifiableSolrParams#add(String, String...) 
> --------------------------------------------------------------------
>
>                 Key: SOLR-961
>                 URL: https://issues.apache.org/jira/browse/SOLR-961
>             Project: Solr
>          Issue Type: Improvement
>          Components: clients - java
>    Affects Versions: 1.3
>         Environment: Java 6, Tomcat 6 
>            Reporter: Kay Kay
>            Assignee: Ryan McKinley
>            Priority: Minor
>             Fix For: 1.4
>
>         Attachments: SOLR-961.patch
>
>   Original Estimate: 2h
>  Remaining Estimate: 2h
>
> Prefer System.arrayCopy as opposed to iterating and copying the array. 

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (SOLR-961) Efficient array copy in ModifiableSolrParams#add(String, String...)

Posted by "Kay Kay (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/SOLR-961?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Kay Kay updated SOLR-961:
-------------------------

        Fix Version/s: 1.4
    Affects Version/s: 1.3

> Efficient array copy in ModifiableSolrParams#add(String, String...) 
> --------------------------------------------------------------------
>
>                 Key: SOLR-961
>                 URL: https://issues.apache.org/jira/browse/SOLR-961
>             Project: Solr
>          Issue Type: Improvement
>          Components: clients - java
>    Affects Versions: 1.3
>         Environment: Java 6, Tomcat 6 
>            Reporter: Kay Kay
>            Priority: Minor
>             Fix For: 1.4
>
>         Attachments: SOLR-961.patch
>
>   Original Estimate: 2h
>  Remaining Estimate: 2h
>
> Prefer System.arrayCopy as opposed to iterating and copying the array. 

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (SOLR-961) Efficient array copy in ModifiableSolrParams#add(String, String...)

Posted by "Kay Kay (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/SOLR-961?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Kay Kay updated SOLR-961:
-------------------------

    Attachment: SOLR-961.patch

1. New Test case added for ModifiableSolrParamsTest 

2. Change ModifiableSolrParams.add() implementation. 

> Efficient array copy in ModifiableSolrParams#add(String, String...) 
> --------------------------------------------------------------------
>
>                 Key: SOLR-961
>                 URL: https://issues.apache.org/jira/browse/SOLR-961
>             Project: Solr
>          Issue Type: Improvement
>          Components: clients - java
>         Environment: Java 6, Tomcat 6 
>            Reporter: Kay Kay
>            Priority: Minor
>         Attachments: SOLR-961.patch
>
>   Original Estimate: 2h
>  Remaining Estimate: 2h
>
> Prefer System.arrayCopy as opposed to iterating and copying the array. 

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Resolved: (SOLR-961) Efficient array copy in ModifiableSolrParams#add(String, String...)

Posted by "Ryan McKinley (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/SOLR-961?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Ryan McKinley resolved SOLR-961.
--------------------------------

    Resolution: Fixed

Committed revision 734790.

thanks Kay

> Efficient array copy in ModifiableSolrParams#add(String, String...) 
> --------------------------------------------------------------------
>
>                 Key: SOLR-961
>                 URL: https://issues.apache.org/jira/browse/SOLR-961
>             Project: Solr
>          Issue Type: Improvement
>          Components: clients - java
>    Affects Versions: 1.3
>         Environment: Java 6, Tomcat 6 
>            Reporter: Kay Kay
>            Assignee: Ryan McKinley
>            Priority: Minor
>             Fix For: 1.4
>
>         Attachments: SOLR-961.patch
>
>   Original Estimate: 2h
>  Remaining Estimate: 2h
>
> Prefer System.arrayCopy as opposed to iterating and copying the array. 

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.