You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@shardingsphere.apache.org by GitBox <gi...@apache.org> on 2022/10/10 06:41:42 UTC

[GitHub] [shardingsphere] strongduanmu opened a new issue, #15995: ShardingSphere-JDBC addBatch executeBatch performance optimize

strongduanmu opened a new issue, #15995:
URL: https://github.com/apache/shardingsphere/issues/15995

   ## Feature Request
   
   Now, we use TPCC to test the performance of ShardingSphere-JDBC and find that the performance loss of addBatch and executeBatch is large, and the logic needs to be optimized.
   
   ![image](https://user-images.githubusercontent.com/10829171/157831442-b760111c-554b-47b5-9ffe-3d2687482e27.png)
   
   ### Is your feature request related to a problem?
   
   No.
   
   ### Describe the feature you would like.
   
   When we execute addBatch method every time, it will call createExecutionContext method. This logic is very time-consuming. We should consider passing all the parameters to the createExecutionContext method at one time to improve performance.
   
   ```java
       @Override
       public void addBatch() {
           try {
               executionContext = createExecutionContext(createLogicSQL());
               batchPreparedStatementExecutor.addBatchForExecutionUnits(executionContext.getExecutionUnits());
           } finally {
               currentResultSet = null;
               clearParameters();
           }
       }
   ```
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [shardingsphere] github-actions[bot] closed issue #15995: ShardingSphere-JDBC addBatch executeBatch performance optimize

Posted by GitBox <gi...@apache.org>.
github-actions[bot] closed issue #15995: ShardingSphere-JDBC addBatch executeBatch performance optimize
URL: https://github.com/apache/shardingsphere/issues/15995


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [shardingsphere] github-actions[bot] commented on issue #15995: ShardingSphere-JDBC addBatch executeBatch performance optimize

Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on issue #15995:
URL: https://github.com/apache/shardingsphere/issues/15995#issuecomment-1272350217

   Hello , this issue has not received a reply for several days.
   This issue is supposed to be closed.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [I] ShardingSphere-JDBC addBatch executeBatch performance optimize [shardingsphere]

Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on issue #15995:
URL: https://github.com/apache/shardingsphere/issues/15995#issuecomment-2026021146

   There hasn't been any activity on this issue recently, and in order to prioritize active issues, it will be marked as stale.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org