[PR] Recurse into subdirs when determining staleness [maven-javadoc-plugin]

["pedro-w (via GitHub)" <gi...@apache.org>]

pedro-w opened a new pull request, #1339:
URL: https://github.com/apache/maven-javadoc-plugin/pull/1339

   When the plugin checks if the goal is up-to-date or needs to run, it generates a file containing the options and the names+timestamps of all files in the source and target directories. It then compares this to the last-saved version to
   determine if anything had changed. The generation did not recursively descend into the directories and therefore files could change without the plugin noticing that it needed to run.
   
   Also added some comments to explain the existing code.
   
   I did not add unit tests as the changed source file does not have a corresponding unit test files. I have run and tested this on Windows only.
   
   This relates to issue #1324 
   
   ---
   
   Following this checklist to help us incorporate your
   contribution quickly and easily:
   
   - [X] Your pull request should address just one issue, without pulling in other changes.
   - [X] Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
   - [X] Each commit in the pull request should have a meaningful subject line and body.
     Note that commits might be squashed by a maintainer on merge.
   - [ ] Write unit tests that match behavioural changes, where the tests fail if the changes to the runtime are not applied.
     This may not always be possible but is a best-practice.
   - [X] Run `mvn verify` to make sure basic checks pass.
     A more thorough check will be performed on your pull request automatically.
   - [X] You have run the integration tests successfully (`mvn -Prun-its verify`).
   
   If your pull request is about ~20 lines of code you don't need to sign an
   [Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf) if you are unsure
   please ask on the developers list.
   
   To make clear that you license your contribution under
   the [Apache License Version 2.0, January 2004](http://www.apache.org/licenses/LICENSE-2.0)
   you have to acknowledge this by using the following check-box.
   
   - [X] I hereby declare this contribution to be licenced under the [Apache License Version 2.0, January 2004](http://www.apache.org/licenses/LICENSE-2.0)
   - [ ] In any other case, please file an [Apache Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf).
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org