You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@storm.apache.org by marcust <gi...@git.apache.org> on 2017/04/11 08:08:00 UTC

[GitHub] storm pull request #2055: Use explicit charset when decoding from array back...

GitHub user marcust opened a pull request:

    https://github.com/apache/storm/pull/2055

    Use explicit charset when decoding from array backed buffer

    We had the case that this broke encoding for us because it used the default
    system locale. Given the fact that this code uses an explicit encoding for the
    other case and that it evolved from something that always used an explicit
    encoding I believe this is more correct.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/hubrick/storm-1 fix/kafka-encoding

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/storm/pull/2055.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #2055
    
----
commit 44b50fa6b83d766bdafd5ad96256109bc3d2a52a
Author: Marcus Thiesen <mt...@hubrick.com>
Date:   2017-04-11T08:02:38Z

    Use explicit charset when decoding from array backed buffer
    
    We had the case that this broke encoding for us because it used the default
    system locale. Given the fact that this code uses an explicit encoding for the
    other case and that it evolved from something that always used an explicit
    encoding I believe this is more correct.

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] storm issue #2055: [STORM-2467] Use explicit charset when decoding from arra...

Posted by HeartSaVioR <gi...@git.apache.org>.
Github user HeartSaVioR commented on the issue:

    https://github.com/apache/storm/pull/2055
  
    +1 Nice finding.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] storm pull request #2055: [STORM-2467] Use explicit charset when decoding fr...

Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:

    https://github.com/apache/storm/pull/2055


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] storm issue #2055: Use explicit charset when decoding from array backed buff...

Posted by srdo <gi...@git.apache.org>.
Github user srdo commented on the issue:

    https://github.com/apache/storm/pull/2055
  
    Nice find. The change LGTM. You should create an issue for this at https://issues.apache.org/jira/browse/STORM so the bugfix gets tracked. Then rename this PR and the commit message to include the issue number (example https://github.com/apache/storm/pull/2057/commits).


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] storm issue #2055: [STORM-2467] Use explicit charset when decoding from arra...

Posted by marcust <gi...@git.apache.org>.
Github user marcust commented on the issue:

    https://github.com/apache/storm/pull/2055
  
    @srdo Done


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---