[GitHub] [ignite-3] tkalkirill commented on a diff in pull request #1014: IGNITE-17534 Introduce HashIndexStorage interface and test implementation

[GitBox <gi...@apache.org>]

tkalkirill commented on code in PR #1014:
URL: https://github.com/apache/ignite-3/pull/1014#discussion_r946878752


##########
modules/storage-rocksdb/src/main/java/org/apache/ignite/internal/storage/rocksdb/RocksDbTableStorage.java:
##########
@@ -426,6 +427,12 @@ public void createIndex(String indexName) {
         throw new UnsupportedOperationException("Not implemented yet");
     }
 
+    @Override
+    @Nullable
+    public HashIndexStorage getHashIndex(int partitionId, String indexName) {
+        throw new UnsupportedOperationException("Not implemented yet");
+    }

Review Comment:
   ```suggestion
       @Override
       public @Nullable HashIndexStorage getHashIndex(int partitionId, String indexName) {
           throw new UnsupportedOperationException("Not implemented yet");
       }
   ```



##########
modules/storage-api/src/main/java/org/apache/ignite/internal/storage/engine/MvTableStorage.java:
##########
@@ -78,6 +79,16 @@ public interface MvTableStorage {
     @Nullable
     SortedIndexStorage getSortedIndex(int partitionId, String indexName);
 
+    /**
+     * Returns an already created Hash Index with the given name or {@code null} if it does not exist.
+     *
+     * @param partitionId Partition ID for which this index has been built.
+     * @param indexName Index name.
+     * @return Hash Index storage or {@code null} if it does not exist..
+     */
+    @Nullable
+    HashIndexStorage getHashIndex(int partitionId, String indexName);

Review Comment:
   Maybe **TableIndexConfiguration** instead **indexName**?



##########
modules/storage-api/src/main/java/org/apache/ignite/internal/storage/engine/MvTableStorage.java:
##########
@@ -78,6 +79,16 @@ public interface MvTableStorage {
     @Nullable
     SortedIndexStorage getSortedIndex(int partitionId, String indexName);
 
+    /**
+     * Returns an already created Hash Index with the given name or {@code null} if it does not exist.
+     *
+     * @param partitionId Partition ID for which this index has been built.
+     * @param indexName Index name.
+     * @return Hash Index storage or {@code null} if it does not exist..
+     */
+    @Nullable
+    HashIndexStorage getHashIndex(int partitionId, String indexName);

Review Comment:
   ```suggestion
       /**
        * Returns an already created Hash Index with the given name or {@code null} if it does not exist.
        *
        * @param partitionId Partition ID for which this index has been built.
        * @param indexName Index name.
        * @return Hash Index storage or {@code null} if it does not exist.
        */
       @Nullable HashIndexStorage getHashIndex(int partitionId, String indexName);
   ```



##########
modules/storage-page-memory/src/main/java/org/apache/ignite/internal/storage/pagememory/AbstractPageMemoryTableStorage.java:
##########
@@ -151,6 +152,12 @@ public void createIndex(String indexName) {
         throw new UnsupportedOperationException("Not implemented yet");
     }
 
+    @Override
+    @Nullable
+    public HashIndexStorage getHashIndex(int partitionId, String indexName) {
+        throw new UnsupportedOperationException("Not implemented yet");
+    }
+

Review Comment:
   ```suggestion
       @Override
       public @Nullable HashIndexStorage getHashIndex(int partitionId, String indexName) {
           throw new UnsupportedOperationException("Not implemented yet");
       }
   
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@ignite.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org