You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@iceberg.apache.org by GitBox <gi...@apache.org> on 2022/10/13 22:04:58 UTC

[GitHub] [iceberg] szehon-ho commented on a diff in pull request #5978: Docs: Typo in loading table from DataFrameReader

szehon-ho commented on code in PR #5978:
URL: https://github.com/apache/iceberg/pull/5978#discussion_r995161280


##########
docs/spark-queries.md:
##########
@@ -78,10 +78,10 @@ val df = spark.table("prod.db.table")
 Iceberg 0.11.0 adds multi-catalog support to `DataFrameReader` in both Spark 3.x and 2.4.
 
 Paths and table names can be loaded with Spark's `DataFrameReader` interface. How tables are loaded depends on how
-the identifier is specified. When using `spark.read.format("iceberg").path(table)` or `spark.table(table)` the `table`
+the identifier is specified. When using `spark.read.format("iceberg").load(table)` or `spark.table(table)` the `table`

Review Comment:
   I could not find 'path' method on DataFrameReader, only 'load', so I assume its a typo, unless it was removed sometime ago.  Also later in the doc 'load' is used.



##########
docs/spark-queries.md:
##########
@@ -78,10 +78,10 @@ val df = spark.table("prod.db.table")
 Iceberg 0.11.0 adds multi-catalog support to `DataFrameReader` in both Spark 3.x and 2.4.
 
 Paths and table names can be loaded with Spark's `DataFrameReader` interface. How tables are loaded depends on how
-the identifier is specified. When using `spark.read.format("iceberg").path(table)` or `spark.table(table)` the `table`
+the identifier is specified. When using `spark.read.format("iceberg").load(table)` or `spark.table(table)` the `table`
 variable can take a number of forms as listed below:
 
-*  `file:/path/to/table`: loads a HadoopTable at given path
+*  `file:///path/to/table`: loads a HadoopTable at given path

Review Comment:
   Also changed this part, Spark parser will not pass if there is file:/ at least for me, so added two other slashes



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org