svn commit: r727330 - /maven/components/trunk/maven-project/src/test/java/org/apache/maven/project/builder/PomConstructionTest.java

[jv...@apache.org]

Author: jvanzyl
Date: Wed Dec 17 01:53:09 2008
New Revision: 727330

URL: http://svn.apache.org/viewvc?rev=727330&view=rev
Log:
o notes about the testing

Modified:
    maven/components/trunk/maven-project/src/test/java/org/apache/maven/project/builder/PomConstructionTest.java

Modified: maven/components/trunk/maven-project/src/test/java/org/apache/maven/project/builder/PomConstructionTest.java
URL: http://svn.apache.org/viewvc/maven/components/trunk/maven-project/src/test/java/org/apache/maven/project/builder/PomConstructionTest.java?rev=727330&r1=727329&r2=727330&view=diff
==============================================================================
--- maven/components/trunk/maven-project/src/test/java/org/apache/maven/project/builder/PomConstructionTest.java (original)
+++ maven/components/trunk/maven-project/src/test/java/org/apache/maven/project/builder/PomConstructionTest.java Wed Dec 17 01:53:09 2008
@@ -52,8 +52,16 @@
         
         PomArtifactResolver resolver = new FileBasedPomArtifactResolver( artifacts );
                 
+        // make a version that doesn't require a null mixin set. for most pom construction tests we're
+        // not going to use mixins.
         PomClassicDomainModel model = projectBuilder.buildModel( nexusLauncher, null, resolver );  
         
+        // This will get extremely tedious unless we can shorten these into small expressions to
+        // retrieve the target values for testing.
+        
+        // model.build.plugins[0].executions
+        // model/build/plugins[0].executions
+        
         Model m = model.getModel();
         
         Plugin plugin = (Plugin) m.getBuild().getPlugins().get( 0 );
@@ -62,7 +70,9 @@
         
         //assertEquals( 7, executions.size() );
     }
-
+    
+    // Need to get this to walk around a directory and automatically build up the artifact set. If we
+    // follow some standard conventions this can be simple.
     class FileBasedPomArtifactResolver
         implements PomArtifactResolver
     {
@@ -76,7 +86,6 @@
         public void resolve( Artifact artifact )
             throws IOException
         {
-            System.out.println( artifact );
             artifact.setFile( artifacts.get(  artifact.getArtifactId() ) );
         }
     }