[GitHub] dubee commented on a change in pull request #4299: Avoid that actions do not stop after action timeout when logging heavily

[GitBox <gi...@apache.org>]

dubee commented on a change in pull request #4299: Avoid that actions do not stop after action timeout when logging heavily
URL: https://github.com/apache/incubator-openwhisk/pull/4299#discussion_r259072175
 
 

 ##########
 File path: common/scala/src/main/scala/org/apache/openwhisk/core/containerpool/logging/DockerToActivationFileLogStore.scala
 ##########
 @@ -123,7 +123,16 @@ class DockerToActivationFileLogStore(system: ActorSystem, destinationDirectory:
                            container: Container,
                            action: ExecutableWhiskAction): Future[ActivationLogs] = {
 
-    val logs = container.logs(action.limits.logs.asMegaBytes, action.exec.sentinelledLogs)(transid)
+    // wait for a sentinel only if no container (developer) error occurred to avoid
+    // that log collection continues if the action code still logs after timeout
+    val isContainerTimeoutError = activation.response.isContainerTimeoutError(action.limits.timeout.duration)
 
 Review comment:
   Can any of these vals reference the same vals from `DockerToActivationLogStore.scala`?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services