You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@atlas.apache.org by Sarath Subramanian <sa...@apache.org> on 2018/03/23 17:44:25 UTC
Review Request 66252: [ATLAS-2513]: Notifications are not sent about
impacted entities when classification is updated at source entity
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66252/
-----------------------------------------------------------
Review request for atlas, Apoorv Naik, Ashutosh Mestry, and Madhan Neethiraj.
Bugs: ATLAS-2513
https://issues.apache.org/jira/browse/ATLAS-2513
Repository: atlas
Description
-------
When a classification is updated for the following operations:
* Update attributes
* Add/Update validity periods
Notification messages are not sent about the impacted entities and only source entity information is sent in notification.
Diffs
-----
repository/src/main/java/org/apache/atlas/repository/store/graph/v1/EntityGraphMapper.java 57aa41b4
Diff: https://reviews.apache.org/r/66252/diff/1/
Testing
-------
Validated operations through POSTMAN rest client and notifications are sent about impacted entities as well.
Thanks,
Sarath Subramanian
Re: Review Request 66252: [ATLAS-2513]: Notifications are not sent
about
impacted entities when classification is updated at source entity
Posted by Madhan Neethiraj <ma...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66252/#review199904
-----------------------------------------------------------
repository/src/main/java/org/apache/atlas/repository/store/graph/v1/EntityGraphMapper.java
Line 1511 (original), 1513 (patched)
<https://reviews.apache.org/r/66252/#comment280414>
Consider renaming "computeImpactedEntityVertices" to "isClassificationUpdated"
repository/src/main/java/org/apache/atlas/repository/store/graph/v1/EntityGraphMapper.java
Lines 1529 (patched)
<https://reviews.apache.org/r/66252/#comment280413>
If all validityPeriods were removed in updated classification, line #1529 would skip setting currentClassification.
- Madhan Neethiraj
On March 23, 2018, 5:44 p.m., Sarath Subramanian wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/66252/
> -----------------------------------------------------------
>
> (Updated March 23, 2018, 5:44 p.m.)
>
>
> Review request for atlas, Apoorv Naik, Ashutosh Mestry, and Madhan Neethiraj.
>
>
> Bugs: ATLAS-2513
> https://issues.apache.org/jira/browse/ATLAS-2513
>
>
> Repository: atlas
>
>
> Description
> -------
>
> When a classification is updated for the following operations:
>
> * Update attributes
> * Add/Update validity periods
>
> Notification messages are not sent about the impacted entities and only source entity information is sent in notification.
>
>
> Diffs
> -----
>
> repository/src/main/java/org/apache/atlas/repository/store/graph/v1/EntityGraphMapper.java 57aa41b4
>
>
> Diff: https://reviews.apache.org/r/66252/diff/1/
>
>
> Testing
> -------
>
> Validated operations through POSTMAN rest client and notifications are sent about impacted entities as well.
>
>
> Thanks,
>
> Sarath Subramanian
>
>
Re: Review Request 66252: [ATLAS-2513]: Notifications are not sent
about
impacted entities when classification is updated at source entity
Posted by Madhan Neethiraj <ma...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66252/#review199915
-----------------------------------------------------------
Fix it, then Ship it!
repository/src/main/java/org/apache/atlas/repository/store/graph/v1/EntityGraphRetriever.java
Line 252 (original), 252 (patched)
<https://reviews.apache.org/r/66252/#comment280419>
It might be efficient to avoid creating a dummy instance in every call. Can you please try using a static final instance, as below?
private static final TypeReference<List<TimeBoundary>> TIME_BOUNDARIES_LIST_TYPE = new TypeReference<List<TimeBoundary>>() {};
ret.setValidityPeriods(AtlasJson.fromJson(strValidityPeriods, TIME_BOUNDARIES_LIST_TYPE);
- Madhan Neethiraj
On March 23, 2018, 9:13 p.m., Sarath Subramanian wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/66252/
> -----------------------------------------------------------
>
> (Updated March 23, 2018, 9:13 p.m.)
>
>
> Review request for atlas, Apoorv Naik, Ashutosh Mestry, and Madhan Neethiraj.
>
>
> Bugs: ATLAS-2513
> https://issues.apache.org/jira/browse/ATLAS-2513
>
>
> Repository: atlas
>
>
> Description
> -------
>
> When a classification is updated for the following operations:
>
> * Update attributes
> * Add/Update validity periods
>
> Notification messages are not sent about the impacted entities and only source entity information is sent in notification.
>
>
> Diffs
> -----
>
> repository/src/main/java/org/apache/atlas/repository/store/graph/v1/EntityGraphMapper.java 57aa41b4
> repository/src/main/java/org/apache/atlas/repository/store/graph/v1/EntityGraphRetriever.java 38851575
>
>
> Diff: https://reviews.apache.org/r/66252/diff/2/
>
>
> Testing
> -------
>
> Validated operations through POSTMAN rest client and notifications are sent about impacted entities as well.
>
>
> Thanks,
>
> Sarath Subramanian
>
>
Re: Review Request 66252: [ATLAS-2513]: Notifications are not sent
about
impacted entities when classification is updated at source entity
Posted by Madhan Neethiraj <ma...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66252/#review199920
-----------------------------------------------------------
Ship it!
Ship It!
- Madhan Neethiraj
On March 23, 2018, 11:49 p.m., Sarath Subramanian wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/66252/
> -----------------------------------------------------------
>
> (Updated March 23, 2018, 11:49 p.m.)
>
>
> Review request for atlas, Apoorv Naik, Ashutosh Mestry, and Madhan Neethiraj.
>
>
> Bugs: ATLAS-2513
> https://issues.apache.org/jira/browse/ATLAS-2513
>
>
> Repository: atlas
>
>
> Description
> -------
>
> When a classification is updated for the following operations:
>
> * Update attributes
> * Add/Update validity periods
>
> Notification messages are not sent about the impacted entities and only source entity information is sent in notification.
>
>
> Diffs
> -----
>
> repository/src/main/java/org/apache/atlas/repository/store/graph/v1/EntityGraphMapper.java 57aa41b4
> repository/src/main/java/org/apache/atlas/repository/store/graph/v1/EntityGraphRetriever.java 38851575
>
>
> Diff: https://reviews.apache.org/r/66252/diff/3/
>
>
> Testing
> -------
>
> Validated operations through POSTMAN rest client and notifications are sent about impacted entities as well.
>
>
> Thanks,
>
> Sarath Subramanian
>
>
Re: Review Request 66252: [ATLAS-2513]: Notifications are not sent
about
impacted entities when classification is updated at source entity
Posted by Sarath Subramanian <sa...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66252/
-----------------------------------------------------------
(Updated March 23, 2018, 4:49 p.m.)
Review request for atlas, Apoorv Naik, Ashutosh Mestry, and Madhan Neethiraj.
Bugs: ATLAS-2513
https://issues.apache.org/jira/browse/ATLAS-2513
Repository: atlas
Description
-------
When a classification is updated for the following operations:
* Update attributes
* Add/Update validity periods
Notification messages are not sent about the impacted entities and only source entity information is sent in notification.
Diffs (updated)
-----
repository/src/main/java/org/apache/atlas/repository/store/graph/v1/EntityGraphMapper.java 57aa41b4
repository/src/main/java/org/apache/atlas/repository/store/graph/v1/EntityGraphRetriever.java 38851575
Diff: https://reviews.apache.org/r/66252/diff/3/
Changes: https://reviews.apache.org/r/66252/diff/2-3/
Testing
-------
Validated operations through POSTMAN rest client and notifications are sent about impacted entities as well.
Thanks,
Sarath Subramanian
Re: Review Request 66252: [ATLAS-2513]: Notifications are not sent
about
impacted entities when classification is updated at source entity
Posted by Sarath Subramanian <sa...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66252/
-----------------------------------------------------------
(Updated March 23, 2018, 2:13 p.m.)
Review request for atlas, Apoorv Naik, Ashutosh Mestry, and Madhan Neethiraj.
Changes
-------
addressed review comments.
Bugs: ATLAS-2513
https://issues.apache.org/jira/browse/ATLAS-2513
Repository: atlas
Description
-------
When a classification is updated for the following operations:
* Update attributes
* Add/Update validity periods
Notification messages are not sent about the impacted entities and only source entity information is sent in notification.
Diffs (updated)
-----
repository/src/main/java/org/apache/atlas/repository/store/graph/v1/EntityGraphMapper.java 57aa41b4
repository/src/main/java/org/apache/atlas/repository/store/graph/v1/EntityGraphRetriever.java 38851575
Diff: https://reviews.apache.org/r/66252/diff/2/
Changes: https://reviews.apache.org/r/66252/diff/1-2/
Testing
-------
Validated operations through POSTMAN rest client and notifications are sent about impacted entities as well.
Thanks,
Sarath Subramanian