You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Andrei Sekretenko <as...@mesosphere.io> on 2019/07/01 13:34:11 UTC
Re: Review Request 70947: Added `reviveOffers(roles)` to V0 Java
bindings.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70947/
-----------------------------------------------------------
(Updated July 1, 2019, 1:34 p.m.)
Review request for mesos and Benjamin Mahler.
Bugs: MESOS-9849
https://issues.apache.org/jira/browse/MESOS-9849
Repository: mesos
Description
-------
Added `reviveOffers(roles)` to V0 Java bindings.
Diffs (updated)
-----
src/java/jni/org_apache_mesos_MesosSchedulerDriver.cpp a21aca23cbef27b3c54bf1ae5834cbb457608130
src/java/src/org/apache/mesos/MesosSchedulerDriver.java 55ebc8772d9183286c908b4dba342109f28394f4
src/java/src/org/apache/mesos/SchedulerDriver.java ee5a9e24956299d84ff03a0fc5a22e641470a03f
Diff: https://reviews.apache.org/r/70947/diff/2/
Changes: https://reviews.apache.org/r/70947/diff/1-2/
Testing
-------
`./bin/mesos-tests.sh --gtest_filter="ExamplesTest.JavaFramework" --gtest_break_on_failure --gtest_repeat=10` with a patch from https://reviews.apache.org/r/70946/
Thanks,
Andrei Sekretenko
Re: Review Request 70947: Added `reviveOffers(roles)` to V0 Java
bindings.
Posted by Benjamin Mahler <bm...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70947/#review216391
-----------------------------------------------------------
Ship it!
src/java/src/org/apache/mesos/SchedulerDriver.java
Lines 272-275 (patched)
<https://reviews.apache.org/r/70947/#comment303608>
Some extra spaces here?
- Benjamin Mahler
On July 4, 2019, 3:23 p.m., Andrei Sekretenko wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/70947/
> -----------------------------------------------------------
>
> (Updated July 4, 2019, 3:23 p.m.)
>
>
> Review request for mesos and Benjamin Mahler.
>
>
> Bugs: MESOS-9849
> https://issues.apache.org/jira/browse/MESOS-9849
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Added `reviveOffers(roles)` to V0 Java bindings.
>
>
> Diffs
> -----
>
> src/java/jni/org_apache_mesos_MesosSchedulerDriver.cpp f81a69a7f13f976a09f11409a0ea3f40fccea1b8
> src/java/src/org/apache/mesos/MesosSchedulerDriver.java 772a7383328519e63f0bf31908cb4c2129a77315
> src/java/src/org/apache/mesos/SchedulerDriver.java 155e4ac7b0e507c549a2d2de07ab95e215bf39e0
>
>
> Diff: https://reviews.apache.org/r/70947/diff/4/
>
>
> Testing
> -------
>
> `./bin/mesos-tests.sh --gtest_filter="ExamplesTest.JavaFramework" --gtest_break_on_failure --gtest_repeat=10` with a patch from https://reviews.apache.org/r/70946/
>
>
> Thanks,
>
> Andrei Sekretenko
>
>
Re: Review Request 70947: Added `reviveOffers(roles)` to V0 Java
bindings.
Posted by Andrei Sekretenko <as...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70947/
-----------------------------------------------------------
(Updated July 4, 2019, 3:23 p.m.)
Review request for mesos and Benjamin Mahler.
Bugs: MESOS-9849
https://issues.apache.org/jira/browse/MESOS-9849
Repository: mesos
Description
-------
Added `reviveOffers(roles)` to V0 Java bindings.
Diffs (updated)
-----
src/java/jni/org_apache_mesos_MesosSchedulerDriver.cpp f81a69a7f13f976a09f11409a0ea3f40fccea1b8
src/java/src/org/apache/mesos/MesosSchedulerDriver.java 772a7383328519e63f0bf31908cb4c2129a77315
src/java/src/org/apache/mesos/SchedulerDriver.java 155e4ac7b0e507c549a2d2de07ab95e215bf39e0
Diff: https://reviews.apache.org/r/70947/diff/4/
Changes: https://reviews.apache.org/r/70947/diff/3-4/
Testing
-------
`./bin/mesos-tests.sh --gtest_filter="ExamplesTest.JavaFramework" --gtest_break_on_failure --gtest_repeat=10` with a patch from https://reviews.apache.org/r/70946/
Thanks,
Andrei Sekretenko
Re: Review Request 70947: Added `reviveOffers(roles)` to V0 Java
bindings.
Posted by Benjamin Mahler <bm...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70947/#review216363
-----------------------------------------------------------
src/java/src/org/apache/mesos/MesosSchedulerDriver.java
Lines 396-398 (patched)
<https://reviews.apache.org/r/70947/#comment303565>
Why the extra level of indirection? Why not just make this native like the others?
- Benjamin Mahler
On July 3, 2019, 5:03 p.m., Andrei Sekretenko wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/70947/
> -----------------------------------------------------------
>
> (Updated July 3, 2019, 5:03 p.m.)
>
>
> Review request for mesos and Benjamin Mahler.
>
>
> Bugs: MESOS-9849
> https://issues.apache.org/jira/browse/MESOS-9849
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Added `reviveOffers(roles)` to V0 Java bindings.
>
>
> Diffs
> -----
>
> src/java/jni/org_apache_mesos_MesosSchedulerDriver.cpp f81a69a7f13f976a09f11409a0ea3f40fccea1b8
> src/java/src/org/apache/mesos/MesosSchedulerDriver.java 772a7383328519e63f0bf31908cb4c2129a77315
> src/java/src/org/apache/mesos/SchedulerDriver.java 155e4ac7b0e507c549a2d2de07ab95e215bf39e0
>
>
> Diff: https://reviews.apache.org/r/70947/diff/3/
>
>
> Testing
> -------
>
> `./bin/mesos-tests.sh --gtest_filter="ExamplesTest.JavaFramework" --gtest_break_on_failure --gtest_repeat=10` with a patch from https://reviews.apache.org/r/70946/
>
>
> Thanks,
>
> Andrei Sekretenko
>
>
Re: Review Request 70947: Added `reviveOffers(roles)` to V0 Java
bindings.
Posted by Andrei Sekretenko <as...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70947/
-----------------------------------------------------------
(Updated July 3, 2019, 5:03 p.m.)
Review request for mesos and Benjamin Mahler.
Changes
-------
Made reviving an empty vector of roles a no-op.
Bugs: MESOS-9849
https://issues.apache.org/jira/browse/MESOS-9849
Repository: mesos
Description
-------
Added `reviveOffers(roles)` to V0 Java bindings.
Diffs (updated)
-----
src/java/jni/org_apache_mesos_MesosSchedulerDriver.cpp f81a69a7f13f976a09f11409a0ea3f40fccea1b8
src/java/src/org/apache/mesos/MesosSchedulerDriver.java 772a7383328519e63f0bf31908cb4c2129a77315
src/java/src/org/apache/mesos/SchedulerDriver.java 155e4ac7b0e507c549a2d2de07ab95e215bf39e0
Diff: https://reviews.apache.org/r/70947/diff/3/
Changes: https://reviews.apache.org/r/70947/diff/2-3/
Testing
-------
`./bin/mesos-tests.sh --gtest_filter="ExamplesTest.JavaFramework" --gtest_break_on_failure --gtest_repeat=10` with a patch from https://reviews.apache.org/r/70946/
Thanks,
Andrei Sekretenko