You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@geronimo.apache.org by "Viet Hung Nguyen (JIRA)" <ji...@apache.org> on 2007/10/09 17:55:50 UTC
[jira] Created: (GERONIMO-3520) missing jsr-77 stats for JTA
missing jsr-77 stats for JTA
----------------------------
Key: GERONIMO-3520
URL: https://issues.apache.org/jira/browse/GERONIMO-3520
Project: Geronimo
Issue Type: Improvement
Security Level: public (Regular issues)
Components: monitoring, transaction manager
Affects Versions: 2.0.2, 2.1
Environment: linux
Reporter: Viet Hung Nguyen
we need to surface transaction statistics defined by the JSR 77 spec.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (GERONIMO-3520) missing jsr-77 stats for JTA
Posted by "Viet Hung Nguyen (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/GERONIMO-3520?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Viet Hung Nguyen updated GERONIMO-3520:
---------------------------------------
Attachment: txmanagerStats.patch
this patch is meant to be applied to the source tree at svn.apache.org/repos/asf/geronimo/components/txmanager/trunk
It keeps 2 counters and updates them accordingly.
> missing jsr-77 stats for JTA
> ----------------------------
>
> Key: GERONIMO-3520
> URL: https://issues.apache.org/jira/browse/GERONIMO-3520
> Project: Geronimo
> Issue Type: Improvement
> Security Level: public(Regular issues)
> Components: monitoring, transaction manager
> Affects Versions: 2.0.2, 2.1
> Environment: linux
> Reporter: Viet Hung Nguyen
> Attachments: txmanagerStats.patch
>
>
> we need to surface transaction statistics defined by the JSR 77 spec.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Resolved: (GERONIMO-3520) missing jsr-77 stats for JTA
Posted by "Viet Hung Nguyen (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/GERONIMO-3520?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Viet Hung Nguyen resolved GERONIMO-3520.
----------------------------------------
Resolution: Fixed
> missing jsr-77 stats for JTA
> ----------------------------
>
> Key: GERONIMO-3520
> URL: https://issues.apache.org/jira/browse/GERONIMO-3520
> Project: Geronimo
> Issue Type: Improvement
> Security Level: public(Regular issues)
> Components: monitoring, transaction manager
> Affects Versions: 2.0.2, 2.1
> Environment: linux
> Reporter: Viet Hung Nguyen
> Assignee: Anita Kulshreshtha
> Attachments: geronimo-3520.patch, jms-mdb-sample-ear-2.0-SNAPSHOT.ear, txmanagerStats.patch
>
>
> we need to surface transaction statistics defined by the JSR 77 spec.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Assigned: (GERONIMO-3520) missing jsr-77 stats for JTA
Posted by "Anita Kulshreshtha (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/GERONIMO-3520?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Anita Kulshreshtha reassigned GERONIMO-3520:
--------------------------------------------
Assignee: Anita Kulshreshtha
> missing jsr-77 stats for JTA
> ----------------------------
>
> Key: GERONIMO-3520
> URL: https://issues.apache.org/jira/browse/GERONIMO-3520
> Project: Geronimo
> Issue Type: Improvement
> Security Level: public(Regular issues)
> Components: monitoring, transaction manager
> Affects Versions: 2.0.2, 2.1
> Environment: linux
> Reporter: Viet Hung Nguyen
> Assignee: Anita Kulshreshtha
> Attachments: geronimo-3520.patch, jms-mdb-sample-ear-2.0-SNAPSHOT.ear, txmanagerStats.patch
>
>
> we need to surface transaction statistics defined by the JSR 77 spec.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (GERONIMO-3520) missing jsr-77 stats for JTA
Posted by "Viet Hung Nguyen (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/GERONIMO-3520?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12534037 ]
Viet Hung Nguyen commented on GERONIMO-3520:
--------------------------------------------
Anita, I thought since the application was using JMS, each message sent would be a transaction.
> missing jsr-77 stats for JTA
> ----------------------------
>
> Key: GERONIMO-3520
> URL: https://issues.apache.org/jira/browse/GERONIMO-3520
> Project: Geronimo
> Issue Type: Improvement
> Security Level: public(Regular issues)
> Components: monitoring, transaction manager
> Affects Versions: 2.0.2, 2.1
> Environment: linux
> Reporter: Viet Hung Nguyen
> Attachments: geronimo-3520.patch, jms-mdb-sample-ear-2.0-SNAPSHOT.ear, txmanagerStats.patch
>
>
> we need to surface transaction statistics defined by the JSR 77 spec.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (GERONIMO-3520) missing jsr-77 stats for JTA
Posted by "Viet Hung Nguyen (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/GERONIMO-3520?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Viet Hung Nguyen updated GERONIMO-3520:
---------------------------------------
Attachment: (was: txmanagerStats.patch)
> missing jsr-77 stats for JTA
> ----------------------------
>
> Key: GERONIMO-3520
> URL: https://issues.apache.org/jira/browse/GERONIMO-3520
> Project: Geronimo
> Issue Type: Improvement
> Security Level: public(Regular issues)
> Components: monitoring, transaction manager
> Affects Versions: 2.0.2, 2.1
> Environment: linux
> Reporter: Viet Hung Nguyen
> Attachments: geronimo-3520.patch, jms-mdb-sample-ear-2.0-SNAPSHOT.ear, txmanagerStats.patch
>
>
> we need to surface transaction statistics defined by the JSR 77 spec.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (GERONIMO-3520) missing jsr-77 stats for JTA
Posted by "Anita Kulshreshtha (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/GERONIMO-3520?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12534003 ]
Anita Kulshreshtha commented on GERONIMO-3520:
----------------------------------------------
Viet, It might be possible to optimize the computation of ActiveCount by incrementing/decrementing a counter when ever the transactions are associated/disassociated instead of going through the Map every time.
Could you please explain how/where the transactions are started in the attached application ear?
> missing jsr-77 stats for JTA
> ----------------------------
>
> Key: GERONIMO-3520
> URL: https://issues.apache.org/jira/browse/GERONIMO-3520
> Project: Geronimo
> Issue Type: Improvement
> Security Level: public(Regular issues)
> Components: monitoring, transaction manager
> Affects Versions: 2.0.2, 2.1
> Environment: linux
> Reporter: Viet Hung Nguyen
> Attachments: geronimo-3520.patch, jms-mdb-sample-ear-2.0-SNAPSHOT.ear, txmanagerStats.patch
>
>
> we need to surface transaction statistics defined by the JSR 77 spec.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (GERONIMO-3520) missing jsr-77 stats for JTA
Posted by "Anita Kulshreshtha (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/GERONIMO-3520?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12535556 ]
Anita Kulshreshtha commented on GERONIMO-3520:
----------------------------------------------
Txmaanger patch applied to rev 584554 at txmanager/trunk
geronimo patch applied to rev 585497 with minor modifications, Nice Work Viet, Thanks!
I have mistakenly entered wrong jira # 3250 in the logs, Sorry for the goof..
> missing jsr-77 stats for JTA
> ----------------------------
>
> Key: GERONIMO-3520
> URL: https://issues.apache.org/jira/browse/GERONIMO-3520
> Project: Geronimo
> Issue Type: Improvement
> Security Level: public(Regular issues)
> Components: monitoring, transaction manager
> Affects Versions: 2.0.2, 2.1
> Environment: linux
> Reporter: Viet Hung Nguyen
> Assignee: Anita Kulshreshtha
> Attachments: geronimo-3520.patch, jms-mdb-sample-ear-2.0-SNAPSHOT.ear, txmanagerStats.patch
>
>
> we need to surface transaction statistics defined by the JSR 77 spec.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (GERONIMO-3520) missing jsr-77 stats for JTA
Posted by "Viet Hung Nguyen (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/GERONIMO-3520?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Viet Hung Nguyen updated GERONIMO-3520:
---------------------------------------
Attachment: geronimo-3520.patch
this patch allows the MBean to actually see the statistics that are being kept track of in the Transaction Manager.
> missing jsr-77 stats for JTA
> ----------------------------
>
> Key: GERONIMO-3520
> URL: https://issues.apache.org/jira/browse/GERONIMO-3520
> Project: Geronimo
> Issue Type: Improvement
> Security Level: public(Regular issues)
> Components: monitoring, transaction manager
> Affects Versions: 2.0.2, 2.1
> Environment: linux
> Reporter: Viet Hung Nguyen
> Attachments: geronimo-3520.patch, txmanagerStats.patch
>
>
> we need to surface transaction statistics defined by the JSR 77 spec.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Issue Comment Edited: (GERONIMO-3520) missing jsr-77 stats
for JTA
Posted by "Viet Hung Nguyen (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/GERONIMO-3520?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12534037 ]
vhnguyen edited comment on GERONIMO-3520 at 10/11/07 6:35 AM:
----------------------------------------------------------------------
Anita, I thought since the application was using JMS, each message sent would be a transaction. The transaction call is actually in AMQ's code.
was (Author: vhnguyen):
Anita, I thought since the application was using JMS, each message sent would be a transaction.
> missing jsr-77 stats for JTA
> ----------------------------
>
> Key: GERONIMO-3520
> URL: https://issues.apache.org/jira/browse/GERONIMO-3520
> Project: Geronimo
> Issue Type: Improvement
> Security Level: public(Regular issues)
> Components: monitoring, transaction manager
> Affects Versions: 2.0.2, 2.1
> Environment: linux
> Reporter: Viet Hung Nguyen
> Attachments: geronimo-3520.patch, jms-mdb-sample-ear-2.0-SNAPSHOT.ear, txmanagerStats.patch
>
>
> we need to surface transaction statistics defined by the JSR 77 spec.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (GERONIMO-3520) missing jsr-77 stats for JTA
Posted by "Anita Kulshreshtha (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/GERONIMO-3520?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12533724 ]
Anita Kulshreshtha commented on GERONIMO-3520:
----------------------------------------------
Could you please provide a test/application to test this patch?
> missing jsr-77 stats for JTA
> ----------------------------
>
> Key: GERONIMO-3520
> URL: https://issues.apache.org/jira/browse/GERONIMO-3520
> Project: Geronimo
> Issue Type: Improvement
> Security Level: public(Regular issues)
> Components: monitoring, transaction manager
> Affects Versions: 2.0.2, 2.1
> Environment: linux
> Reporter: Viet Hung Nguyen
> Attachments: geronimo-3520.patch, txmanagerStats.patch
>
>
> we need to surface transaction statistics defined by the JSR 77 spec.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Issue Comment Edited: (GERONIMO-3520) missing jsr-77 stats
for JTA
Posted by "Viet Hung Nguyen (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/GERONIMO-3520?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12533396 ]
vhnguyen edited comment on GERONIMO-3520 at 10/9/07 9:07 AM:
---------------------------------------------------------------------
this patch is meant to be applied to the source tree at svn.apache.org/repos/asf/geronimo/components/txmanager/
It keeps 2 counters and updates them accordingly.
was (Author: vhnguyen):
this patch is meant to be applied to the source tree at svn.apache.org/repos/asf/geronimo/components/txmanager/trunk
It keeps 2 counters and updates them accordingly.
> missing jsr-77 stats for JTA
> ----------------------------
>
> Key: GERONIMO-3520
> URL: https://issues.apache.org/jira/browse/GERONIMO-3520
> Project: Geronimo
> Issue Type: Improvement
> Security Level: public(Regular issues)
> Components: monitoring, transaction manager
> Affects Versions: 2.0.2, 2.1
> Environment: linux
> Reporter: Viet Hung Nguyen
> Attachments: geronimo-3520.patch, txmanagerStats.patch
>
>
> we need to surface transaction statistics defined by the JSR 77 spec.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (GERONIMO-3520) missing jsr-77 stats for JTA
Posted by "Matt Hogstrom (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/GERONIMO-3520?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12533925 ]
Matt Hogstrom commented on GERONIMO-3520:
-----------------------------------------
Viet, for the txmanager patch I think there may be an issue with the use of the static long. Since the access is not synchronized there exists a strong possibility of lost updates in a heavily concurrent system which would lead to inaccurate values. volatile is one way to address this problem but I don't think it is perfect on all VMs so I think the better solution would be the use of java.util.concurrent.atomic.AtomicLong .getAndIncrement() which should do the trick. Not sure of other folks have suggestions.
> missing jsr-77 stats for JTA
> ----------------------------
>
> Key: GERONIMO-3520
> URL: https://issues.apache.org/jira/browse/GERONIMO-3520
> Project: Geronimo
> Issue Type: Improvement
> Security Level: public(Regular issues)
> Components: monitoring, transaction manager
> Affects Versions: 2.0.2, 2.1
> Environment: linux
> Reporter: Viet Hung Nguyen
> Attachments: geronimo-3520.patch, jms-mdb-sample-ear-2.0-SNAPSHOT.ear, txmanagerStats.patch
>
>
> we need to surface transaction statistics defined by the JSR 77 spec.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (GERONIMO-3520) missing jsr-77 stats for JTA
Posted by "Viet Hung Nguyen (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/GERONIMO-3520?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Viet Hung Nguyen updated GERONIMO-3520:
---------------------------------------
Attachment: jms-mdb-sample-ear-2.0-SNAPSHOT.ear
sorry, I should have thought of this. Once you deploy the app, just fill out the form, it will send a message to standard output.
> missing jsr-77 stats for JTA
> ----------------------------
>
> Key: GERONIMO-3520
> URL: https://issues.apache.org/jira/browse/GERONIMO-3520
> Project: Geronimo
> Issue Type: Improvement
> Security Level: public(Regular issues)
> Components: monitoring, transaction manager
> Affects Versions: 2.0.2, 2.1
> Environment: linux
> Reporter: Viet Hung Nguyen
> Attachments: geronimo-3520.patch, jms-mdb-sample-ear-2.0-SNAPSHOT.ear, txmanagerStats.patch
>
>
> we need to surface transaction statistics defined by the JSR 77 spec.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (GERONIMO-3520) missing jsr-77 stats for JTA
Posted by "Viet Hung Nguyen (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/GERONIMO-3520?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Viet Hung Nguyen updated GERONIMO-3520:
---------------------------------------
Attachment: txmanagerStats.patch
Updated the patch to use AtomicLong for statistic counters to avoid having inaccurate values due to threading like Matt suggested. Also, keeps track of another attribute for activeCount and increments/decrements accordingly (i.e. when associate() and unassociate() are called) like Anita suggested.
> missing jsr-77 stats for JTA
> ----------------------------
>
> Key: GERONIMO-3520
> URL: https://issues.apache.org/jira/browse/GERONIMO-3520
> Project: Geronimo
> Issue Type: Improvement
> Security Level: public(Regular issues)
> Components: monitoring, transaction manager
> Affects Versions: 2.0.2, 2.1
> Environment: linux
> Reporter: Viet Hung Nguyen
> Attachments: geronimo-3520.patch, jms-mdb-sample-ear-2.0-SNAPSHOT.ear, txmanagerStats.patch
>
>
> we need to surface transaction statistics defined by the JSR 77 spec.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.