You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@calcite.apache.org by GitBox <gi...@apache.org> on 2020/09/12 08:45:20 UTC
[GitHub] [calcite] vlsi commented on a change in pull request #2148: [CALCITE-4250] Failed to get original column of aggregate operator
vlsi commented on a change in pull request #2148:
URL: https://github.com/apache/calcite/pull/2148#discussion_r487386711
##########
File path: core/src/test/java/org/apache/calcite/materialize/NormalizationTrimFieldTest.java
##########
@@ -105,4 +107,25 @@
final String relOptimizedStr = RelOptUtil.toString(relOptimized.get(0).getKey());
assertThat(isLinux(optimized).matches(relOptimizedStr), is(true));
}
+
+ @Test void testAggregateRelMdColumnOrigins() {
+ final RelBuilder relBuilder = RelBuilder.create(config().build());
+ final LogicalProject project = (LogicalProject) relBuilder.scan("EMP")
+ .project(relBuilder.field("EMPNO"),
+ relBuilder.field("ENAME"),
+ relBuilder.field("JOB"),
+ relBuilder.field("SAL"),
+ relBuilder.field("DEPTNO")).build();
+ final LogicalAggregate aggregate = (LogicalAggregate) relBuilder.push(project)
+ .aggregate(
+ relBuilder.groupKey(relBuilder.field(1, 0, "DEPTNO")),
+ relBuilder.count(relBuilder.field(1, 0, "SAL")))
+ .build();
+ RelMetadataQuery mq = aggregate.getCluster().getMetadataQuery();
+ final RelColumnOrigin nameColumn = mq.getColumnOrigin(aggregate, 0);
+ assertThat(nameColumn.getOriginTable().getRowType().
+ getFieldNames().get(7).equals("DEPTNO"), is(true));
+ assertThat(nameColumn.getOriginColumnOrdinal() == 7, is(true));
Review comment:
Please, avoid `assertThat(..., is(true))` pattern because it results in very hard to understand test failures (... expected true got false).
The test failure message should be understandable without looking into the source code and/or JIRA.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org