[GitHub] [royale-asjs] piotrzarzycki21 commented on a change in pull request #1153: Jewel VirtualComboBox only recognises itemRenderers assigned via className

[GitBox <gi...@apache.org>]

piotrzarzycki21 commented on a change in pull request #1153:
URL: https://github.com/apache/royale-asjs/pull/1153#discussion_r720024842



##########
File path: frameworks/projects/Jewel/src/main/royale/org/apache/royale/jewel/beads/views/VirtualComboBoxPopUpView.as
##########
@@ -58,6 +59,11 @@ package org.apache.royale.jewel.beads.views
                 _list = new VirtualList();
 				_list.addEventListener("beadsAdded", beadsAddedHandler);
             }
+
+			if((_strand as VirtualComboBoxPopUp).itemRenderer)

Review comment:
       I think this changes should be made in setter of strand if possible. I would also make it in following way:
   
   ```
   var virtualComboBoxPopup:VirtualComboBoxPopUp = _strand as VirtualComboBoxPopUp;
   if (virtualComboBoxPopup && virtualComboBoxPopup.itemRenderer)
   {
        list.itemRenderer = virtualComboBoxPopup.itemRenderer;
   }
   ```




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@royale.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org