[jira] Commented: (SOLR-976) deleteByQuery is ignored when deleteById is placed prior to deleteByQuery in a

["Hoss Man (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/SOLR-976?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12667494#action_12667494 ] 

Hoss Man commented on SOLR-976:
-------------------------------

the patch makes sense -- XMLLoader is at fault for not clearing out those variables before reusing the DeleteUpdateCommand .. but i'm curious if people think it would also make sense to make DeleteUpdateCommand and RunUpdateProcessor more forgiving in cases where both id and query are set, is there any reason not to execute them both?

or at the very least: RunUpdateProcessor can log an error if both are set.

> deleteByQuery is ignored when deleteById is placed prior to deleteByQuery in a <delete> 
> ----------------------------------------------------------------------------------------
>
>                 Key: SOLR-976
>                 URL: https://issues.apache.org/jira/browse/SOLR-976
>             Project: Solr
>          Issue Type: Bug
>            Reporter: Koji Sekiguchi
>            Priority: Trivial
>             Fix For: 1.4
>
>         Attachments: SOLR-976.patch
>
>
> Due to the following if block, deleteByQuery cannot be executed. cmd.id and cmd.query should be set to null when UpdateProcessor chain is finished.
> {code:title=RunUpdateProcessor}
> public void processDelete(DeleteUpdateCommand cmd) throws IOException {
>   if( cmd.id != null ) {
>     updateHandler.delete(cmd);
>   }
>   else {
>     updateHandler.deleteByQuery(cmd);
>   }
>   super.processDelete(cmd);
> }
> {code}

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.