You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pinot.apache.org by "chunxiaozheng (via GitHub)" <gi...@apache.org> on 2024/11/06 09:20:46 UTC
[PR] Support TIMESTAMP_NTZ, DATE and TIME datatype [pinot]
chunxiaozheng opened a new pull request, #14398:
URL: https://github.com/apache/pinot/pull/14398
Instructions:
1. The PR has to be tagged with at least one of the following labels (i):
1. `feature`
2. `bugfix`
3. `performance`
4. `ui`
5. `backward-incompat`
6. `release-notes` (**)
This PR add TIMESTAMP_NTZ, DATE and TIME datatype.
For flink, TIMESTAMP does not have time zone, which corresponds to TIMESTAMP_NTZ in pinot, TIMESTAMP_LTZ has local time zone, which corresponds to TIMESTAMP in pinot.
For spark, TIMESTAMP has local time zone, which corresponds to TIMESTAMP in pinot, TIMESTAMP_NTZ does not have time zone, which corresponds to TIMESTAMP_NTZ in pinot.
In my case, the schema of my table is as follows
<img width="257" alt="image" src="https://github.com/user-attachments/assets/1749d56c-d8c9-4bfc-82e7-af6f27aa5bbb">
and the query result is as follows
<img width="1277" alt="image" src="https://github.com/user-attachments/assets/b75b4555-7c2e-4953-8127-bfb9f20bb96b">
the schema json of TIME, DATE, TIMESTAMP_NTZ and TIMESTAMP is as follows
```
"dimensionFieldSpecs": [
{
"name": "time_field",
"dataType": "TIME"
},
{
"name": "date_field",
"dataType": "DATE"
},
{
"name": "timestamp_ntz_field",
"dataType": "TIMESTAMP_NTZ"
},
{
"name": "timestamp_ltz_field",
"dataType": "TIMESTAMP"
}
]
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org
Re: [PR] Support TIMESTAMP_NTZ, DATE and TIME datatype [pinot]
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #14398:
URL: https://github.com/apache/pinot/pull/14398#issuecomment-2459277053
## [Codecov](https://app.codecov.io/gh/apache/pinot/pull/14398?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
Attention: Patch coverage is `4.88127%` with `721 lines` in your changes missing coverage. Please review.
> Project coverage is 34.05%. Comparing base [(`59551e4`)](https://app.codecov.io/gh/apache/pinot/commit/59551e45224f1535c4863fd577622b37366ccc97?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) to head [(`7cf378f`)](https://app.codecov.io/gh/apache/pinot/commit/7cf378f5aa22e6645166bb71ef6342f81baa2b35?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
> Report is 1293 commits behind head on master.
| [Files with missing lines](https://app.codecov.io/gh/apache/pinot/pull/14398?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines |
|---|---|---|
| [...a/org/apache/pinot/common/utils/PinotDataType.java](https://app.codecov.io/gh/apache/pinot/pull/14398?src=pr&el=tree&filepath=pinot-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fpinot%2Fcommon%2Futils%2FPinotDataType.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-cGlub3QtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9waW5vdC9jb21tb24vdXRpbHMvUGlub3REYXRhVHlwZS5qYXZh) | 3.68% | [154 Missing and 3 partials :warning: ](https://app.codecov.io/gh/apache/pinot/pull/14398?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...java/org/apache/pinot/common/utils/DataSchema.java](https://app.codecov.io/gh/apache/pinot/pull/14398?src=pr&el=tree&filepath=pinot-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fpinot%2Fcommon%2Futils%2FDataSchema.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-cGlub3QtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9waW5vdC9jb21tb24vdXRpbHMvRGF0YVNjaGVtYS5qYXZh) | 5.17% | [110 Missing :warning: ](https://app.codecov.io/gh/apache/pinot/pull/14398?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...ator/transform/function/CastTransformFunction.java](https://app.codecov.io/gh/apache/pinot/pull/14398?src=pr&el=tree&filepath=pinot-core%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fpinot%2Fcore%2Foperator%2Ftransform%2Ffunction%2FCastTransformFunction.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-cGlub3QtY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvY29yZS9vcGVyYXRvci90cmFuc2Zvcm0vZnVuY3Rpb24vQ2FzdFRyYW5zZm9ybUZ1bmN0aW9uLmphdmE=) | 0.00% | [105 Missing :warning: ](https://app.codecov.io/gh/apache/pinot/pull/14398?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...ava/org/apache/pinot/spi/utils/ArrayCopyUtils.java](https://app.codecov.io/gh/apache/pinot/pull/14398?src=pr&el=tree&filepath=pinot-spi%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fpinot%2Fspi%2Futils%2FArrayCopyUtils.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-cGlub3Qtc3BpL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9waW5vdC9zcGkvdXRpbHMvQXJyYXlDb3B5VXRpbHMuamF2YQ==) | 0.00% | [48 Missing :warning: ](https://app.codecov.io/gh/apache/pinot/pull/14398?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...sform/function/ScalarTransformFunctionWrapper.java](https://app.codecov.io/gh/apache/pinot/pull/14398?src=pr&el=tree&filepath=pinot-core%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fpinot%2Fcore%2Foperator%2Ftransform%2Ffunction%2FScalarTransformFunctionWrapper.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-cGlub3QtY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvY29yZS9vcGVyYXRvci90cmFuc2Zvcm0vZnVuY3Rpb24vU2NhbGFyVHJhbnNmb3JtRnVuY3Rpb25XcmFwcGVyLmphdmE=) | 0.00% | [40 Missing :warning: ](https://app.codecov.io/gh/apache/pinot/pull/14398?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...ava/org/apache/pinot/spi/utils/TimestampUtils.java](https://app.codecov.io/gh/apache/pinot/pull/14398?src=pr&el=tree&filepath=pinot-spi%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fpinot%2Fspi%2Futils%2FTimestampUtils.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-cGlub3Qtc3BpL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9waW5vdC9zcGkvdXRpbHMvVGltZXN0YW1wVXRpbHMuamF2YQ==) | 0.00% | [31 Missing :warning: ](https://app.codecov.io/gh/apache/pinot/pull/14398?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [.../function/ParentExprMinMaxAggregationFunction.java](https://app.codecov.io/gh/apache/pinot/pull/14398?src=pr&el=tree&filepath=pinot-core%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fpinot%2Fcore%2Fquery%2Faggregation%2Ffunction%2FParentExprMinMaxAggregationFunction.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-cGlub3QtY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvY29yZS9xdWVyeS9hZ2dyZWdhdGlvbi9mdW5jdGlvbi9QYXJlbnRFeHByTWluTWF4QWdncmVnYXRpb25GdW5jdGlvbi5qYXZh) | 0.00% | [27 Missing :warning: ](https://app.codecov.io/gh/apache/pinot/pull/14398?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...mon/request/context/predicate/BaseInPredicate.java](https://app.codecov.io/gh/apache/pinot/pull/14398?src=pr&el=tree&filepath=pinot-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fpinot%2Fcommon%2Frequest%2Fcontext%2Fpredicate%2FBaseInPredicate.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-cGlub3QtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9waW5vdC9jb21tb24vcmVxdWVzdC9jb250ZXh0L3ByZWRpY2F0ZS9CYXNlSW5QcmVkaWNhdGUuamF2YQ==) | 0.00% | [24 Missing :warning: ](https://app.codecov.io/gh/apache/pinot/pull/14398?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...core/operator/filter/predicate/PredicateUtils.java](https://app.codecov.io/gh/apache/pinot/pull/14398?src=pr&el=tree&filepath=pinot-core%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fpinot%2Fcore%2Foperator%2Ffilter%2Fpredicate%2FPredicateUtils.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-cGlub3QtY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvY29yZS9vcGVyYXRvci9maWx0ZXIvcHJlZGljYXRlL1ByZWRpY2F0ZVV0aWxzLmphdmE=) | 0.00% | [24 Missing :warning: ](https://app.codecov.io/gh/apache/pinot/pull/14398?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...aggregation/function/AggregationFunctionUtils.java](https://app.codecov.io/gh/apache/pinot/pull/14398?src=pr&el=tree&filepath=pinot-core%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fpinot%2Fcore%2Fquery%2Faggregation%2Ffunction%2FAggregationFunctionUtils.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-cGlub3QtY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvY29yZS9xdWVyeS9hZ2dyZWdhdGlvbi9mdW5jdGlvbi9BZ2dyZWdhdGlvbkZ1bmN0aW9uVXRpbHMuamF2YQ==) | 0.00% | [21 Missing :warning: ](https://app.codecov.io/gh/apache/pinot/pull/14398?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| ... and [19 more](https://app.codecov.io/gh/apache/pinot/pull/14398?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | |
> :exclamation: There is a different number of reports uploaded between BASE (59551e4) and HEAD (7cf378f). Click for more details.
>
> <details><summary>HEAD has 48 uploads less than BASE</summary>
>
>| Flag | BASE (59551e4) | HEAD (7cf378f) |
>|------|------|------|
>|integration|7|0|
>|integration2|3|0|
>|temurin|12|2|
>|java-21|7|2|
>|skip-bytebuffers-true|3|1|
>|skip-bytebuffers-false|7|1|
>|unittests|5|2|
>|unittests1|2|0|
>|java-11|5|0|
>|unittests2|3|2|
>|integration1|2|0|
>|custom-integration1|2|0|
></details>
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## master #14398 +/- ##
=============================================
- Coverage 61.75% 34.05% -27.70%
- Complexity 207 759 +552
=============================================
Files 2436 2660 +224
Lines 133233 146720 +13487
Branches 20636 22432 +1796
=============================================
- Hits 82274 49970 -32304
- Misses 44911 92713 +47802
+ Partials 6048 4037 -2011
```
| [Flag](https://app.codecov.io/gh/apache/pinot/pull/14398/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [custom-integration1](https://app.codecov.io/gh/apache/pinot/pull/14398/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
| [integration](https://app.codecov.io/gh/apache/pinot/pull/14398/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
| [integration1](https://app.codecov.io/gh/apache/pinot/pull/14398/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
| [integration2](https://app.codecov.io/gh/apache/pinot/pull/14398/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
| [java-11](https://app.codecov.io/gh/apache/pinot/pull/14398/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
| [java-21](https://app.codecov.io/gh/apache/pinot/pull/14398/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `34.05% <4.88%> (-27.57%)` | :arrow_down: |
| [skip-bytebuffers-false](https://app.codecov.io/gh/apache/pinot/pull/14398/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `33.98% <4.88%> (-27.77%)` | :arrow_down: |
| [skip-bytebuffers-true](https://app.codecov.io/gh/apache/pinot/pull/14398/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `34.04% <4.88%> (+6.32%)` | :arrow_up: |
| [temurin](https://app.codecov.io/gh/apache/pinot/pull/14398/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `34.05% <4.88%> (-27.70%)` | :arrow_down: |
| [unittests](https://app.codecov.io/gh/apache/pinot/pull/14398/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `34.05% <4.88%> (-27.69%)` | :arrow_down: |
| [unittests1](https://app.codecov.io/gh/apache/pinot/pull/14398/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
| [unittests2](https://app.codecov.io/gh/apache/pinot/pull/14398/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `34.05% <4.88%> (+6.32%)` | :arrow_up: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
</details>
[:umbrella: View full report in Codecov by Sentry](https://app.codecov.io/gh/apache/pinot/pull/14398?dropdown=coverage&src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
:loudspeaker: Have feedback on the report? [Share it here](https://about.codecov.io/codecov-pr-comment-feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org
Re: [PR] Support TIMESTAMP_NTZ, DATE and TIME datatype [pinot]
Posted by "chunxiaozheng (via GitHub)" <gi...@apache.org>.
chunxiaozheng commented on code in PR #14398:
URL: https://github.com/apache/pinot/pull/14398#discussion_r1834321250
##########
pinot-common/src/main/java/org/apache/pinot/common/utils/DataSchema.java:
##########
@@ -273,11 +278,29 @@ public RelDataType toType(RelDataTypeFactory typeFactory) {
}
},
TIMESTAMP(LONG, NullValuePlaceHolder.LONG) {
+ @Override
+ public RelDataType toType(RelDataTypeFactory typeFactory) {
+ return typeFactory.createSqlType(SqlTypeName.TIMESTAMP_WITH_LOCAL_TIME_ZONE);
+ }
+ },
+ TIMESTAMP_NTZ(LONG, NullValuePlaceHolder.LONG) {
@Override
public RelDataType toType(RelDataTypeFactory typeFactory) {
return typeFactory.createSqlType(SqlTypeName.TIMESTAMP);
}
},
Review Comment:
> I guess you did this to follow the Spark terminology, but apart from my preference to following Postgres terminology I think this is breaking backward compatibility. Before this PR a Pinot TIMESTAMP was converted to Calcite TIMESTAMP and now we are converting it into a TIMESTAMP WITH LOCAL TIME ZONE.
>
> I may be wrong but I think what we should be doing here is to return that our TIMESTAMP_TZ returns a Calcite TIMESTAMP_TZ
Thanks for your review! From my understanding, the TIMESTAMP type in Calcite has no time zone, but the TIMESTAMP type in pinot is all using java.sql.Timestamp to explain, which is with the local time zone, so i made changes here.
In order to minimize modifications to the TIMESTAMP type in pinot, i referred to the data type in Spark and extended the TIMESTAMP_NTZ type.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org
Re: [PR] Support TIMESTAMP_NTZ, DATE and TIME datatype [pinot]
Posted by "chunxiaozheng (via GitHub)" <gi...@apache.org>.
chunxiaozheng commented on PR #14398:
URL: https://github.com/apache/pinot/pull/14398#issuecomment-2461170186
> Cool! It looks like the PR is not yet finished (there are tests failing due to this new type) but it looks promising! I'll try to review it soon.
Thanks! I will fix the tests today
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org
Re: [PR] Support TIMESTAMP_NTZ, DATE and TIME datatype [pinot]
Posted by "chunxiaozheng (via GitHub)" <gi...@apache.org>.
chunxiaozheng commented on code in PR #14398:
URL: https://github.com/apache/pinot/pull/14398#discussion_r1834327356
##########
pinot-common/src/main/java/org/apache/pinot/common/utils/DataSchema.java:
##########
@@ -490,12 +540,24 @@ public Object toInternal(Object value) {
return ((boolean) value) ? 1 : 0;
case TIMESTAMP:
return ((Timestamp) value).getTime();
+ case TIMESTAMP_NTZ:
+ return ((LocalDateTime) value).atZone(ZoneId.of("UTC")).toInstant().toEpochMilli();
Review Comment:
> In this specific case, this can be rewritten with (AFAIK) zero allocation with:
Thanks! But I think this will lose millisecond accuracy😂
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org
Re: [PR] Support TIMESTAMP_NTZ, DATE and TIME datatype [pinot]
Posted by "bziobrowski (via GitHub)" <gi...@apache.org>.
bziobrowski commented on code in PR #14398:
URL: https://github.com/apache/pinot/pull/14398#discussion_r1842442129
##########
pinot-spi/src/main/java/org/apache/pinot/spi/config/table/FieldConfig.java:
##########
@@ -127,7 +127,7 @@ public enum EncodingType {
// If null, there won't be any index
public enum IndexType {
- INVERTED, SORTED, TEXT, FST, H3, JSON, TIMESTAMP, VECTOR, RANGE
+ INVERTED, SORTED, TEXT, FST, H3, JSON, TIMESTAMP, VECTOR, RANGE, TIMESTAMP_NTZ, DATE, TIME
Review Comment:
Does the PR really add 3 new index types?
##########
pinot-spi/src/main/java/org/apache/pinot/spi/data/FieldSpec.java:
##########
@@ -519,6 +543,9 @@ public enum DataType {
BIG_DECIMAL(true, true),
BOOLEAN(INT, false, true),
TIMESTAMP(LONG, false, true),
Review Comment:
Is there a reason for DATE to use 8 bytes ? What granularity do you plan to use for TIME ? If it's millis then 4 bytes should be enough.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org
Re: [PR] Support TIMESTAMP_NTZ, DATE and TIME datatype [pinot]
Posted by "chunxiaozheng (via GitHub)" <gi...@apache.org>.
chunxiaozheng commented on code in PR #14398:
URL: https://github.com/apache/pinot/pull/14398#discussion_r1835283681
##########
pinot-query-planner/src/main/java/org/apache/pinot/query/type/PinotSqlTypeMappingRule.java:
##########
@@ -0,0 +1,75 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+
+package org.apache.pinot.query.type;
+
+import com.google.common.collect.ImmutableMap;
+import com.google.common.collect.ImmutableSet;
+import java.util.HashMap;
+import java.util.HashSet;
+import java.util.Map;
+import java.util.Set;
+import org.apache.calcite.sql.type.SqlTypeMappingRule;
+import org.apache.calcite.sql.type.SqlTypeName;
+
+
+/**
+ * The {@code PinotSqlTypeMappingRule} overwrites Calcite's SqlTypeMappingRule with Pinot specific logics.
+ */
+public class PinotSqlTypeMappingRule implements SqlTypeMappingRule {
+
+ private static final Set<SqlTypeName> TYPES = ImmutableSet.of(
+ SqlTypeName.TINYINT, SqlTypeName.SMALLINT, SqlTypeName.INTEGER, SqlTypeName.BIGINT);
+
+ private final Map<SqlTypeName, ImmutableSet<SqlTypeName>> _map;
+ private static PinotSqlTypeMappingRule _instance;
+
+ private PinotSqlTypeMappingRule(SqlTypeMappingRule rule) {
+ // support int or long datatype cast to Date or Time in pinot
+ Map<SqlTypeName, ImmutableSet<SqlTypeName>> map = new HashMap<>(rule.getTypeMapping());
+ if (map.containsKey(SqlTypeName.DATE)) {
+ Set<SqlTypeName> fromTypes = new HashSet<>(map.get(SqlTypeName.DATE));
+ fromTypes.addAll(TYPES);
+ map.put(SqlTypeName.DATE, ImmutableSet.copyOf(fromTypes));
+ }
+ if (map.containsKey(SqlTypeName.TIME)) {
+ Set<SqlTypeName> fromTypes = new HashSet<>(map.get(SqlTypeName.TIME));
+ fromTypes.addAll(TYPES);
+ map.put(SqlTypeName.TIME, ImmutableSet.copyOf(fromTypes));
+ }
Review Comment:
> I don't think we actually want to support these castings. Instead we should add the functions that use them. For example, in postgres there is a function that adds `date + integer`. See https://www.postgresql.org/docs/current/functions-datetime.html
I don't know if we need to support the syntax of `cast(12345 as DATE)` or `cast(12345 as TIME(3))`. If we need this syntax, we need to add a similar implementation.
Otherwise, when executing the above statement, the mapping rules in `org.apache.calcite.sql.type.SqlTypeCoercionRule` will be used, which does not support converting `Integer` type to `Date` or `Time`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org
Re: [PR] Support TIMESTAMP_NTZ, DATE and TIME datatype [pinot]
Posted by "gortiz (via GitHub)" <gi...@apache.org>.
gortiz commented on PR #14398:
URL: https://github.com/apache/pinot/pull/14398#issuecomment-2461957503
As suggested by @Jackie-Jiang, I think a design document would be great. There we can discuss the nomenclature, which from my point of view is not clear. I would like to open the discussion to use the same definitions used by Postgres (which would mean to have a TIMESTAMP and TIMESTAMP_WITH_TIME_ZONE)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org
Re: [PR] Support TIMESTAMP_NTZ, DATE and TIME datatype [pinot]
Posted by "chunxiaozheng (via GitHub)" <gi...@apache.org>.
chunxiaozheng commented on code in PR #14398:
URL: https://github.com/apache/pinot/pull/14398#discussion_r1835281970
##########
pinot-common/src/main/java/org/apache/pinot/common/utils/DataSchema.java:
##########
@@ -490,12 +540,24 @@ public Object toInternal(Object value) {
return ((boolean) value) ? 1 : 0;
case TIMESTAMP:
return ((Timestamp) value).getTime();
+ case TIMESTAMP_NTZ:
+ return ((LocalDateTime) value).atZone(ZoneId.of("UTC")).toInstant().toEpochMilli();
Review Comment:
> @gortiz I think that snippet isn't correct because code assumes offset is constant (and actually 0 while local is likely not :) ) @chunxiaozheng Please consider :
>
> ```java
> public static void main(String[] args) {
> LocalDateTime dt = LocalDateTime.of(2024, 11, 8, 12, 13, 14, 231000000);
>
> ZoneId zoneId = ZoneId.of("Europe/Warsaw");// zone should be cached
> ZoneRules rules = zoneId.getRules();
> ZoneOffset offset = rules.getOffset(dt);
>
> System.out.println("to epoch (UTC) " + dt.toEpochSecond(ZoneOffset.UTC) * 1000);
> System.out.println("to epoch " + dt.toEpochSecond(offset) * 1000);
> System.out.println("to epoch plus nanos " + dt.toEpochSecond(offset) * 1000 + dt.getNano() / 1000000);
> }
> ```
Thanks! The implementation of TIMESTAMP type without time zone, such as `TIMESTAMP` in Flink and `TIMESTAMP_NTZ` type in Spark, will parse according to UTC time to ensure that the time queried in any time zone is consistent. Therefore, for TIMESTAMP types without time zones, I believe it is need to use a constant(UTC time zone) for parsing.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org
Re: [PR] Support TIMESTAMP_NTZ, DATE and TIME datatype [pinot]
Posted by "gortiz (via GitHub)" <gi...@apache.org>.
gortiz commented on code in PR #14398:
URL: https://github.com/apache/pinot/pull/14398#discussion_r1834236954
##########
pinot-common/src/main/java/org/apache/pinot/common/utils/DataSchema.java:
##########
@@ -490,12 +540,24 @@ public Object toInternal(Object value) {
return ((boolean) value) ? 1 : 0;
case TIMESTAMP:
return ((Timestamp) value).getTime();
+ case TIMESTAMP_NTZ:
+ return ((LocalDateTime) value).atZone(ZoneId.of("UTC")).toInstant().toEpochMilli();
Review Comment:
In this specific case, this can be rewritten with (AFAIK) zero allocation with:
```suggestion
return ((LocalDateTime) value).toEpochSecond(ZoneOffset.UTC) * 1000;
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org
Re: [PR] Support TIMESTAMP_NTZ, DATE and TIME datatype [pinot]
Posted by "gortiz (via GitHub)" <gi...@apache.org>.
gortiz commented on code in PR #14398:
URL: https://github.com/apache/pinot/pull/14398#discussion_r1832509438
##########
pinot-common/src/main/java/org/apache/pinot/common/utils/DataSchema.java:
##########
@@ -490,12 +540,24 @@ public Object toInternal(Object value) {
return ((boolean) value) ? 1 : 0;
case TIMESTAMP:
return ((Timestamp) value).getTime();
+ case TIMESTAMP_NTZ:
+ return ((LocalDateTime) value).atZone(ZoneId.of("UTC")).toInstant().toEpochMilli();
Review Comment:
@bziobrowski IIRC you knew a way to do this without allocating so many objects. Am I right?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org
Re: [PR] Support TIMESTAMP_NTZ, DATE and TIME datatype [pinot]
Posted by "bziobrowski (via GitHub)" <gi...@apache.org>.
bziobrowski commented on code in PR #14398:
URL: https://github.com/apache/pinot/pull/14398#discussion_r1834110082
##########
pinot-common/src/main/java/org/apache/pinot/common/utils/DataSchema.java:
##########
@@ -490,12 +540,24 @@ public Object toInternal(Object value) {
return ((boolean) value) ? 1 : 0;
case TIMESTAMP:
return ((Timestamp) value).getTime();
+ case TIMESTAMP_NTZ:
+ return ((LocalDateTime) value).atZone(ZoneId.of("UTC")).toInstant().toEpochMilli();
Review Comment:
That time I used joda.time's MutableDateTime, not java classes.
I agree that this line creates way too many temporary objects and should be rewritten.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org
Re: [PR] Support TIMESTAMP_NTZ, DATE and TIME datatype [pinot]
Posted by "gortiz (via GitHub)" <gi...@apache.org>.
gortiz commented on code in PR #14398:
URL: https://github.com/apache/pinot/pull/14398#discussion_r1834450392
##########
pinot-query-planner/src/main/java/org/apache/pinot/query/type/PinotSqlTypeMappingRule.java:
##########
@@ -0,0 +1,75 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+
+package org.apache.pinot.query.type;
+
+import com.google.common.collect.ImmutableMap;
+import com.google.common.collect.ImmutableSet;
+import java.util.HashMap;
+import java.util.HashSet;
+import java.util.Map;
+import java.util.Set;
+import org.apache.calcite.sql.type.SqlTypeMappingRule;
+import org.apache.calcite.sql.type.SqlTypeName;
+
+
+/**
+ * The {@code PinotSqlTypeMappingRule} overwrites Calcite's SqlTypeMappingRule with Pinot specific logics.
+ */
+public class PinotSqlTypeMappingRule implements SqlTypeMappingRule {
+
+ private static final Set<SqlTypeName> TYPES = ImmutableSet.of(
+ SqlTypeName.TINYINT, SqlTypeName.SMALLINT, SqlTypeName.INTEGER, SqlTypeName.BIGINT);
+
+ private final Map<SqlTypeName, ImmutableSet<SqlTypeName>> _map;
+ private static PinotSqlTypeMappingRule _instance;
+
+ private PinotSqlTypeMappingRule(SqlTypeMappingRule rule) {
+ // support int or long datatype cast to Date or Time in pinot
+ Map<SqlTypeName, ImmutableSet<SqlTypeName>> map = new HashMap<>(rule.getTypeMapping());
+ if (map.containsKey(SqlTypeName.DATE)) {
+ Set<SqlTypeName> fromTypes = new HashSet<>(map.get(SqlTypeName.DATE));
+ fromTypes.addAll(TYPES);
+ map.put(SqlTypeName.DATE, ImmutableSet.copyOf(fromTypes));
+ }
+ if (map.containsKey(SqlTypeName.TIME)) {
+ Set<SqlTypeName> fromTypes = new HashSet<>(map.get(SqlTypeName.TIME));
+ fromTypes.addAll(TYPES);
+ map.put(SqlTypeName.TIME, ImmutableSet.copyOf(fromTypes));
+ }
Review Comment:
I don't think we actually want to support these castings. Instead we should add the functions that use them. For example, in postgres there is a function that adds `date + integer`. See https://www.postgresql.org/docs/current/functions-datetime.html
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org
Re: [PR] Support TIMESTAMP_NTZ, DATE and TIME datatype [pinot]
Posted by "chunxiaozheng (via GitHub)" <gi...@apache.org>.
chunxiaozheng commented on PR #14398:
URL: https://github.com/apache/pinot/pull/14398#issuecomment-2466062102
> It looks like at runtime we sometimes use longs to implement timestamps, date and time, but some other times we use LocalDate and LocalTime. That seems a bit odd. I don't know if we are doing the same with Timestamp right now in master, we would need to study if this is what we want
Thanks! In fact, I added these new data types based on the implementation of `TIMESTAMP` data type in Pinot.🤔
From my understanding, these time related type use the `long`type in storage, and when queried through DQL, they will be converted to the corresponding Java type, such as `java.sql.Timestamp`, `java.time.LocalDateTime`, `java.time.LocalDate` and `java.time.LocalTime`. Therefore, this will include many conversions between these Java types and long types
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org
Re: [PR] Support TIMESTAMP_NTZ, DATE and TIME datatype [pinot]
Posted by "Jackie-Jiang (via GitHub)" <gi...@apache.org>.
Jackie-Jiang commented on PR #14398:
URL: https://github.com/apache/pinot/pull/14398#issuecomment-2460627099
Related to #13004, #9575
Thanks for working on this!
A high level design covering the following points can help explain the code and guide the review:
1. What is the storage type and format for each of them
2. What is the supported input formats for each of them
3. What is the output format for each of them
4. What is the expected behavior when comparing different types, e.g. comparing `TIMESTAMP` with `TIMESTAMP_NTZ`, `DATE` with numeric type etc. We should try to match PostgreSQL behavior.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org
Re: [PR] Support TIMESTAMP_NTZ, DATE and TIME datatype [pinot]
Posted by "chunxiaozheng (via GitHub)" <gi...@apache.org>.
chunxiaozheng commented on PR #14398:
URL: https://github.com/apache/pinot/pull/14398#issuecomment-2464642495
> Related to #13004, #9575
>
> Thanks for working on this! A high level design covering the following points can help explain the code and guide the review:
>
> 1. What is the storage type and format for each of them
> 2. What is the supported input formats for each of them
> 3. What is the output format for each of them
> 4. What is the expected behavior when comparing different types, e.g. comparing `TIMESTAMP` with `TIMESTAMP_NTZ`, `DATE` with numeric type etc. We should try to match PostgreSQL behavior.
Thanks! I will write an document for this PR, and then we can discuss it together.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org
Re: [PR] Support TIMESTAMP_NTZ, DATE and TIME datatype [pinot]
Posted by "bziobrowski (via GitHub)" <gi...@apache.org>.
bziobrowski commented on code in PR #14398:
URL: https://github.com/apache/pinot/pull/14398#discussion_r1834634133
##########
pinot-common/src/main/java/org/apache/pinot/common/utils/DataSchema.java:
##########
@@ -490,12 +540,24 @@ public Object toInternal(Object value) {
return ((boolean) value) ? 1 : 0;
case TIMESTAMP:
return ((Timestamp) value).getTime();
+ case TIMESTAMP_NTZ:
+ return ((LocalDateTime) value).atZone(ZoneId.of("UTC")).toInstant().toEpochMilli();
Review Comment:
@gortiz I think that snippet isn't correct because code assumes offset is constant (and actually 0 while local is likely not :) )
@chunxiaozheng Please consider :
```java
public static void main(String[] args) {
LocalDateTime dt = LocalDateTime.of(2024, 11, 8, 12, 13, 14, 231000000);
ZoneId zoneId = ZoneId.of("Europe/Warsaw");// zone should be cached
ZoneRules rules = zoneId.getRules();
ZoneOffset offset = rules.getOffset(dt);
System.out.println("to epoch (UTC) " + dt.toEpochSecond(ZoneOffset.UTC) * 1000);
System.out.println("to epoch " + dt.toEpochSecond(offset) * 1000);
System.out.println("to epoch plus nanos " + dt.toEpochSecond(offset) * 1000 + dt.getNano() / 1000000);
}
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org
Re: [PR] Support TIMESTAMP_NTZ, DATE and TIME datatype [pinot]
Posted by "gortiz (via GitHub)" <gi...@apache.org>.
gortiz commented on PR #14398:
URL: https://github.com/apache/pinot/pull/14398#issuecomment-2460082423
Cool! It looks like the PR is not yet finished (there are tests failing due to this new type) but it looks promising! I'll try to review it soon.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org
Re: [PR] Support TIMESTAMP_NTZ, DATE and TIME datatype [pinot]
Posted by "gortiz (via GitHub)" <gi...@apache.org>.
gortiz commented on code in PR #14398:
URL: https://github.com/apache/pinot/pull/14398#discussion_r1832508244
##########
pinot-common/src/main/java/org/apache/pinot/common/utils/DataSchema.java:
##########
@@ -273,11 +278,29 @@ public RelDataType toType(RelDataTypeFactory typeFactory) {
}
},
TIMESTAMP(LONG, NullValuePlaceHolder.LONG) {
+ @Override
+ public RelDataType toType(RelDataTypeFactory typeFactory) {
+ return typeFactory.createSqlType(SqlTypeName.TIMESTAMP_WITH_LOCAL_TIME_ZONE);
+ }
+ },
+ TIMESTAMP_NTZ(LONG, NullValuePlaceHolder.LONG) {
@Override
public RelDataType toType(RelDataTypeFactory typeFactory) {
return typeFactory.createSqlType(SqlTypeName.TIMESTAMP);
}
},
Review Comment:
I guess you did this to follow the Spark terminology, but apart from my preference to following Postgres terminology I think this is breaking backward compatibility. Before this PR a Pinot TIMESTAMP was converted to Calcite TIMESTAMP and now we are converting it into a TIMESTAMP WITH LOCAL TIME ZONE.
I may be wrong but I think what we should be doing here is to return that our TIMESTAMP_TZ returns a Calcite TIMESTAMP_TZ
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org