[GitHub] [iceberg] RussellSpitzer commented on a diff in pull request #6818: Fix: add_files data loss - old partitions get lost when new partition is added

["RussellSpitzer (via GitHub)" <gi...@apache.org>]

RussellSpitzer commented on code in PR #6818:
URL: https://github.com/apache/iceberg/pull/6818#discussion_r1105074612


##########
spark/v3.3/spark-extensions/src/test/java/org/apache/iceberg/spark/extensions/TestAddFilesProcedure.java:
##########
@@ -394,6 +397,29 @@ public void addPartitionToPartitioned() {
         sql("SELECT id, name, dept, subdept FROM %s ORDER BY id", tableName));
   }
 
+  @Test

Review Comment:
   We should add a test where addfiles is called twice



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org