You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2020/02/24 01:04:50 UTC
[GitHub] [spark] karth295 commented on a change in pull request #27636:
[WIP][SPARK-30873][CORE][YARN]Handling Node Decommissioning for Yarn
cluster manger in Spark
karth295 commented on a change in pull request #27636: [WIP][SPARK-30873][CORE][YARN]Handling Node Decommissioning for Yarn cluster manger in Spark
URL: https://github.com/apache/spark/pull/27636#discussion_r383056987
##########
File path: core/src/main/scala/org/apache/spark/internal/config/package.scala
##########
@@ -1542,4 +1542,46 @@ package object config {
.bytesConf(ByteUnit.BYTE)
.createOptional
+ private[spark] val GRACEFUL_DECOMMISSION_ENABLE =
+ ConfigBuilder("spark.graceful.decommission.enable")
+ .doc("Whether to enable the node graceful decommissioning handling")
+ .booleanConf
+ .createWithDefault(false)
+
+ private[spark] val GRACEFUL_DECOMMISSION_FETCHFAILED_IGNORE_THRESHOLD =
+ ConfigBuilder("spark.graceful.decommission.fetchfailed.ignore.threshold")
+ .doc("Threshold of number of times fetchfailed ignored due to node decommission")
+ .intConf
+ .createWithDefault(8)
+
+ private[spark] val GRACEFUL_DECOMMISSION_EXECUTOR_LEASETIME_PCT =
+ ConfigBuilder("spark.graceful.decommission.executor.leasetimePct")
+ .doc("Percentage of time to expiry after which executors are killed " +
+ "(if enabled) on the node. Value ranges between (0-100)")
+ .intConf
+ .checkValue(v => v >= 0 && v < 100, "The percentage should be positive.")
+ .createWithDefault(50) // Pulled out of thin air.
+
+ private[spark] val GRACEFUL_DECOMMISSION_SHUFFLEDATA_LEASETIME_PCT =
+ ConfigBuilder("spark.graceful.decommission.shuffedata.leasetimePct")
+ .doc("Percentage of time to expiry after which shuffle data " +
+ "cleaned up (if enabled) on the node. Value ranges between (0-100)")
+ .intConf
+ .checkValue(v => v >= 0 && v < 100, "The percentage should be positive.")
+ .createWithDefault(90) // Pulled out of thin air.
+
+ private[spark] val GRACEFUL_DECOMMISSION_MIN_TERMINATION_TIME_IN_SEC =
+ ConfigBuilder("spark.graceful.decommission.min.termination.time")
+ .doc("Minimum time to termination below which node decommissioning is performed immediately")
+ .timeConf(TimeUnit.SECONDS)
+ .createWithDefaultString("60s")
+
+ private[spark] val ABOUT_TO_BE_LOST_NODE_INTERVAL =
+ ConfigBuilder("spark.abouttobelost.node.interval")
Review comment:
As I mentioned in the design doc, you could consider naming this `spark.graceful.decommission.timeout` or at least something under `spark.graceful` to keep these properties grouped together.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org