You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@shardingsphere.apache.org by GitBox <gi...@apache.org> on 2022/11/29 04:57:49 UTC
[GitHub] [shardingsphere] linghengqian opened a new pull request, #22495: Add support for `java.sql.Date` for IntervalShardingAlgorithm
linghengqian opened a new pull request, #22495:
URL: https://github.com/apache/shardingsphere/pull/22495
For https://github.com/apache/shardingsphere/issues/21347#issuecomment-1330025024 .
Changes proposed in this pull request:
- Add support for `java.sql.Date` for IntervalShardingAlgorithm
- Add the corresponding unit test.
- Refer to #20255 .
---
Before committing this PR, I'm sure that I have checked the following options:
- [ ] My code follows the [code of conduct](https://shardingsphere.apache.org/community/en/involved/conduct/code/) of this project.
- [ ] I have self-reviewed the commit code.
- [ ] I have (or in comment I request) added corresponding labels for the pull request.
- [ ] I have passed maven check locally : `./mvnw clean install -B -T1C -Dmaven.javadoc.skip -Dmaven.jacoco.skip -e`.
- [ ] I have made corresponding changes to the documentation.
- [ ] I have added corresponding unit tests for my changes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] codecov-commenter commented on pull request #22495: Add support for `java.sql.Date` in IntervalShardingAlgorithm
Posted by GitBox <gi...@apache.org>.
codecov-commenter commented on PR #22495:
URL: https://github.com/apache/shardingsphere/pull/22495#issuecomment-1330106708
# [Codecov](https://codecov.io/gh/apache/shardingsphere/pull/22495?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#22495](https://codecov.io/gh/apache/shardingsphere/pull/22495?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (e9aed54) into [master](https://codecov.io/gh/apache/shardingsphere/commit/07300fdd7856ac91548851cd739e8fc8dedfc153?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (07300fd) will **decrease** coverage by `0.01%`.
> The diff coverage is `50.00%`.
```diff
@@ Coverage Diff @@
## master #22495 +/- ##
============================================
- Coverage 50.99% 50.98% -0.02%
Complexity 2514 2514
============================================
Files 4185 4185
Lines 58232 58241 +9
Branches 9898 9903 +5
============================================
- Hits 29695 29693 -2
- Misses 26011 26018 +7
- Partials 2526 2530 +4
```
| [Impacted Files](https://codecov.io/gh/apache/shardingsphere/pull/22495?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...hority/yaml/config/YamlAuthorityConfiguration.java](https://codecov.io/gh/apache/shardingsphere/pull/22495/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-a2VybmVsL2F1dGhvcml0eS9jb3JlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGFyZGluZ3NwaGVyZS9hdXRob3JpdHkveWFtbC9jb25maWcvWWFtbEF1dGhvcml0eUNvbmZpZ3VyYXRpb24uamF2YQ==) | `0.00% <ø> (ø)` | |
| [...aml/config/YamlSQLTranslatorRuleConfiguration.java](https://codecov.io/gh/apache/shardingsphere/pull/22495/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-a2VybmVsL3NxbC10cmFuc2xhdG9yL2NvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoYXJkaW5nc3BoZXJlL3NxbHRyYW5zbGF0b3IveWFtbC9jb25maWcvWWFtbFNRTFRyYW5zbGF0b3JSdWxlQ29uZmlndXJhdGlvbi5qYXZh) | `0.00% <0.00%> (ø)` | |
| [...kend/config/yaml/YamlProxyServerConfiguration.java](https://codecov.io/gh/apache/shardingsphere/pull/22495/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cHJveHkvYmFja2VuZC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvcHJveHkvYmFja2VuZC9jb25maWcveWFtbC9ZYW1sUHJveHlTZXJ2ZXJDb25maWd1cmF0aW9uLmphdmE=) | `55.55% <ø> (ø)` | |
| [...proxy/backend/config/ProxyConfigurationLoader.java](https://codecov.io/gh/apache/shardingsphere/pull/22495/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cHJveHkvYmFja2VuZC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvcHJveHkvYmFja2VuZC9jb25maWcvUHJveHlDb25maWd1cmF0aW9uTG9hZGVyLmphdmE=) | `60.00% <30.76%> (-12.10%)` | :arrow_down: |
| [...m/sharding/datetime/IntervalShardingAlgorithm.java](https://codecov.io/gh/apache/shardingsphere/pull/22495/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZmVhdHVyZXMvc2hhcmRpbmcvY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvc2hhcmRpbmcvYWxnb3JpdGhtL3NoYXJkaW5nL2RhdGV0aW1lL0ludGVydmFsU2hhcmRpbmdBbGdvcml0aG0uamF2YQ==) | `79.26% <100.00%> (+0.25%)` | :arrow_up: |
| [...ty/yaml/config/YamlAuthorityRuleConfiguration.java](https://codecov.io/gh/apache/shardingsphere/pull/22495/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-a2VybmVsL2F1dGhvcml0eS9jb3JlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGFyZGluZ3NwaGVyZS9hdXRob3JpdHkveWFtbC9jb25maWcvWWFtbEF1dGhvcml0eVJ1bGVDb25maWd1cmF0aW9uLmphdmE=) | `66.66% <100.00%> (ø)` | |
| [...er/yaml/config/YamlSQLParserRuleConfiguration.java](https://codecov.io/gh/apache/shardingsphere/pull/22495/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-a2VybmVsL3BhcnNlci9jb3JlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGFyZGluZ3NwaGVyZS9wYXJzZXIveWFtbC9jb25maWcvWWFtbFNRTFBhcnNlclJ1bGVDb25maWd1cmF0aW9uLmphdmE=) | `50.00% <100.00%> (ø)` | |
| [...ffic/yaml/config/YamlTrafficRuleConfiguration.java](https://codecov.io/gh/apache/shardingsphere/pull/22495/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-a2VybmVsL3RyYWZmaWMvY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvdHJhZmZpYy95YW1sL2NvbmZpZy9ZYW1sVHJhZmZpY1J1bGVDb25maWd1cmF0aW9uLmphdmE=) | `80.00% <100.00%> (ø)` | |
| [.../yaml/config/YamlTransactionRuleConfiguration.java](https://codecov.io/gh/apache/shardingsphere/pull/22495/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-a2VybmVsL3RyYW5zYWN0aW9uL2NvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoYXJkaW5nc3BoZXJlL3RyYW5zYWN0aW9uL3lhbWwvY29uZmlnL1lhbWxUcmFuc2FjdGlvblJ1bGVDb25maWd1cmF0aW9uLmphdmE=) | `50.00% <100.00%> (ø)` | |
| [...handler/distsql/ral/hint/enums/HintSourceType.java](https://codecov.io/gh/apache/shardingsphere/pull/22495/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cHJveHkvYmFja2VuZC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvcHJveHkvYmFja2VuZC9oYW5kbGVyL2Rpc3RzcWwvcmFsL2hpbnQvZW51bXMvSGludFNvdXJjZVR5cGUuamF2YQ==) | `0.00% <0.00%> (-42.86%)` | :arrow_down: |
:mega: We’re building smart automated test selection to slash your CI/CD build times. [Learn more](https://about.codecov.io/iterative-testing/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] terrymanu merged pull request #22495: Add support for `java.sql.Date` in IntervalShardingAlgorithm
Posted by GitBox <gi...@apache.org>.
terrymanu merged PR #22495:
URL: https://github.com/apache/shardingsphere/pull/22495
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org