You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@orc.apache.org by "ffacs (via GitHub)" <gi...@apache.org> on 2023/03/21 16:24:51 UTC

[GitHub] [orc] ffacs opened a new issue, #1448: [C++] Behavior mismatch with option useTightNumericVector

ffacs opened a new issue, #1448:
URL: https://github.com/apache/orc/issues/1448

   With the option useTightNumericVector, the typeImpl would return a byteVectorBatch
   https://github.com/apache/orc/blob/5ed1bbe7b63d288b0924f8adcdae4423f4a5f420/c%2B%2B/src/TypeImpl.cc#L285-L294
   
   however, BooleanColumnReader and BooleanColumnWriter only accept LongVectorBatch
   
   https://github.com/apache/orc/blob/5ed1bbe7b63d288b0924f8adcdae4423f4a5f420/c%2B%2B/src/ColumnWriter.cc#L670-L675
   
   https://github.com/apache/orc/blob/5ed1bbe7b63d288b0924f8adcdae4423f4a5f420/c%2B%2B/src/ColumnReader.cc#L169-L177


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@orc.apache.org.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [orc] dongjoon-hyun commented on issue #1448: [C++] Behavior mismatch with option useTightNumericVector

Posted by "dongjoon-hyun (via GitHub)" <gi...@apache.org>.
dongjoon-hyun commented on issue #1448:
URL: https://github.com/apache/orc/issues/1448#issuecomment-1479955215

   Thank you for reporting. Are you interesting in making a PR, @ffacs ?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@orc.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [orc] wgtmac commented on issue #1448: [C++] Behavior mismatch with option useTightNumericVector

Posted by "wgtmac (via GitHub)" <gi...@apache.org>.
wgtmac commented on issue #1448:
URL: https://github.com/apache/orc/issues/1448#issuecomment-1515582780

   I close this issue as the PR has been merged. Feel free to reopen if there is any remaining work.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@orc.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [orc] ffacs commented on issue #1448: [C++] Behavior mismatch with option useTightNumericVector

Posted by "ffacs (via GitHub)" <gi...@apache.org>.
ffacs commented on issue #1448:
URL: https://github.com/apache/orc/issues/1448#issuecomment-1480501452

   > Thank you for reporting. Are you interesting in making a PR, @ffacs ?
   
   I would make a PR later.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@orc.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [orc] wgtmac closed issue #1448: [C++] Behavior mismatch with option useTightNumericVector

Posted by "wgtmac (via GitHub)" <gi...@apache.org>.
wgtmac closed issue #1448: [C++] Behavior mismatch with option useTightNumericVector
URL: https://github.com/apache/orc/issues/1448


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@orc.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org