[jira] [Commented] (MAPREDUCE-2068) TaskInProgress contains duplicate idWithinJob() / getIdWithinJob() accessors

["Hadoop QA (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/MAPREDUCE-2068?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13055189#comment-13055189 ] 

Hadoop QA commented on MAPREDUCE-2068:
--------------------------------------

-1 overall.  Here are the results of testing the latest attachment 
  http://issues.apache.org/jira/secure/attachment/12483874/MAPREDUCE-2068.r1.diff
  against trunk revision 1139400.

    +1 @author.  The patch does not contain any @author tags.

    -1 tests included.  The patch doesn't appear to include any new or modified tests.
                        Please justify why no new tests are needed for this patch.
                        Also please list what manual steps were performed to verify this patch.

    +1 javadoc.  The javadoc tool did not generate any warning messages.

    -1 javac.  The patch appears to cause tar ant target to fail.

    -1 findbugs.  The patch appears to cause Findbugs (version 1.3.9) to fail.

    +1 release audit.  The applied patch does not increase the total number of release audit warnings.

    -1 core tests.  The patch failed these core unit tests:


    -1 contrib tests.  The patch failed contrib unit tests.

    -1 system test framework.  The patch failed system test framework compile.

Test results: https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/424//testReport/
Console output: https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/424//console

This message is automatically generated.

> TaskInProgress contains duplicate idWithinJob() / getIdWithinJob() accessors
> ----------------------------------------------------------------------------
>
>                 Key: MAPREDUCE-2068
>                 URL: https://issues.apache.org/jira/browse/MAPREDUCE-2068
>             Project: Hadoop Map/Reduce
>          Issue Type: Bug
>          Components: task
>    Affects Versions: 0.22.0
>            Reporter: Greg Roelofs
>            Assignee: Harsh J
>            Priority: Minor
>             Fix For: 0.23.0
>
>         Attachments: MAPREDUCE-2068.r1.diff
>
>
> Both are public, both "return partition;", and neither is currently deprecated.
> Main user seems to be JobInProgress, and it mostly uses the "get" flavor, but it also uses the other one in two places.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira