You are viewing a plain text version of this content. The canonical link for it is here.

Posted to reviews@mesos.apache.org by Vinod Kone <vi...@gmail.com> on 2015/11/02 20:31:48 UTC

Re: Review Request 39791: Updated createStatusUpdate() to unset StatusUpdate.uuid instead of setting it to an empty string.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39791/
-----------------------------------------------------------

(Updated Nov. 2, 2015, 7:31 p.m.)


Review request for mesos, Anand Mazumdar and Ben Mahler.


Changes
-------

adjusted jaggedness of the comment. NNFR.


Repository: mesos


Description
-------

As the deleted comment says, we were setting it to emtpy because the 'uuid' was a required field until 0.22.x. Since we are at 0.26 now, it should be safe to just unset it.


Diffs (updated)
-----

  src/common/protobuf_utils.cpp 1e795dcc90b2225ad7b0a124dbdcdabdc9d2e6aa 
  src/messages/messages.proto 9a1564ff38fa1b984e92cb0abfde2108385f9e2a 

Diff: https://reviews.apache.org/r/39791/diff/


Testing
-------

make check


Thanks,

Vinod Kone