You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by JihongMA <gi...@git.apache.org> on 2015/11/13 23:00:39 UTC
[GitHub] spark pull request: Spark 11720
GitHub user JihongMA opened a pull request:
https://github.com/apache/spark/pull/9705
Spark 11720
return Double.NaN for mean/average when count == 0 for all numeric types that is converted to Double, Decimal type continue to return null.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/JihongMA/spark-1 SPARK-11720
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/spark/pull/9705.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #9705
----
commit ab5f57da364e9e0b5db4b004e1fb1778726b47c6
Author: JihongMa <li...@gmail.com>
Date: 2015-11-13T04:02:45Z
rebase with upstream
commit 95af5c81a42d15bb307cf67ecf6e61ce2875f936
Author: JihongMa <li...@gmail.com>
Date: 2015-11-13T04:04:38Z
rebase with upstream
commit a42f736aaf9b3dd24b7fa9f14276e491b93b053b
Author: JihongMa <li...@gmail.com>
Date: 2015-11-13T21:55:58Z
handle NaN for avg/mean
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [SPARK-11720] [SQL][ML] Return Double.NaN inst...
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/9705#issuecomment-156641711
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [SPARK-11720] [SQL][ML] Return Double.NaN inst...
Posted by JihongMA <gi...@git.apache.org>.
Github user JihongMA commented on the pull request:
https://github.com/apache/spark/pull/9705#issuecomment-156623775
Jenkins, test this please.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [SPARK-11720] [SQL][ML] Return Double.NaN inst...
Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/9705#issuecomment-156624138
**[Test build #45920 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/45920/consoleFull)** for PR 9705 at commit [`a42f736`](https://github.com/apache/spark/commit/a42f736aaf9b3dd24b7fa9f14276e491b93b053b).
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [SPARK-11720] [SQL][ML] Return Double.NaN inst...
Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/9705#issuecomment-156580366
**[Test build #45898 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/45898/consoleFull)** for PR 9705 at commit [`a42f736`](https://github.com/apache/spark/commit/a42f736aaf9b3dd24b7fa9f14276e491b93b053b).
* This patch **fails Spark unit tests**.
* This patch merges cleanly.
* This patch adds no public classes.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [SPARK-11720] [SQL][ML] Return Double.NaN inst...
Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/9705#issuecomment-156641501
**[Test build #45920 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/45920/consoleFull)** for PR 9705 at commit [`a42f736`](https://github.com/apache/spark/commit/a42f736aaf9b3dd24b7fa9f14276e491b93b053b).
* This patch passes all tests.
* This patch merges cleanly.
* This patch adds no public classes.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [SPARK-11720] [SQL][ML] Return Double.NaN inst...
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/9705#issuecomment-156641712
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/45920/
Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [SPARK-11720] [SQL][ML] Return Double.NaN inst...
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/9705#issuecomment-156580419
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/45898/
Test FAILed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: Spark 11720
Posted by vanzin <gi...@git.apache.org>.
Github user vanzin commented on the pull request:
https://github.com/apache/spark/pull/9705#issuecomment-156571766
Could you write a PR title that follows the convention used by Spark?
https://cwiki.apache.org/confluence/display/SPARK/Contributing+to+Spark#ContributingtoSpark-PullRequest
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [SPARK-11720] [SQL][ML] Return Double.NaN inst...
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/9705#issuecomment-156580418
Merged build finished. Test FAILed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: SPARK-11720 Return Double.NaN instead of null ...
Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/9705#issuecomment-156571954
**[Test build #45898 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/45898/consoleFull)** for PR 9705 at commit [`a42f736`](https://github.com/apache/spark/commit/a42f736aaf9b3dd24b7fa9f14276e491b93b053b).
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org