You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@shindig.apache.org by "Lane LiaBraaten (JIRA)" <ji...@apache.org> on 2008/01/10 21:18:33 UTC
[jira] Created: (SHINDIG-11) Replace references to
"http://www.google.com/ig/ifpc.js" with local copy in
javascript/container/README and sample1.html
Replace references to "http://www.google.com/ig/ifpc.js" with local copy in javascript/container/README and sample1.html
------------------------------------------------------------------------------------------------------------------------
Key: SHINDIG-11
URL: https://issues.apache.org/jira/browse/SHINDIG-11
Project: Shindig
Issue Type: Bug
Reporter: Lane LiaBraaten
Priority: Minor
In the javascript/container directory, the README and sample1.html files reference a copy of ifpc.js hosted on www.google.com that is causing errors. The other samples use a local copy of ifpc.js that seems to work fine.
When I use the copy if ifpc.js hosted on www.google.com I get the following errors when loading javascript/container/sample1.html
=====
gadgets.IFPC_ has no properties
[Break on this error] gadgets.IFPC_.registerService('resize_iframe', this.setHeight);
gadgets.js (line 226)
gadgets.container has no properties
[Break on this error] var gadget0 = gadgets.container.createGadget({specUrl: specUrl0});
sample1.html (line 18)
=====
There is also a reference to the ifpc.js file on www.google.com in the ifpc_relay.html file, but I'm not sure if it should be replaced or not.
Here's a patch to update the references to use the local copy:
Index: javascript/container/sample1.html
===================================================================
--- javascript/container/sample1.html (revision 610897)
+++ javascript/container/sample1.html (working copy)
@@ -5,7 +5,7 @@
<!-- default container look and feel -->
<link rel="stylesheet" href="gadgets.css">
<script type="text/javascript" src="json.js"></script>
-<script type="text/javascript" src="http://www.google.com/ig/ifpc.js"></script>
+<script type="text/javascript" src="ifpc.js"></script>
<script type="text/javascript" src="cookies.js"></script>
<script type="text/javascript" src="gadgets.js"></script>
<script type="text/javascript">
Index: javascript/README
===================================================================
--- javascript/README (revision 610897)
+++ javascript/README (working copy)
@@ -18,7 +18,7 @@
A) Create an HTML file including the following <head> boilerplate:
<script type="text/javascript" src="json.js"></script>
- <script type="text/javascript" src="http://www.google.com/ig/ifpc.js"></script>
+ <script type="text/javascript" src="ifpc.js"></script>
<script type="text/javascript" src="cookies.js"></script>
<script type="text/javascript" src="gadgets.js"></script>
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Closed: (SHINDIG-11) Replace references to
"http://www.google.com/ig/ifpc.js" with local copy in
javascript/container/README and sample1.html
Posted by "Lane LiaBraaten (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SHINDIG-11?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Lane LiaBraaten closed SHINDIG-11.
----------------------------------
Resolution: Fixed
This has been fixed. Thanks! -Lane
> Replace references to "http://www.google.com/ig/ifpc.js" with local copy in javascript/container/README and sample1.html
> ------------------------------------------------------------------------------------------------------------------------
>
> Key: SHINDIG-11
> URL: https://issues.apache.org/jira/browse/SHINDIG-11
> Project: Shindig
> Issue Type: Bug
> Reporter: Lane LiaBraaten
> Priority: Minor
>
> In the javascript/container directory, the README and sample1.html files reference a copy of ifpc.js hosted on www.google.com that is causing errors. The other samples use a local copy of ifpc.js that seems to work fine.
> When I use the copy if ifpc.js hosted on www.google.com I get the following errors when loading javascript/container/sample1.html
> =====
> gadgets.IFPC_ has no properties
> [Break on this error] gadgets.IFPC_.registerService('resize_iframe', this.setHeight);
> gadgets.js (line 226)
> gadgets.container has no properties
> [Break on this error] var gadget0 = gadgets.container.createGadget({specUrl: specUrl0});
> sample1.html (line 18)
> =====
> There is also a reference to the ifpc.js file on www.google.com in the ifpc_relay.html file, but I'm not sure if it should be replaced or not.
> Here's a patch to update the references to use the local copy:
> Index: javascript/container/sample1.html
> ===================================================================
> --- javascript/container/sample1.html (revision 610897)
> +++ javascript/container/sample1.html (working copy)
> @@ -5,7 +5,7 @@
> <!-- default container look and feel -->
> <link rel="stylesheet" href="gadgets.css">
> <script type="text/javascript" src="json.js"></script>
> -<script type="text/javascript" src="http://www.google.com/ig/ifpc.js"></script>
> +<script type="text/javascript" src="ifpc.js"></script>
> <script type="text/javascript" src="cookies.js"></script>
> <script type="text/javascript" src="gadgets.js"></script>
> <script type="text/javascript">
> Index: javascript/README
> ===================================================================
> --- javascript/README (revision 610897)
> +++ javascript/README (working copy)
> @@ -18,7 +18,7 @@
> A) Create an HTML file including the following <head> boilerplate:
> <script type="text/javascript" src="json.js"></script>
> - <script type="text/javascript" src="http://www.google.com/ig/ifpc.js"></script>
> + <script type="text/javascript" src="ifpc.js"></script>
> <script type="text/javascript" src="cookies.js"></script>
> <script type="text/javascript" src="gadgets.js"></script>
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.