You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@juddi.apache.org by "Tom Cunningham (JIRA)" <ju...@ws.apache.org> on 2010/02/11 23:52:27 UTC
[jira] Created: (JUDDI-361) Bundle packaging ignoring the JAR
plugin excludes
Bundle packaging ignoring the JAR plugin excludes
-------------------------------------------------
Key: JUDDI-361
URL: https://issues.apache.org/jira/browse/JUDDI-361
Project: jUDDI
Issue Type: Bug
Components: core
Affects Versions: 3.0.2
Reporter: Tom Cunningham
Assignee: Tom Cunningham
Fix For: 3.0.2
The bundle plugin seems to be causing the JAR excludes not to fire. Adding a <goal>jar</goal> to the executions seems to fix.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Closed: (JUDDI-361) Bundle packaging ignoring the JAR plugin
excludes
Posted by "Tom Cunningham (JIRA)" <ju...@ws.apache.org>.
[ https://issues.apache.org/jira/browse/JUDDI-361?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Tom Cunningham closed JUDDI-361.
--------------------------------
> Bundle packaging ignoring the JAR plugin excludes
> -------------------------------------------------
>
> Key: JUDDI-361
> URL: https://issues.apache.org/jira/browse/JUDDI-361
> Project: jUDDI
> Issue Type: Bug
> Components: core
> Affects Versions: 3.0.2
> Reporter: Tom Cunningham
> Assignee: Tom Cunningham
> Fix For: 3.0.2
>
>
> The bundle plugin seems to be causing the JAR excludes not to fire. Adding a <goal>jar</goal> to the executions seems to fix.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Resolved: (JUDDI-361) Bundle packaging ignoring the JAR
plugin excludes
Posted by "Tom Cunningham (JIRA)" <ju...@ws.apache.org>.
[ https://issues.apache.org/jira/browse/JUDDI-361?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Tom Cunningham resolved JUDDI-361.
----------------------------------
Resolution: Fixed
Removed the executions and added a bundle configuration per David's patch. Also moved orm.xml and logged JUDDI-362 for some addiitonal testing of that change. Logged JUDDI-363 for the hibernate/openjpa persistence.xml changes which given our past problems with testing, aren't as easy as they seem.
Wasn't sure why the maven-surefire-plugin configuration was removed (there's no comment here explaining that) so I left that in, and I think the Release.java is better dealt with in its own bug. Log a bug on that one and i'll commit the patch, but I don't think that one is urgent.
> Bundle packaging ignoring the JAR plugin excludes
> -------------------------------------------------
>
> Key: JUDDI-361
> URL: https://issues.apache.org/jira/browse/JUDDI-361
> Project: jUDDI
> Issue Type: Bug
> Components: core
> Affects Versions: 3.0.2
> Reporter: Tom Cunningham
> Assignee: Tom Cunningham
> Fix For: 3.0.2
>
> Attachments: JUDDI-361-2.diff, JUDDI-361-3.diff, JUDDI-361.diff
>
>
> The bundle plugin seems to be causing the JAR excludes not to fire. Adding a <goal>jar</goal> to the executions seems to fix.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Resolved: (JUDDI-361) Bundle packaging ignoring the JAR
plugin excludes
Posted by "Tom Cunningham (JIRA)" <ju...@ws.apache.org>.
[ https://issues.apache.org/jira/browse/JUDDI-361?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Tom Cunningham resolved JUDDI-361.
----------------------------------
Resolution: Fixed
Added <goal>jar</goal> into jar plugin executions.
> Bundle packaging ignoring the JAR plugin excludes
> -------------------------------------------------
>
> Key: JUDDI-361
> URL: https://issues.apache.org/jira/browse/JUDDI-361
> Project: jUDDI
> Issue Type: Bug
> Components: core
> Affects Versions: 3.0.2
> Reporter: Tom Cunningham
> Assignee: Tom Cunningham
> Fix For: 3.0.2
>
>
> The bundle plugin seems to be causing the JAR excludes not to fire. Adding a <goal>jar</goal> to the executions seems to fix.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (JUDDI-361) Bundle packaging ignoring the JAR
plugin excludes
Posted by "David Jencks (JIRA)" <ju...@ws.apache.org>.
[ https://issues.apache.org/jira/browse/JUDDI-361?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
David Jencks updated JUDDI-361:
-------------------------------
Attachment: JUDDI-361-3.diff
Yet another change.... this one eliminates the antrun plugin entirely by configuring separate locations for persistence.xml for each jpa provider. Note that no persistence.xml is included in the jar, ever. I don't know if the orm file is used for anything, I can't detect it. Deleting the src/main/resources/persistence directory would be appropriate.
> Bundle packaging ignoring the JAR plugin excludes
> -------------------------------------------------
>
> Key: JUDDI-361
> URL: https://issues.apache.org/jira/browse/JUDDI-361
> Project: jUDDI
> Issue Type: Bug
> Components: core
> Affects Versions: 3.0.2
> Reporter: Tom Cunningham
> Assignee: Tom Cunningham
> Fix For: 3.0.2
>
> Attachments: JUDDI-361-2.diff, JUDDI-361-3.diff, JUDDI-361.diff
>
>
> The bundle plugin seems to be causing the JAR excludes not to fire. Adding a <goal>jar</goal> to the executions seems to fix.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (JUDDI-361) Bundle packaging ignoring the JAR
plugin excludes
Posted by "David Jencks (JIRA)" <ju...@ws.apache.org>.
[ https://issues.apache.org/jira/browse/JUDDI-361?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
David Jencks updated JUDDI-361:
-------------------------------
Attachment: JUDDI-361-2.diff
This patch extends the previous one to use maven plugins to generate the Release.java file. Not sure if you'll be interested but I liked it. You'd want to svn rm the Release.java.template file as well.
> Bundle packaging ignoring the JAR plugin excludes
> -------------------------------------------------
>
> Key: JUDDI-361
> URL: https://issues.apache.org/jira/browse/JUDDI-361
> Project: jUDDI
> Issue Type: Bug
> Components: core
> Affects Versions: 3.0.2
> Reporter: Tom Cunningham
> Assignee: Tom Cunningham
> Fix For: 3.0.2
>
> Attachments: JUDDI-361-2.diff, JUDDI-361.diff
>
>
> The bundle plugin seems to be causing the JAR excludes not to fire. Adding a <goal>jar</goal> to the executions seems to fix.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Reopened: (JUDDI-361) Bundle packaging ignoring the JAR
plugin excludes
Posted by "David Jencks (JIRA)" <ju...@ws.apache.org>.
[ https://issues.apache.org/jira/browse/JUDDI-361?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
David Jencks reopened JUDDI-361:
--------------------------------
This change makes the artifact not be a bundle, so I hope we can find a better solution.
I'm very confused by all the antrun and include/exclude configuration in the pom. Can you describe what the code is trying to do? Maybe there's a simpler way.
Why is *-persistence.xml copied to anywhere in the src directory (this is normally a terrible idea) and why is it copied at all if it isn't included in the output jar?
I think that the <include-Resource> instruction can be used to include the startup data and that perhaps defining resources in the hibernate and openjpa profiles can be used to avoid the need to copy anything.
> Bundle packaging ignoring the JAR plugin excludes
> -------------------------------------------------
>
> Key: JUDDI-361
> URL: https://issues.apache.org/jira/browse/JUDDI-361
> Project: jUDDI
> Issue Type: Bug
> Components: core
> Affects Versions: 3.0.2
> Reporter: Tom Cunningham
> Assignee: Tom Cunningham
> Fix For: 3.0.2
>
>
> The bundle plugin seems to be causing the JAR excludes not to fire. Adding a <goal>jar</goal> to the executions seems to fix.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (JUDDI-361) Bundle packaging ignoring the JAR
plugin excludes
Posted by "David Jencks (JIRA)" <ju...@ws.apache.org>.
[ https://issues.apache.org/jira/browse/JUDDI-361?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12833145#action_12833145 ]
David Jencks commented on JUDDI-361:
------------------------------------
re surefire plugin config.... this looks to me like the default surefire configuration and I couldn't see any difference with and without it.... without is simpler so I suggested leaving it out.
> Bundle packaging ignoring the JAR plugin excludes
> -------------------------------------------------
>
> Key: JUDDI-361
> URL: https://issues.apache.org/jira/browse/JUDDI-361
> Project: jUDDI
> Issue Type: Bug
> Components: core
> Affects Versions: 3.0.2
> Reporter: Tom Cunningham
> Assignee: Tom Cunningham
> Fix For: 3.0.2
>
> Attachments: JUDDI-361-2.diff, JUDDI-361-3.diff, JUDDI-361.diff
>
>
> The bundle plugin seems to be causing the JAR excludes not to fire. Adding a <goal>jar</goal> to the executions seems to fix.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (JUDDI-361) Bundle packaging ignoring the JAR
plugin excludes
Posted by "David Jencks (JIRA)" <ju...@ws.apache.org>.
[ https://issues.apache.org/jira/browse/JUDDI-361?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
David Jencks updated JUDDI-361:
-------------------------------
Attachment: JUDDI-361.diff
This patch uses maven-bundle-plugin configuration to leave out the persistence.xml etc. files. It also leaves out the version template that I expect you didn't want anyway. It also leaves out some plugin configuration that looks unnecessary to me.
My idea for not copying persistence.xmls was to create
src/main/openjpa-resources/META-INF/persistence.xml
src/main/hibernate-resources/META-INF/persistence.xml
and include these in the openjpa and hibernate profiles as resources. If they need to be in classes for one or the other provider you can add them to classes, not resources. This kind of mod isn't really good to provide a diff for but I'll try if you want...
> Bundle packaging ignoring the JAR plugin excludes
> -------------------------------------------------
>
> Key: JUDDI-361
> URL: https://issues.apache.org/jira/browse/JUDDI-361
> Project: jUDDI
> Issue Type: Bug
> Components: core
> Affects Versions: 3.0.2
> Reporter: Tom Cunningham
> Assignee: Tom Cunningham
> Fix For: 3.0.2
>
> Attachments: JUDDI-361.diff
>
>
> The bundle plugin seems to be causing the JAR excludes not to fire. Adding a <goal>jar</goal> to the executions seems to fix.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Closed: (JUDDI-361) Bundle packaging ignoring the JAR plugin
excludes
Posted by "Tom Cunningham (JIRA)" <ju...@ws.apache.org>.
[ https://issues.apache.org/jira/browse/JUDDI-361?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Tom Cunningham closed JUDDI-361.
--------------------------------
> Bundle packaging ignoring the JAR plugin excludes
> -------------------------------------------------
>
> Key: JUDDI-361
> URL: https://issues.apache.org/jira/browse/JUDDI-361
> Project: jUDDI
> Issue Type: Bug
> Components: core
> Affects Versions: 3.0.2
> Reporter: Tom Cunningham
> Assignee: Tom Cunningham
> Fix For: 3.0.2
>
> Attachments: JUDDI-361-2.diff, JUDDI-361-3.diff, JUDDI-361.diff
>
>
> The bundle plugin seems to be causing the JAR excludes not to fire. Adding a <goal>jar</goal> to the executions seems to fix.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.