You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2022/11/23 21:43:28 UTC

[GitHub] [arrow-datafusion] alamb opened a new pull request, #4348: Improve error messages when memory is exhausted while sorting

alamb opened a new pull request, #4348:
URL: https://github.com/apache/arrow-datafusion/pull/4348

   # Which issue does this PR close?
   
   Follow on to https://github.com/apache/arrow-datafusion/pull/4330
   
   
   # Rationale for this change
   The idea is to make it clearer what is going on to a user who sees this error message
   
   # What changes are included in this PR?
   
   Implement suggestions from https://github.com/apache/arrow-datafusion/pull/4330#discussion_r1029705473
   
   # Are these changes tested?
   Yes
   # Are there any user-facing changes?
   better error messages


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [arrow-datafusion] tustvold commented on a diff in pull request #4348: Improve error messages when memory is exhausted while sorting

Posted by GitBox <gi...@apache.org>.
tustvold commented on code in PR #4348:
URL: https://github.com/apache/arrow-datafusion/pull/4348#discussion_r1031170711


##########
datafusion/core/src/execution/disk_manager.rs:
##########
@@ -103,21 +103,26 @@ impl DiskManager {
     }
 
     /// Return a temporary file from a randomized choice in the configured locations
-    pub fn create_tmp_file(&self) -> Result<NamedTempFile> {
+    ///
+    /// If the file can not be created for some reason, returns an
+    /// error message referencing the request description
+    pub fn create_tmp_file(&self, request_description: &str) -> Result<NamedTempFile> {

Review Comment:
   Hopefully once we rework the error handling story, we can move away from this nonsense



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [arrow-datafusion] ursabot commented on pull request #4348: Improve error messages when memory is exhausted while sorting

Posted by GitBox <gi...@apache.org>.
ursabot commented on PR #4348:
URL: https://github.com/apache/arrow-datafusion/pull/4348#issuecomment-1327780680

   Benchmark runs are scheduled for baseline = e34c6c33aac5dd68d999707fc9727c11068ae125 and contender = 0d65394f2d4b36938e549cf1686cef1c51813eb5. 0d65394f2d4b36938e549cf1686cef1c51813eb5 is a master commit associated with this PR. Results will be available as each benchmark for each run completes.
   Conbench compare runs links:
   [Skipped :warning: Benchmarking of arrow-datafusion-commits is not supported on ec2-t3-xlarge-us-east-2] [ec2-t3-xlarge-us-east-2](https://conbench.ursa.dev/compare/runs/012035b0bd1b4e56bfe780c76d956b9b...8dedc70b9f9f4775b400be71e09b9e71/)
   [Skipped :warning: Benchmarking of arrow-datafusion-commits is not supported on test-mac-arm] [test-mac-arm](https://conbench.ursa.dev/compare/runs/d98d8a4d150a4ff88c06dfd1bae2ebc4...094e2e44f4a743c697d9493a4ae736c5/)
   [Skipped :warning: Benchmarking of arrow-datafusion-commits is not supported on ursa-i9-9960x] [ursa-i9-9960x](https://conbench.ursa.dev/compare/runs/a408e8265abc4b1795227c3dfaef02e6...4fb6ea23be2448099f45a02108f83cf9/)
   [Skipped :warning: Benchmarking of arrow-datafusion-commits is not supported on ursa-thinkcentre-m75q] [ursa-thinkcentre-m75q](https://conbench.ursa.dev/compare/runs/7a6686a4b03a447eab902fb40abb48ab...bfd1f8569310414daafa20db723a695b/)
   Buildkite builds:
   Supported benchmarks:
   ec2-t3-xlarge-us-east-2: Supported benchmark langs: Python, R. Runs only benchmarks with cloud = True
   test-mac-arm: Supported benchmark langs: C++, Python, R
   ursa-i9-9960x: Supported benchmark langs: Python, R, JavaScript
   ursa-thinkcentre-m75q: Supported benchmark langs: C++, Java
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [arrow-datafusion] alamb merged pull request #4348: Improve error messages when memory is exhausted while sorting

Posted by GitBox <gi...@apache.org>.
alamb merged PR #4348:
URL: https://github.com/apache/arrow-datafusion/pull/4348


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org