[GitHub] [storm] bipinprasad commented on a diff in pull request #3539: [STORM-3913] Update rocksdb to version 8.1.1 that has Mac OSX JNI lib

["bipinprasad (via GitHub)" <gi...@apache.org>]

bipinprasad commented on code in PR #3539:
URL: https://github.com/apache/storm/pull/3539#discussion_r1180506358


##########
storm-server/pom.xml:
##########
@@ -60,6 +60,7 @@
         <dependency>
             <groupId>org.rocksdb</groupId>
             <artifactId>rocksdbjni</artifactId>
+            <version>${rocksdb-version}</version>

Review Comment:
   Not specifying a version in the dependency can cause unexpected and changing behavior. Maven will use the latest version of the dependency from local/remote repository. Storm pom files have this issue in a lot of places.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@storm.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org