You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by "dongjoon-hyun (via GitHub)" <gi...@apache.org> on 2023/08/23 22:52:39 UTC

[GitHub] [spark] dongjoon-hyun commented on a diff in pull request #42636: [SPARK-44935][K8S] Fix `RELEASE` file to have the correct information in Docker images if exists

dongjoon-hyun commented on code in PR #42636:
URL: https://github.com/apache/spark/pull/42636#discussion_r1303619550


##########
resource-managers/kubernetes/docker/src/main/dockerfiles/spark/Dockerfile:
##########
@@ -42,6 +42,8 @@ RUN set -ex && \
     rm -rf /var/cache/apt/* && rm -rf /var/lib/apt/lists/*
 
 COPY jars /opt/spark/jars
+# Copy RELEASE file if exists
+COPY RELEAS[E] /opt/spark/RELEASE

Review Comment:
   I used a trick glob pattern here in Dockerfile. Since `RELEASE` file doesn't exist in GitHub, `RELEAS[E]` matches `RELEASE` or `RELEAS` and this statement ignores when there is no such file.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org