You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@forrest.apache.org by "David Crossley (JIRA)" <ji...@apache.org> on 2005/08/07 04:40:35 UTC
[jira] Created: (FOR-604) The document-v* warning element does not get rendered properly
The document-v* warning element does not get rendered properly
--------------------------------------------------------------
Key: FOR-604
URL: http://issues.apache.org/jira/browse/FOR-604
Project: Forrest
Type: Bug
Versions: 0.8-dev
Reporter: David Crossley
Fix For: 0.8-dev
Attachments: 604-screenshot.png
The "warning" element is rendered differently to the "note" element. Perhaps it only happens with the "pelt" skin - not yet verified. See screenshot.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
Re: [jira] Commented: (FOR-604) The document-v* warning element does not get rendered properly
Posted by "Gav...." <br...@brightontown.com.au>.
basic.css.diff uploaded to issues,
thanks
Gav...
----- Original Message -----
From: "David Crossley" <cr...@apache.org>
To: <de...@forrest.apache.org>
Sent: Sunday, August 07, 2005 5:58 PM
Subject: Re: [jira] Commented: (FOR-604) The document-v* warning element
does not get rendered properly
| Thanks Gavin, i will reply here to try to keep commentary
| inside the Issue tracker to a minimum.
| ...
|
| Gavin (JIRA) wrote:
| > [
http://issues.apache.org/jira/browse/FOR-604?page=comments#action_12317898 ]
| >
| > Gavin commented on FOR-604:
| > ---------------------------
| >
| > Ok, I have made the changes needed. You can view it in action, I have
uploaded a basic site and at
http://apache.minitutorials.com/samples/sample.html you can see the new CSS
changes in action.
|
| Thanks that is great.
|
| > I am not all that familiar with svn, although it did state that
basic.css could not be diff'd (or something like that)
|
| Do you have an SVN checkout, or are you using a packaged release?
| This doc explains both situations.
| http://forrest.apache.org/contrib.html#patch
|
| > If somebody wants to explain how I can commit these changes,
|
| You cannot. Only committers can directly change the source control system.
| http://forrest.apache.org/who.html
| All other developers need to send patches.
|
| > if I can not then please paste the following into /pelt/css/basic.css as
a replacement for the code in my earlier message above.
|
| It would be far better to provide a diff if you can.
| Doing copy-and-paste is too error prone.
| If you cannot manage it, then i will use this text.
|
| > .note, .warning, .fixme {
| > border: solid black 1px;
| > margin: 1em 3em;
| > }
| >
| > .note .label {
| > background: #369;
| > color: white;
| > font-weight: bold;
| > padding: 5px 10px;
| > }
| > .note .content {
| > background: #F0F0FF;
| > color: black;
| > line-height: 120%;
| > font-size: 90%;
| > padding: 5px 10px;
| > }
| > .warning .label {
| > background: #C00;
| > color: white;
| > font-weight: bold;
| > padding: 5px 10px;
| > }
| > .warning .content {
| > background: #FFF0F0;
| > color: black;
| > line-height: 120%;
| > font-size: 90%;
| > padding: 5px 10px;
| > }
| > .fixme .label {
| > background: #C6C600;
| > font-weight: bold;
| > padding: 5px 10px;
| > }
| > .fixme .content {
| > padding: 5px 10px;
| > }
| >
|
> -----------------------------------------------------------------------------------------------
| > I guess to be consistent then leather-dev/css/basic.css will also need
to
| > be changed the same way. I will load leather-dev and make the changes,
| > making sure that it does not break anything else and then post back
here.
|
| Thanks.
|
| > Is there anything else I need to do here, doc changes ?
|
| No that should be it.
|
| David
|
|
| --
| No virus found in this incoming message.
| Checked by AVG Anti-Virus.
| Version: 7.0.338 / Virus Database: 267.10.1/64 - Release Date: 4/08/2005
|
|
--
No virus found in this outgoing message.
Checked by AVG Anti-Virus.
Version: 7.0.338 / Virus Database: 267.10.1/64 - Release Date: 4/08/2005
Re: [jira] Commented: (FOR-604) The document-v* warning element does not get rendered properly
Posted by David Crossley <cr...@apache.org>.
Thanks Gavin, i will reply here to try to keep commentary
inside the Issue tracker to a minimum.
...
Gavin (JIRA) wrote:
> [ http://issues.apache.org/jira/browse/FOR-604?page=comments#action_12317898 ]
>
> Gavin commented on FOR-604:
> ---------------------------
>
> Ok, I have made the changes needed. You can view it in action, I have uploaded a basic site and at http://apache.minitutorials.com/samples/sample.html you can see the new CSS changes in action.
Thanks that is great.
> I am not all that familiar with svn, although it did state that basic.css could not be diff'd (or something like that)
Do you have an SVN checkout, or are you using a packaged release?
This doc explains both situations.
http://forrest.apache.org/contrib.html#patch
> If somebody wants to explain how I can commit these changes,
You cannot. Only committers can directly change the source control system.
http://forrest.apache.org/who.html
All other developers need to send patches.
> if I can not then please paste the following into /pelt/css/basic.css as a replacement for the code in my earlier message above.
It would be far better to provide a diff if you can.
Doing copy-and-paste is too error prone.
If you cannot manage it, then i will use this text.
> .note, .warning, .fixme {
> border: solid black 1px;
> margin: 1em 3em;
> }
>
> .note .label {
> background: #369;
> color: white;
> font-weight: bold;
> padding: 5px 10px;
> }
> .note .content {
> background: #F0F0FF;
> color: black;
> line-height: 120%;
> font-size: 90%;
> padding: 5px 10px;
> }
> .warning .label {
> background: #C00;
> color: white;
> font-weight: bold;
> padding: 5px 10px;
> }
> .warning .content {
> background: #FFF0F0;
> color: black;
> line-height: 120%;
> font-size: 90%;
> padding: 5px 10px;
> }
> .fixme .label {
> background: #C6C600;
> font-weight: bold;
> padding: 5px 10px;
> }
> .fixme .content {
> padding: 5px 10px;
> }
>
> -----------------------------------------------------------------------------------------------
> I guess to be consistent then leather-dev/css/basic.css will also need to
> be changed the same way. I will load leather-dev and make the changes,
> making sure that it does not break anything else and then post back here.
Thanks.
> Is there anything else I need to do here, doc changes ?
No that should be it.
David
[jira] Commented: (FOR-604) The document-v* warning element does not get rendered properly
Posted by "Gavin (JIRA)" <ji...@apache.org>.
[ http://issues.apache.org/jira/browse/FOR-604?page=comments#action_12317890 ]
Gavin commented on FOR-604:
---------------------------
This has been put in by design it seems, the leather-dev basic.css has it also as well as the pelt basic.css.
The 'Note' element used for both 'Note' and 'Important' has extra padding, line-height and font-size attributes.
This is the pelt/css/basic.css
.note, .warning, .fixme {
border: solid black 1px;
margin: 1em 3em;
}
.note .label {
background: #369;
color: white;
font-weight: bold;
padding: 5px 10px;
}
.note .content {
padding: 5px 10px;
background: #F0F0FF;
color: black;
line-height: 120%;
font-size: 90%;
}
.warning .label {
background: #C00;
color: white;
}
.warning .content {
background: #FFF0F0;
color: black;
}
.fixme .label {
background: #C6C600;
}
The leather-dev/css/basic.css is the same with one exception :
.note .content is set at 170% whereas in pelt it is 120%.
So either you leave it by design, or add padding, line-height and font-size to the .warning and .fixme, or remove those from .note.
Let me know and I'll make the changes if you like.
Check out http://localhost:8888/samples/sample.html also.
Gav...
> The document-v* warning element does not get rendered properly
> --------------------------------------------------------------
>
> Key: FOR-604
> URL: http://issues.apache.org/jira/browse/FOR-604
> Project: Forrest
> Type: Bug
> Versions: 0.8-dev
> Reporter: David Crossley
> Fix For: 0.8-dev
> Attachments: 604-screenshot.png
>
> The "warning" element is rendered differently to the "note" element. Perhaps it only happens with the "pelt" skin - not yet verified. See screenshot.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
[jira] Commented: (FOR-604) The document-v* warning element does not get rendered properly
Posted by "David Crossley (JIRA)" <ji...@apache.org>.
[ http://issues.apache.org/jira/browse/FOR-604?page=comments#action_12317945 ]
David Crossley commented on FOR-604:
------------------------------------
Thanks, applied your patch. I notice that there was unnecessary whitespace added, so i removed that. This will probably mean that you (Gavin) will get conflicts when you do 'svn update'. So either do 'svn revert basic.css' beforehand, or move the file out of the way and do 'svn update' again.
I will leave this issue open in case you manage to do leather-dev css too.
For the record, Gavin' s other questions above were answered on the dev list.
> The document-v* warning element does not get rendered properly
> --------------------------------------------------------------
>
> Key: FOR-604
> URL: http://issues.apache.org/jira/browse/FOR-604
> Project: Forrest
> Type: Bug
> Versions: 0.8-dev
> Reporter: David Crossley
> Assignee: David Crossley
> Fix For: 0.8-dev
> Attachments: 604-screenshot.png, basic.css.diff
>
> The "warning" element is rendered differently to the "note" element. Perhaps it only happens with the "pelt" skin - not yet verified. See screenshot.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
[jira] Commented: (FOR-604) The document-v* warning element does not get rendered properly
Posted by "Gavin (JIRA)" <ji...@apache.org>.
[ http://issues.apache.org/jira/browse/FOR-604?page=comments#action_12317907 ]
Gavin commented on FOR-604:
---------------------------
I have attatched basic.css.diff for inclusion.
Thanks
Gav...
> The document-v* warning element does not get rendered properly
> --------------------------------------------------------------
>
> Key: FOR-604
> URL: http://issues.apache.org/jira/browse/FOR-604
> Project: Forrest
> Type: Bug
> Versions: 0.8-dev
> Reporter: David Crossley
> Fix For: 0.8-dev
> Attachments: 604-screenshot.png, basic.css.diff
>
> The "warning" element is rendered differently to the "note" element. Perhaps it only happens with the "pelt" skin - not yet verified. See screenshot.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
[jira] Assigned: (FOR-604) The document-v* warning element does not get rendered properly
Posted by "David Crossley (JIRA)" <ji...@apache.org>.
[ http://issues.apache.org/jira/browse/FOR-604?page=all ]
David Crossley reassigned FOR-604:
----------------------------------
Assign To: David Crossley
> The document-v* warning element does not get rendered properly
> --------------------------------------------------------------
>
> Key: FOR-604
> URL: http://issues.apache.org/jira/browse/FOR-604
> Project: Forrest
> Type: Bug
> Versions: 0.8-dev
> Reporter: David Crossley
> Assignee: David Crossley
> Fix For: 0.8-dev
> Attachments: 604-screenshot.png, basic.css.diff
>
> The "warning" element is rendered differently to the "note" element. Perhaps it only happens with the "pelt" skin - not yet verified. See screenshot.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
[jira] Updated: (FOR-604) The document-v* warning element does not get rendered properly
Posted by "Gavin (JIRA)" <ji...@apache.org>.
[ http://issues.apache.org/jira/browse/FOR-604?page=all ]
Gavin updated FOR-604:
----------------------
Attachment: basic.css.diff
This 'basic.css' not to be confused with the first pelt one, contains my amendments to the original /leather-dev/css/basic.css to match those of the pelt skin. I am not sure if this skin is being kept or not, but is done anyway. The new leather-dev skin codenamed viewHelper , for use with contracts has a different css style sheet which seems to inherit from viewHelper plugin default.css. Taking a look at http://apache.minitutorials.com/samples/sample.html shows similar problems in that 'fixme' does not have a style. Also the table in the preceding example does not show. Should I go ahead and fix the 'fixme' to match, if so do I use the build version or the whiteboard version.
Gav...
> The document-v* warning element does not get rendered properly
> --------------------------------------------------------------
>
> Key: FOR-604
> URL: http://issues.apache.org/jira/browse/FOR-604
> Project: Forrest
> Type: Bug
> Versions: 0.8-dev
> Reporter: David Crossley
> Assignee: David Crossley
> Fix For: 0.8-dev
> Attachments: 604-screenshot.png, basic.css.diff, basic.css.diff
>
> The "warning" element is rendered differently to the "note" element. Perhaps it only happens with the "pelt" skin - not yet verified. See screenshot.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
[jira] Commented: (FOR-604) The document-v* warning element does not get rendered properly
Posted by "David Crossley (JIRA)" <ji...@apache.org>.
[ http://issues.apache.org/jira/browse/FOR-604?page=comments#action_12317891 ]
David Crossley commented on FOR-604:
------------------------------------
Thanks for the research. I reckon it is not by deliberate design, rather a matter of inconsistent evolution. Glancing at the history
http://svn.apache.org/viewcvs.cgi/forrest/trunk/main/webapp/skins/pelt/css/basic.css
it seems that we had a warning and fixme defined in a certain way, and "frame" used for notes in another way.
Yes please Gav, those box types should all be consistent, so please tweak the CSS to make them all look good like Note does.
> The document-v* warning element does not get rendered properly
> --------------------------------------------------------------
>
> Key: FOR-604
> URL: http://issues.apache.org/jira/browse/FOR-604
> Project: Forrest
> Type: Bug
> Versions: 0.8-dev
> Reporter: David Crossley
> Fix For: 0.8-dev
> Attachments: 604-screenshot.png
>
> The "warning" element is rendered differently to the "note" element. Perhaps it only happens with the "pelt" skin - not yet verified. See screenshot.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
[jira] Closed: (FOR-604) The document-v* warning element does not get rendered properly
Posted by "David Crossley (JIRA)" <ji...@apache.org>.
[ http://issues.apache.org/jira/browse/FOR-604?page=all ]
David Crossley closed FOR-604:
------------------------------
Resolution: Fixed
Thanks, applied. I am closing this now.
Regarding your other questions about viewHelper plugin, i suggest that your CSS skills would be best utilised to help Cyriaque, Thorsten, Diwaker, and others to generally improve the use of CSS within "views". I am not clear about its use of the leather-dev "skin", so best talk to them on the dev list.
By the way, this patch would have been better created from the top-level, like you did with the pelt one (cd forrest; svn diff main/webapp/skins/pelt > pelt-css.diff). In that way, the pathname of the files is in the diff and so i cannot possibly apply to the wrong source. This one just contained the name "basic.css" so is obscure.
I see the problem with the whitespace is that the rest of the file is inconsistent.
> The document-v* warning element does not get rendered properly
> --------------------------------------------------------------
>
> Key: FOR-604
> URL: http://issues.apache.org/jira/browse/FOR-604
> Project: Forrest
> Type: Bug
> Versions: 0.8-dev
> Reporter: David Crossley
> Assignee: David Crossley
> Fix For: 0.8-dev
> Attachments: 604-screenshot.png, basic.css.diff, basic.css.diff
>
> The "warning" element is rendered differently to the "note" element. Perhaps it only happens with the "pelt" skin - not yet verified. See screenshot.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
[jira] Updated: (FOR-604) The document-v* warning element does not get rendered properly
Posted by "David Crossley (JIRA)" <ji...@apache.org>.
[ http://issues.apache.org/jira/browse/FOR-604?page=all ]
David Crossley updated FOR-604:
-------------------------------
Attachment: 604-screenshot.png
> The document-v* warning element does not get rendered properly
> --------------------------------------------------------------
>
> Key: FOR-604
> URL: http://issues.apache.org/jira/browse/FOR-604
> Project: Forrest
> Type: Bug
> Versions: 0.8-dev
> Reporter: David Crossley
> Fix For: 0.8-dev
> Attachments: 604-screenshot.png
>
> The "warning" element is rendered differently to the "note" element. Perhaps it only happens with the "pelt" skin - not yet verified. See screenshot.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
[jira] Updated: (FOR-604) The document-v* warning element does not get rendered properly
Posted by "Gavin (JIRA)" <ji...@apache.org>.
[ http://issues.apache.org/jira/browse/FOR-604?page=all ]
Gavin updated FOR-604:
----------------------
Attachment: basic.css.diff
> The document-v* warning element does not get rendered properly
> --------------------------------------------------------------
>
> Key: FOR-604
> URL: http://issues.apache.org/jira/browse/FOR-604
> Project: Forrest
> Type: Bug
> Versions: 0.8-dev
> Reporter: David Crossley
> Fix For: 0.8-dev
> Attachments: 604-screenshot.png, basic.css.diff
>
> The "warning" element is rendered differently to the "note" element. Perhaps it only happens with the "pelt" skin - not yet verified. See screenshot.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
[jira] Commented: (FOR-604) The document-v* warning element does not get rendered properly
Posted by "Gavin (JIRA)" <ji...@apache.org>.
[ http://issues.apache.org/jira/browse/FOR-604?page=comments#action_12317898 ]
Gavin commented on FOR-604:
---------------------------
Ok, I have made the changes needed. You can view it in action, I have uploaded a basic site and at http://apache.minitutorials.com/samples/sample.html you can see the new CSS changes in action.
I am not all that familiar with svn, although it did state that basic.css could not be diff'd (or something like that)
If somebody wants to explain how I can commit these changes, if I can not then please paste the following into /pelt/css/basic.css as a replacement for the code in my earlier message above.
.note, .warning, .fixme {
border: solid black 1px;
margin: 1em 3em;
}
.note .label {
background: #369;
color: white;
font-weight: bold;
padding: 5px 10px;
}
.note .content {
background: #F0F0FF;
color: black;
line-height: 120%;
font-size: 90%;
padding: 5px 10px;
}
.warning .label {
background: #C00;
color: white;
font-weight: bold;
padding: 5px 10px;
}
.warning .content {
background: #FFF0F0;
color: black;
line-height: 120%;
font-size: 90%;
padding: 5px 10px;
}
.fixme .label {
background: #C6C600;
font-weight: bold;
padding: 5px 10px;
}
.fixme .content {
padding: 5px 10px;
}
-----------------------------------------------------------------------------------------------
I guess to be consistent then leather-dev/css/basic.css will also need to
be changed the same way. I will load leather-dev and make the changes,
making sure that it does not break anything else and then post back here.
Is there anything else I need to do here, doc changes ?
Gav...
> The document-v* warning element does not get rendered properly
> --------------------------------------------------------------
>
> Key: FOR-604
> URL: http://issues.apache.org/jira/browse/FOR-604
> Project: Forrest
> Type: Bug
> Versions: 0.8-dev
> Reporter: David Crossley
> Fix For: 0.8-dev
> Attachments: 604-screenshot.png
>
> The "warning" element is rendered differently to the "note" element. Perhaps it only happens with the "pelt" skin - not yet verified. See screenshot.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira