[GitHub] [superset] hughhhh commented on a diff in pull request #20122: test(do not merge): rename and move dao file

[GitBox <gi...@apache.org>]

hughhhh commented on code in PR #20122:
URL: https://github.com/apache/superset/pull/20122#discussion_r877565108


##########
tests/integration_tests/dashboard_utils.py:
##########
@@ -54,7 +55,7 @@ def create_table_metadata(
 
     table = get_table(table_name, database, schema)
     if not table:
-        table_source = ConnectorRegistry.sources["table"]
+        table_source = DatasourceDAO.sources["table"]

Review Comment:
   you need to use the enum here:
   ```
   DatasourceDAO.sources[DatasourceType.SQLATABLE]
   ```



##########
tests/integration_tests/dashboard_utils.py:
##########
@@ -35,7 +36,7 @@ def get_table(
     schema: Optional[str] = None,
 ):
     schema = schema or get_example_default_schema()
-    table_source = ConnectorRegistry.sources["table"]
+    table_source = DatasourceDAO.sources["table"]

Review Comment:
   DatasourceDAO.sources[DatasourceType.SQLATABLE]



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org