[GitHub] [arrow-datafusion] alamb commented on a diff in pull request #5866: Improve avg/sum Aggregator performance

["alamb (via GitHub)" <gi...@apache.org>]

alamb commented on code in PR #5866:
URL: https://github.com/apache/arrow-datafusion/pull/5866#discussion_r1160154953


##########
datafusion/physical-expr/src/aggregate/utils.rs:
##########
@@ -31,3 +33,49 @@ pub fn get_accum_scalar_values_as_arrays(
         .map(|s| s.to_array_of_size(1))
         .collect::<Vec<_>>())
 }
+
+pub fn calculate_result_decimal_for_avg(

Review Comment:
   This seems somewhat related to https://github.com/apache/arrow-datafusion/pull/5675 from @viirya  to calculate the output size of a decimal multiplication. I wonder if there is some more general function / approach than special casing in the aggregator



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org