[GitHub] NamanRastogi commented on issue #3078: [WIP] Support show lru command to list the cache sizes for all tables

[GitBox <gi...@apache.org>]

NamanRastogi commented on issue #3078: [WIP] Support show lru command to list the cache sizes for all tables
URL: https://github.com/apache/carbondata/pull/3078#issuecomment-464605722
 
 
   Can we use the more general word **Cache** in place of **LRU** everywhere?
   LRU is our current caching mechanism, we may change that in future to something else. So it should be like the following to generalize to **cache** instead of one specific implementation of caching. 
   
   * `CarbonDataShowLRUCommand` -> `CarbonShowCacheCommand`
   * `CacheProvider.getCarbonLRUCache` -> `CacheProvider.getCache`
   * `CarbonLRUCache.getLruCacheMap()` -> `CarbonLRUCache.getCacheMap()`
   * `show lru on table lru_db.lru_1` -> `show cache on table lru_db.lru_1`
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services