[jira] Updated: (SOLR-965) Better exception logging when no ping query configured

["Mark Miller (JIRA)" <ji...@apache.org>]

     [ https://issues.apache.org/jira/browse/SOLR-965?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Mark Miller updated SOLR-965:
-----------------------------

    Attachment: SOLR-965.patch

Here is a simple patch that throws and exception if the ping query params are 0.

In the multicore scenario, you get:

HTTP ERROR: 500

Ping requires that the PingRequestHandler, admin/pingQuery is defined in solrconfig.xml with both QT and Q params

java.lang.IllegalStateException: Ping requires that the PingRequestHandler, admin/pingQuery is defined in solrconfig.xml with both QT and Q params
	at org.apache.solr.core.SolrConfig.getPingQueryRequest(SolrConfig.java:228)
	at org.apache.solr.core.SolrCore.getPingQueryRequest(SolrCore.java:781)
	at org.apache.jsp.admin.ping_jsp._jspService(org.apache.jsp.admin.ping_jsp:177)


I couldn't get the current ping.jsp error handling to work - I would get state exceptions errors that the response was already committed if a resp.sendError was hit
in the jsp. So I just throw an exception instead, and the dispatchfilter catches the exception and does the resp.sendError.

- Mark

> Better exception logging when no ping query configured
> ------------------------------------------------------
>
>                 Key: SOLR-965
>                 URL: https://issues.apache.org/jira/browse/SOLR-965
>             Project: Solr
>          Issue Type: Improvement
>    Affects Versions: 1.3
>            Reporter: Hoss Man
>             Fix For: 1.4
>
>         Attachments: SOLR-965.patch
>
>
> user noted that with the example multicore configs, http://localhost:8983/solr/core1/admin/ping results in a 500 error and logs quite a bit of crap starting with a NullPointerException.
> The failing ping is the correct behavior, because the example multicore configs don't define a pingQuery -- but the code path of the failure and the exceptions logged are less then ideal.  ping.jsp (which is still used if the PingRequestHandler doesn't get registered) and SolrConfig.getPingQueryRequest should me modified to log an (on topic) error and fail fast when there is no <pingQuery> declaration.
> A quick skim of PingRequestHandlers suggests we may also want to add some better logging (specifically: warnings about configuring it with good defaults) if it gets called without any params.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.