[jira] [Work logged] (ARTEMIS-3449) Speedup AMQP large message streaming

["ASF GitHub Bot (Jira)" <ji...@apache.org>]

     [ https://issues.apache.org/jira/browse/ARTEMIS-3449?focusedWorklogId=644814&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-644814 ]

ASF GitHub Bot logged work on ARTEMIS-3449:
-------------------------------------------

                Author: ASF GitHub Bot
            Created on: 01/Sep/21 08:28
            Start Date: 01/Sep/21 08:28
    Worklog Time Spent: 10m 
      Work Description: gemmellr commented on pull request #3711:
URL: https://github.com/apache/activemq-artemis/pull/3711#issuecomment-910061298


   > 
   > Given that I know (as a programmer, not in the code :P ) that what's used is a CRB, I didn't take time to implement optimized versions for the other cases eg Netty/NIO buffer
   > 
   
   Ok, your original comment read to me as if it were saying it wouldnt work otherwise, i.e it relied on the CRB, which I  just wasnt seeing. I think its fine the simple way it is.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: gitbox-unsubscribe@activemq.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Issue Time Tracking
-------------------

    Worklog Id:     (was: 644814)
    Time Spent: 7h 10m  (was: 7h)

> Speedup AMQP large message streaming
> ------------------------------------
>
>                 Key: ARTEMIS-3449
>                 URL: https://issues.apache.org/jira/browse/ARTEMIS-3449
>             Project: ActiveMQ Artemis
>          Issue Type: Improvement
>            Reporter: Francesco Nigro
>            Assignee: Francesco Nigro
>            Priority: Major
>          Time Spent: 7h 10m
>  Remaining Estimate: 0h
>
> AMQP is using unpooled heap ByteBuffer(s) to stream AMQP large messages: given that the underline NIO sequential file can both use FileChannel or RandomAccessFile (depending if the ByteBuffer used is direct/heap based), both approaches would benefit from using Netty pooled direct buffers and save additional copies (performed by RandomAccessFile) to happen, reducing GC too.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)