You are viewing a plain text version of this content. The canonical link for it is here.

Posted to reviews@iotdb.apache.org by GitBox <gi...@apache.org> on 2020/05/02 14:52:16 UTC

[GitHub] [incubator-iotdb] samperson1997 commented on pull request #1134: [IOTDB-631] Using new TsFile MetadataIndex to optimize query and cache

samperson1997 commented on pull request #1134:
URL: https://github.com/apache/incubator-iotdb/pull/1134#issuecomment-622965833


   Hi @qiaojialin , thanks a lot for your review! I have taken your suggestions with a little bit change as is mentioned below:
   * I've noticed that `allSensors` may not contain `key.measurement` during executing tests, so I put the key in the `allSensors` before sequenceReader's read process.
   * I've taken the `max_degree_of_index_node` for the measurement number's threshold, do you think it is acceptable? : )
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org