You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2021/06/30 20:58:58 UTC
[GitHub] [superset] rosemarie-chiu opened a new issue #15484: [Export Dashboard][Native Filter] Column selection is not saved in export file, and saving dataset id in export file doesn't seem to be a correct approach
rosemarie-chiu opened a new issue #15484:
URL: https://github.com/apache/superset/issues/15484
Column selection is not saved in export file, and saving dataset id in export file doesn't seem to be a correct approach
### Expected results
Import a dashboard with native filter to a new workspace should work seemlessly.
### Actual results
1. Selected column is not present in the export file, resulting in new dashboard native filter error with missing column selection.
2. Saving dataset id in the export file is an incorrect approach. Because the dataset id in a different workspace is different.
#### Screenshots
#### How to reproduce the bug
1. Create a dashboard
2. Create a value native filter and select dataset and column
3. Export this dashboard
4. Import this dashboard to a new workspace
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] rosemarie-chiu edited a comment on issue #15484: [Export Dashboard][Native Filter] Column selection is not saved in export file, and saving dataset id in export file doesn't seem to be a correct approach
Posted by GitBox <gi...@apache.org>.
rosemarie-chiu edited a comment on issue #15484:
URL: https://github.com/apache/superset/issues/15484#issuecomment-884549910
@junlincc @rusackas this should be a bug to fix not an enhancement. From my screenshot you can see that the exactly same filter, filterbox works just fine after export / import but native filter doesn't.
The root cause of this is that `filterbox` exported yaml refer to dataset by it's `dataset_uuid`
whereas `native filter` exported yaml file refer to dataset by it's `datasetId`
This is wrong because datasetId is different in every workspace. So I believe making that uuid instead of datasetId will solve this issue.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] junlincc commented on issue #15484: [Export Dashboard][Native Filter] Column selection is not saved in export file, and saving dataset id in export file doesn't seem to be a correct approach
Posted by GitBox <gi...@apache.org>.
junlincc commented on issue #15484:
URL: https://github.com/apache/superset/issues/15484#issuecomment-871794895
thanks for reporting the issue!! could you double check if filterbox work in this case? @rosemarie-chiu 🙏 it would help set the priority, whether it's for feature parity or a new feature request.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] rosemarie-chiu edited a comment on issue #15484: [Export Dashboard][Native Filter] Column selection is not saved in export file, and saving dataset id in export file doesn't seem to be a correct approach
Posted by GitBox <gi...@apache.org>.
rosemarie-chiu edited a comment on issue #15484:
URL: https://github.com/apache/superset/issues/15484#issuecomment-884549910
@junlincc @rusackas this should be a bug to fix not an enhancement. From my screenshot you can see that the exactly same filter, filterbox works just fine after export / import but native filter doesn't.
The root cause of this is that `filterbox` exported yaml refer to dataset by it's `dataset_uuid`
whereas `native filter` exported yaml file refer to dataset by it's `datasetId`
This is wrong because datasetId is different in every workspace. So I believe making that uuid instead of datasetId will solve this issue.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] rosemarie-chiu commented on issue #15484: [Export Dashboard][Native Filter] Column selection is not saved in export file, and saving dataset id in export file doesn't seem to be a correct approach
Posted by GitBox <gi...@apache.org>.
rosemarie-chiu commented on issue #15484:
URL: https://github.com/apache/superset/issues/15484#issuecomment-884549910
@junlincc @rusackas this should be a bug to fix not an enhancement. From my screenshot you can see that the exactly same filter, filterbox works just fine after export / import but native filter doesn't.
The root cause of this is that `filterbox` exported yaml refer to dataset by it's `uuid`
whereas `native filter` exported yaml file refer to dataset by it's `datasetId`
This is wrong because datasetId is different in every workspace. So I believe making that uuid instead of datasetId will solve this issue.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] michael-s-molina commented on issue #15484: [Export Dashboard][Native Filter] Column selection is not saved in export file, and saving dataset id in export file doesn't seem to be a correct approach
Posted by GitBox <gi...@apache.org>.
michael-s-molina commented on issue #15484:
URL: https://github.com/apache/superset/issues/15484#issuecomment-889949517
Beautiful investigative work and issue description @rosemarie-chiu 👏🏼
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] rosemarie-chiu edited a comment on issue #15484: [Export Dashboard][Native Filter] Column selection is not saved in export file, and saving dataset id in export file doesn't seem to be a correct approach
Posted by GitBox <gi...@apache.org>.
rosemarie-chiu edited a comment on issue #15484:
URL: https://github.com/apache/superset/issues/15484#issuecomment-884549910
@junlincc @rusackas this should be a bug to fix not an enhancement. From my screenshot you can see that the exactly same filter, filterbox works just fine after export / import but native filter doesn't.
The root cause of this is that `filterbox` exported yaml refer to dataset by it's `dataset_uuid` ✅
whereas `native filter` exported yaml file refer to dataset by it's `datasetId` ❌ bad
This is wrong because datasetId is different in every workspace. So I believe making that refer to `dataset_uuid` instead of `datasetId` will solve this issue.
cc @jinghua-qa look out for this when you are using exported dashboard as testing data.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] rusackas commented on issue #15484: [Export Dashboard][Native Filter] Column selection is not saved in export file, and saving dataset id in export file doesn't seem to be a correct approach
Posted by GitBox <gi...@apache.org>.
rusackas commented on issue #15484:
URL: https://github.com/apache/superset/issues/15484#issuecomment-875092410
Duplicates #15531
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] villebro commented on issue #15484: [Export Dashboard][Native Filter] Column selection is not saved in export file, and saving dataset id in export file doesn't seem to be a correct approach
Posted by GitBox <gi...@apache.org>.
villebro commented on issue #15484:
URL: https://github.com/apache/superset/issues/15484#issuecomment-889802835
This has been reproduced and is only affecting installations that have enabled the "VERSIONED_EXPORT" feature flag - with the feature flag disabled this works correctly. The solution is to port the logic from the legacy JSON-based export to the new YAML-based export (working on it now).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] villebro closed issue #15484: [Export Dashboard][Native Filter] Column selection is not saved in export file, and saving dataset id in export file doesn't seem to be a correct approach
Posted by GitBox <gi...@apache.org>.
villebro closed issue #15484:
URL: https://github.com/apache/superset/issues/15484
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] rosemarie-chiu commented on issue #15484: [Export Dashboard][Native Filter] Column selection is not saved in export file, and saving dataset id in export file doesn't seem to be a correct approach
Posted by GitBox <gi...@apache.org>.
rosemarie-chiu commented on issue #15484:
URL: https://github.com/apache/superset/issues/15484#issuecomment-889275967
cc @villebro https://github.com/apache/superset/pull/15253/files I think it is this PR we added mapping to datasetId.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] rosemarie-chiu edited a comment on issue #15484: [Export Dashboard][Native Filter] Column selection is not saved in export file, and saving dataset id in export file doesn't seem to be a correct approach
Posted by GitBox <gi...@apache.org>.
rosemarie-chiu edited a comment on issue #15484:
URL: https://github.com/apache/superset/issues/15484#issuecomment-884549910
@junlincc @rusackas this should be a bug to fix not an enhancement. From my screenshot you can see that the exactly same filter, filterbox works just fine after export / import but native filter doesn't.
The root cause of this is that `filterbox` exported yaml refer to dataset by it's `dataset_uuid`
whereas `native filter` exported yaml file refer to dataset by it's `datasetId`
This is wrong because datasetId is different in every workspace. So I believe making that refer to `dataset_uuid` instead of `datasetId` will solve this issue.
cc @jinghua-qa look out for this when you are using exported dashboard as testing data.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org