You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by "peter-toth (via GitHub)" <gi...@apache.org> on 2023/03/10 10:13:44 UTC
[GitHub] [spark] peter-toth commented on a diff in pull request #40364: [SPARK-42745][SQL] Improved AliasAwareOutputExpression works with DSv2
peter-toth commented on code in PR #40364:
URL: https://github.com/apache/spark/pull/40364#discussion_r1132189767
##########
sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/v2/BatchScanExec.scala:
##########
@@ -44,12 +44,13 @@ case class BatchScanExec(
applyPartialClustering: Boolean = false,
replicatePartitions: Boolean = false) extends DataSourceV2ScanExecBase {
- @transient lazy val batch = scan.toBatch
+ @transient lazy val batch = if (scan == null) null else scan.toBatch
// TODO: unify the equal/hashCode implementation for all data source v2 query plans.
override def equals(other: Any): Boolean = other match {
case other: BatchScanExec =>
- this.batch == other.batch && this.runtimeFilters == other.runtimeFilters &&
+ this.batch != null && this.batch == other.batch &&
Review Comment:
This is to not consider `BatchScanExec` equal when `batch` is not available.
##########
sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/v2/BatchScanExec.scala:
##########
@@ -44,12 +44,13 @@ case class BatchScanExec(
applyPartialClustering: Boolean = false,
replicatePartitions: Boolean = false) extends DataSourceV2ScanExecBase {
- @transient lazy val batch = scan.toBatch
+ @transient lazy val batch = if (scan == null) null else scan.toBatch
// TODO: unify the equal/hashCode implementation for all data source v2 query plans.
override def equals(other: Any): Boolean = other match {
case other: BatchScanExec =>
- this.batch == other.batch && this.runtimeFilters == other.runtimeFilters &&
+ this.batch != null && this.batch == other.batch &&
Review Comment:
This is to not consider `BatchScanExec`s equal when `batch` is not available.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org