You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@geode.apache.org by Anthony Baker <ab...@apache.org> on 2016/09/19 01:11:42 UTC
Review Request 52019: GEODE-1513: Remove duplicate jars from war files
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52019/
-----------------------------------------------------------
Review request for geode, Dick Cavender, Jens Deppe, Jinmei Liao, and Mark Bretl.
Repository: geode
Description
-------
Remove duplicate jar files from the lib directory of the
geode-web, geode-web-api, and geode-pulse war archives. Gradle
doesn't appear to be doing the correct thing, so force it using
a duplicates strategy. In addition, do not create geode-web-api
or geode-pulse jar files. These don't seem to be used anywhere.
Diffs
-----
geode-assembly/build.gradle 3ed864ba5dd2e9589d5cb8313fe59747b76a91b0
geode-pulse/build.gradle e53a698700f0de62088b3ac50cb96d4841315124
geode-web-api/build.gradle 388dbba7c9c0bc9134dbd5818c49edb9d0eae7a6
geode-web/build.gradle 75844d39678c5acc617e70f9cfa77c1049ca9d69
Diff: https://reviews.apache.org/r/52019/diff/
Testing
-------
Thanks,
Anthony Baker
Re: Review Request 52019: GEODE-1513: Remove duplicate jars from war
files
Posted by Anthony Baker <ab...@apache.org>.
> On Sept. 19, 2016, 3:18 p.m., Jinmei Liao wrote:
> > the web jar files are only used in the war file. If the war files still have the jar files in it, then this change should be ok.
The geode-web-api and pulse jar files don't seem to bee used anywhere (including inside the war file). The war files contain exploded classes.
- Anthony
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52019/#review149479
-----------------------------------------------------------
On Sept. 19, 2016, 1:11 a.m., Anthony Baker wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/52019/
> -----------------------------------------------------------
>
> (Updated Sept. 19, 2016, 1:11 a.m.)
>
>
> Review request for geode, Dick Cavender, Jens Deppe, Jinmei Liao, and Mark Bretl.
>
>
> Repository: geode
>
>
> Description
> -------
>
> Remove duplicate jar files from the lib directory of the
> geode-web, geode-web-api, and geode-pulse war archives. Gradle
> doesn't appear to be doing the correct thing, so force it using
> a duplicates strategy. In addition, do not create geode-web-api
> or geode-pulse jar files. These don't seem to be used anywhere.
>
>
> Diffs
> -----
>
> geode-assembly/build.gradle 3ed864ba5dd2e9589d5cb8313fe59747b76a91b0
> geode-pulse/build.gradle e53a698700f0de62088b3ac50cb96d4841315124
> geode-web-api/build.gradle 388dbba7c9c0bc9134dbd5818c49edb9d0eae7a6
> geode-web/build.gradle 75844d39678c5acc617e70f9cfa77c1049ca9d69
>
> Diff: https://reviews.apache.org/r/52019/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Anthony Baker
>
>
Re: Review Request 52019: GEODE-1513: Remove duplicate jars from war
files
Posted by Jinmei Liao <ji...@pivotal.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52019/#review149479
-----------------------------------------------------------
the web jar files are only used in the war file. If the war files still have the jar files in it, then this change should be ok.
- Jinmei Liao
On Sept. 19, 2016, 1:11 a.m., Anthony Baker wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/52019/
> -----------------------------------------------------------
>
> (Updated Sept. 19, 2016, 1:11 a.m.)
>
>
> Review request for geode, Dick Cavender, Jens Deppe, Jinmei Liao, and Mark Bretl.
>
>
> Repository: geode
>
>
> Description
> -------
>
> Remove duplicate jar files from the lib directory of the
> geode-web, geode-web-api, and geode-pulse war archives. Gradle
> doesn't appear to be doing the correct thing, so force it using
> a duplicates strategy. In addition, do not create geode-web-api
> or geode-pulse jar files. These don't seem to be used anywhere.
>
>
> Diffs
> -----
>
> geode-assembly/build.gradle 3ed864ba5dd2e9589d5cb8313fe59747b76a91b0
> geode-pulse/build.gradle e53a698700f0de62088b3ac50cb96d4841315124
> geode-web-api/build.gradle 388dbba7c9c0bc9134dbd5818c49edb9d0eae7a6
> geode-web/build.gradle 75844d39678c5acc617e70f9cfa77c1049ca9d69
>
> Diff: https://reviews.apache.org/r/52019/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Anthony Baker
>
>
Re: Review Request 52019: GEODE-1513: Remove duplicate jars from war
files
Posted by Anthony Baker <ab...@apache.org>.
> On Sept. 20, 2016, 2:17 p.m., Jens Deppe wrote:
> > geode-pulse.war contains geode-web.jar - I don't think it needs that.
> >
> > Both geode-pulse.war and geode-web-api.war contain the relevant exploded classes. However, geode-web.war contains a geode-web.jar file with the actual classes. It would be nice to be consistent - whatever is easisest and clearer to set up in Gradle should be fine.
Unfortunately, geode-web.jar is generated in the geode-core project (for bad but necessary reasons that we should fix). The simplest thing in gradle projects is to *not* bundle classes into a jar.
- Anthony
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52019/#review149661
-----------------------------------------------------------
On Sept. 19, 2016, 1:11 a.m., Anthony Baker wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/52019/
> -----------------------------------------------------------
>
> (Updated Sept. 19, 2016, 1:11 a.m.)
>
>
> Review request for geode, Dick Cavender, Jens Deppe, Jinmei Liao, and Mark Bretl.
>
>
> Repository: geode
>
>
> Description
> -------
>
> Remove duplicate jar files from the lib directory of the
> geode-web, geode-web-api, and geode-pulse war archives. Gradle
> doesn't appear to be doing the correct thing, so force it using
> a duplicates strategy. In addition, do not create geode-web-api
> or geode-pulse jar files. These don't seem to be used anywhere.
>
>
> Diffs
> -----
>
> geode-assembly/build.gradle 3ed864ba5dd2e9589d5cb8313fe59747b76a91b0
> geode-pulse/build.gradle e53a698700f0de62088b3ac50cb96d4841315124
> geode-web-api/build.gradle 388dbba7c9c0bc9134dbd5818c49edb9d0eae7a6
> geode-web/build.gradle 75844d39678c5acc617e70f9cfa77c1049ca9d69
>
> Diff: https://reviews.apache.org/r/52019/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Anthony Baker
>
>
Re: Review Request 52019: GEODE-1513: Remove duplicate jars from war
files
Posted by Jens Deppe <jd...@pivotal.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52019/#review149661
-----------------------------------------------------------
geode-pulse.war contains geode-web.jar - I don't think it needs that.
Both geode-pulse.war and geode-web-api.war contain the relevant exploded classes. However, geode-web.war contains a geode-web.jar file with the actual classes. It would be nice to be consistent - whatever is easisest and clearer to set up in Gradle should be fine.
- Jens Deppe
On Sept. 19, 2016, 1:11 a.m., Anthony Baker wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/52019/
> -----------------------------------------------------------
>
> (Updated Sept. 19, 2016, 1:11 a.m.)
>
>
> Review request for geode, Dick Cavender, Jens Deppe, Jinmei Liao, and Mark Bretl.
>
>
> Repository: geode
>
>
> Description
> -------
>
> Remove duplicate jar files from the lib directory of the
> geode-web, geode-web-api, and geode-pulse war archives. Gradle
> doesn't appear to be doing the correct thing, so force it using
> a duplicates strategy. In addition, do not create geode-web-api
> or geode-pulse jar files. These don't seem to be used anywhere.
>
>
> Diffs
> -----
>
> geode-assembly/build.gradle 3ed864ba5dd2e9589d5cb8313fe59747b76a91b0
> geode-pulse/build.gradle e53a698700f0de62088b3ac50cb96d4841315124
> geode-web-api/build.gradle 388dbba7c9c0bc9134dbd5818c49edb9d0eae7a6
> geode-web/build.gradle 75844d39678c5acc617e70f9cfa77c1049ca9d69
>
> Diff: https://reviews.apache.org/r/52019/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Anthony Baker
>
>
Re: Review Request 52019: GEODE-1513: Remove duplicate jars from war
files
Posted by Anthony Baker <ab...@apache.org>.
> On Sept. 20, 2016, 12:32 a.m., Mark Bretl wrote:
> > Looks good. I applied changes to a local workspace and found the duplicate jars removed from the pulse.war.
> >
> > Very minor: Do we want to add 'jar.enabled = false' to those projects (geode-pulse and geode-web-api) to make sure we will not create the jars in the future?
Thanks, I'll look into that.
- Anthony
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52019/#review149582
-----------------------------------------------------------
On Sept. 19, 2016, 1:11 a.m., Anthony Baker wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/52019/
> -----------------------------------------------------------
>
> (Updated Sept. 19, 2016, 1:11 a.m.)
>
>
> Review request for geode, Dick Cavender, Jens Deppe, Jinmei Liao, and Mark Bretl.
>
>
> Repository: geode
>
>
> Description
> -------
>
> Remove duplicate jar files from the lib directory of the
> geode-web, geode-web-api, and geode-pulse war archives. Gradle
> doesn't appear to be doing the correct thing, so force it using
> a duplicates strategy. In addition, do not create geode-web-api
> or geode-pulse jar files. These don't seem to be used anywhere.
>
>
> Diffs
> -----
>
> geode-assembly/build.gradle 3ed864ba5dd2e9589d5cb8313fe59747b76a91b0
> geode-pulse/build.gradle e53a698700f0de62088b3ac50cb96d4841315124
> geode-web-api/build.gradle 388dbba7c9c0bc9134dbd5818c49edb9d0eae7a6
> geode-web/build.gradle 75844d39678c5acc617e70f9cfa77c1049ca9d69
>
> Diff: https://reviews.apache.org/r/52019/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Anthony Baker
>
>
Re: Review Request 52019: GEODE-1513: Remove duplicate jars from war
files
Posted by Mark Bretl <mb...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52019/#review149582
-----------------------------------------------------------
Ship it!
Looks good. I applied changes to a local workspace and found the duplicate jars removed from the pulse.war.
Very minor: Do we want to add 'jar.enabled = false' to those projects (geode-pulse and geode-web-api) to make sure we will not create the jars in the future?
- Mark Bretl
On Sept. 18, 2016, 6:11 p.m., Anthony Baker wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/52019/
> -----------------------------------------------------------
>
> (Updated Sept. 18, 2016, 6:11 p.m.)
>
>
> Review request for geode, Dick Cavender, Jens Deppe, Jinmei Liao, and Mark Bretl.
>
>
> Repository: geode
>
>
> Description
> -------
>
> Remove duplicate jar files from the lib directory of the
> geode-web, geode-web-api, and geode-pulse war archives. Gradle
> doesn't appear to be doing the correct thing, so force it using
> a duplicates strategy. In addition, do not create geode-web-api
> or geode-pulse jar files. These don't seem to be used anywhere.
>
>
> Diffs
> -----
>
> geode-assembly/build.gradle 3ed864ba5dd2e9589d5cb8313fe59747b76a91b0
> geode-pulse/build.gradle e53a698700f0de62088b3ac50cb96d4841315124
> geode-web-api/build.gradle 388dbba7c9c0bc9134dbd5818c49edb9d0eae7a6
> geode-web/build.gradle 75844d39678c5acc617e70f9cfa77c1049ca9d69
>
> Diff: https://reviews.apache.org/r/52019/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Anthony Baker
>
>