You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2020/03/22 11:38:10 UTC
[GitHub] [spark] MaxGekk opened a new pull request #27980: [WIP][SQL] Rebase
any date-times in conversions to/from Java types
MaxGekk opened a new pull request #27980: [WIP][SQL] Rebase any date-times in conversions to/from Java types
URL: https://github.com/apache/spark/pull/27980
<!--
Thanks for sending a pull request! Here are some tips for you:
1. If this is your first time, please read our contributor guidelines: https://spark.apache.org/contributing.html
2. Ensure you have added or run the appropriate tests for your PR: https://spark.apache.org/developer-tools.html
3. If the PR is unfinished, add '[WIP]' in your PR title, e.g., '[WIP][SPARK-XXXX] Your PR title ...'.
4. Be sure to keep the PR description updated to reflect all changes.
5. Please write your PR title to summarize what this PR proposes.
6. If possible, provide a concise example to reproduce the issue for a faster review.
7. If you want to add a new configuration, please read the guideline first for naming configurations in
'core/src/main/scala/org/apache/spark/internal/config/ConfigEntry.scala'.
-->
### What changes were proposed in this pull request?
<!--
Please clarify what changes you are proposing. The purpose of this section is to outline the changes and how this PR fixes the issue.
If possible, please consider writing useful notes for better and faster reviews in your PR. See the examples below.
1. If you refactor some codes with changing classes, showing the class hierarchy will help reviewers.
2. If you fix some SQL features, you can provide some references of other DBMSes.
3. If there is design documentation, please add the link.
4. If there is a discussion in the mailing list, please add the link.
-->
### Why are the changes needed?
<!--
Please clarify why the changes are needed. For instance,
1. If you propose a new API, clarify the use case for a new API.
2. If you fix a bug, you can clarify why it is a bug.
-->
### Does this PR introduce any user-facing change?
<!--
If yes, please clarify the previous behavior and the change this PR proposes - provide the console output, description and/or an example to show the behavior difference if possible.
If no, write 'No'.
-->
### How was this patch tested?
<!--
If tests were added, say they were added here. Please make sure to add some test cases that check the changes thoroughly including negative and positive cases if possible.
If it was tested in a way different from regular unit tests, please clarify how you tested step by step, ideally copy and paste-able, so that other reviewers can test and check, and descendants can verify in the future.
If tests were not added, please describe why they were not added and/or why it was difficult to add.
-->
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #27980:
[SPARK-31221][SQL] Rebase any date-times in conversions to/from Java types
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #27980: [SPARK-31221][SQL] Rebase any date-times in conversions to/from Java types
URL: https://github.com/apache/spark/pull/27980#issuecomment-602721288
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/120197/
Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on issue #27980: [WIP][SQL] Rebase any
date-times in conversions to/from Java types
Posted by GitBox <gi...@apache.org>.
SparkQA commented on issue #27980: [WIP][SQL] Rebase any date-times in conversions to/from Java types
URL: https://github.com/apache/spark/pull/27980#issuecomment-602264902
**[Test build #120170 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/120170/testReport)** for PR 27980 at commit [`db89c92`](https://github.com/apache/spark/commit/db89c92257370c77b165e7d5afc1dcf035f4dfd2).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #27980: [WIP][SQL]
Rebase any date-times in conversions to/from Java types
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #27980: [WIP][SQL] Rebase any date-times in conversions to/from Java types
URL: https://github.com/apache/spark/pull/27980#issuecomment-602265046
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/24883/
Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #27980: [WIP][SQL] Rebase
any date-times in conversions to/from Java types
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #27980: [WIP][SQL] Rebase any date-times in conversions to/from Java types
URL: https://github.com/apache/spark/pull/27980#issuecomment-602250802
Merged build finished. Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #27980: [SPARK-31221][SQL]
Rebase any date-times in conversions to/from Java types
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #27980: [SPARK-31221][SQL] Rebase any date-times in conversions to/from Java types
URL: https://github.com/apache/spark/pull/27980#issuecomment-603219797
Merged build finished. Test FAILed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on issue #27980: [SPARK-31221][SQL]
Rebase any date-times in conversions to/from Java types
Posted by GitBox <gi...@apache.org>.
SparkQA commented on issue #27980: [SPARK-31221][SQL] Rebase any date-times in conversions to/from Java types
URL: https://github.com/apache/spark/pull/27980#issuecomment-602720126
**[Test build #120197 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/120197/testReport)** for PR 27980 at commit [`6e8dba0`](https://github.com/apache/spark/commit/6e8dba065355d6f5a6fdd931221c832a0ed3bc99).
* This patch passes all tests.
* This patch merges cleanly.
* This patch adds no public classes.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #27980: [SPARK-31221][SQL]
Rebase any date-times in conversions to/from Java types
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #27980: [SPARK-31221][SQL] Rebase any date-times in conversions to/from Java types
URL: https://github.com/apache/spark/pull/27980#issuecomment-603219806
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/120251/
Test FAILed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on issue #27980: [WIP][SQL] Rebase any
date-times in conversions to/from Java types
Posted by GitBox <gi...@apache.org>.
SparkQA commented on issue #27980: [WIP][SQL] Rebase any date-times in conversions to/from Java types
URL: https://github.com/apache/spark/pull/27980#issuecomment-602286297
**[Test build #120169 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/120169/testReport)** for PR 27980 at commit [`0d4bc10`](https://github.com/apache/spark/commit/0d4bc108f490fa2367a4e0197dfce49b6edc4ddd).
* This patch passes all tests.
* This patch merges cleanly.
* This patch adds no public classes.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #27980: [WIP][SQL]
Rebase any date-times in conversions to/from Java types
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #27980: [WIP][SQL] Rebase any date-times in conversions to/from Java types
URL: https://github.com/apache/spark/pull/27980#issuecomment-602303893
Merged build finished. Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] cloud-fan commented on issue #27980: [SPARK-31221][SQL]
Rebase any date-times in conversions to/from Java types
Posted by GitBox <gi...@apache.org>.
cloud-fan commented on issue #27980: [SPARK-31221][SQL] Rebase any date-times in conversions to/from Java types
URL: https://github.com/apache/spark/pull/27980#issuecomment-603223611
The last commit updated a scala test, which is not related to the pyspark tests. The pip is a known issue.
Thanks, merging to master/3.0!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #27980: [SPARK-31221][SQL]
Rebase any date-times in conversions to/from Java types
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #27980: [SPARK-31221][SQL] Rebase any date-times in conversions to/from Java types
URL: https://github.com/apache/spark/pull/27980#issuecomment-602721288
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/120197/
Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] MaxGekk commented on a change in pull request #27980:
[SPARK-31221][SQL] Rebase any date-times in conversions to/from Java types
Posted by GitBox <gi...@apache.org>.
MaxGekk commented on a change in pull request #27980: [SPARK-31221][SQL] Rebase any date-times in conversions to/from Java types
URL: https://github.com/apache/spark/pull/27980#discussion_r396287278
##########
File path: sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/util/DateTimeUtilsSuite.scala
##########
@@ -508,8 +504,8 @@ class DateTimeUtilsSuite extends SparkFunSuite with Matchers with SQLHelper {
test("2016-03-13 03:00:00", "PST", "2016-03-13 10:00:00.0")
test("2016-11-06 00:59:59", "PST", "2016-11-06 07:59:59.0")
// 2016-11-06 01:00:00 PST could be 2016-11-06 08:00:00 UTC or 2016-11-06 09:00:00 UTC
- test("2016-11-06 01:00:00", "PST", "2016-11-06 09:00:00.0")
- test("2016-11-06 01:59:59", "PST", "2016-11-06 09:59:59.0")
+ test("2016-11-06 01:00:00", "PST", "2016-11-06 08:00:00.0")
Review comment:
Probably, I have found the reason this behavior. While resolving **PST** to zone offsets, this short name is converted to **America/Los_Angeles** by the map:
https://github.com/frohoff/jdk8u-jdk/blob/master/src/share/classes/java/time/ZoneId.java#L248
And as a consequence, `PST` is not a constant offset:
```scala
val pst = getZoneId("PST")
println(pst.getRules.getOffset(LocalDateTime.of(2016, 11, 5, 23, 59, 59)))
println(pst.getRules.getOffset(LocalDateTime.of(2016, 11, 6, 0, 0, 0)))
println(pst.getRules.getOffset(LocalDateTime.of(2016, 11, 6, 1, 0, 0)))
println(pst.getRules.getOffset(LocalDateTime.of(2016, 11, 6, 2, 0, 0)))
println(pst.getRules.getOffset(LocalDateTime.of(2016, 11, 6, 3, 0, 0)))
```
```
-07:00
-07:00
-07:00
-08:00
-08:00
```
At the test local timestamp `2016-11-06 01:00:00`, the offset is `-07:00`.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #27980: [WIP][SQL] Rebase
any date-times in conversions to/from Java types
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #27980: [WIP][SQL] Rebase any date-times in conversions to/from Java types
URL: https://github.com/apache/spark/pull/27980#issuecomment-602228804
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/120166/
Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] MaxGekk commented on a change in pull request #27980:
[SPARK-31221][SQL] Rebase any date-times in conversions to/from Java types
Posted by GitBox <gi...@apache.org>.
MaxGekk commented on a change in pull request #27980: [SPARK-31221][SQL] Rebase any date-times in conversions to/from Java types
URL: https://github.com/apache/spark/pull/27980#discussion_r396304056
##########
File path: sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/util/DateTimeUtilsSuite.scala
##########
@@ -508,8 +504,8 @@ class DateTimeUtilsSuite extends SparkFunSuite with Matchers with SQLHelper {
test("2016-03-13 03:00:00", "PST", "2016-03-13 10:00:00.0")
test("2016-11-06 00:59:59", "PST", "2016-11-06 07:59:59.0")
// 2016-11-06 01:00:00 PST could be 2016-11-06 08:00:00 UTC or 2016-11-06 09:00:00 UTC
- test("2016-11-06 01:00:00", "PST", "2016-11-06 09:00:00.0")
- test("2016-11-06 01:59:59", "PST", "2016-11-06 09:59:59.0")
+ test("2016-11-06 01:00:00", "PST", "2016-11-06 08:00:00.0")
Review comment:
@cloud-fan I got `2016-11-06 09:00:00.0` in the test by modifying the map `SHORT_IDS`:
```scala
def getZoneId(timeZoneId: String): ZoneId = {
import scala.collection.JavaConverters._
val m = Map("PST" -> "-08:00")
ZoneId.of(timeZoneId, m.asJava)
}
def getDefaultZoneId(): ZoneId = {
getZoneId(defaultTimeZone().getID)
}
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] cloud-fan commented on a change in pull request #27980:
[SPARK-31221][SQL] Rebase any date-times in conversions to/from Java types
Posted by GitBox <gi...@apache.org>.
cloud-fan commented on a change in pull request #27980: [SPARK-31221][SQL] Rebase any date-times in conversions to/from Java types
URL: https://github.com/apache/spark/pull/27980#discussion_r396367090
##########
File path: sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/util/DateTimeUtilsSuite.scala
##########
@@ -508,8 +504,8 @@ class DateTimeUtilsSuite extends SparkFunSuite with Matchers with SQLHelper {
test("2016-03-13 03:00:00", "PST", "2016-03-13 10:00:00.0")
test("2016-11-06 00:59:59", "PST", "2016-11-06 07:59:59.0")
// 2016-11-06 01:00:00 PST could be 2016-11-06 08:00:00 UTC or 2016-11-06 09:00:00 UTC
- test("2016-11-06 01:00:00", "PST", "2016-11-06 09:00:00.0")
- test("2016-11-06 01:59:59", "PST", "2016-11-06 09:59:59.0")
+ test("2016-11-06 01:00:00", "PST", "2016-11-06 08:00:00.0")
Review comment:
yes please
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on issue #27980: [SPARK-31221][SQL]
Rebase any date-times in conversions to/from Java types
Posted by GitBox <gi...@apache.org>.
SparkQA commented on issue #27980: [SPARK-31221][SQL] Rebase any date-times in conversions to/from Java types
URL: https://github.com/apache/spark/pull/27980#issuecomment-603076759
**[Test build #120251 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/120251/testReport)** for PR 27980 at commit [`46b6613`](https://github.com/apache/spark/commit/46b6613e4025f91487ce58e09cf0a1bccb17897e).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] MaxGekk commented on issue #27980: [SPARK-31221][SQL]
Rebase any date-times in conversions to/from Java types
Posted by GitBox <gi...@apache.org>.
MaxGekk commented on issue #27980: [SPARK-31221][SQL] Rebase any date-times in conversions to/from Java types
URL: https://github.com/apache/spark/pull/27980#issuecomment-602398253
@cloud-fan @HyukjinKwon Please, review this PR.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #27980:
[SPARK-31221][SQL] Rebase any date-times in conversions to/from Java types
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #27980: [SPARK-31221][SQL] Rebase any date-times in conversions to/from Java types
URL: https://github.com/apache/spark/pull/27980#issuecomment-603077363
Merged build finished. Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #27980:
[SPARK-31221][SQL] Rebase any date-times in conversions to/from Java types
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #27980: [SPARK-31221][SQL] Rebase any date-times in conversions to/from Java types
URL: https://github.com/apache/spark/pull/27980#issuecomment-603077369
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/24965/
Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #27980: [WIP][SQL] Rebase
any date-times in conversions to/from Java types
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #27980: [WIP][SQL] Rebase any date-times in conversions to/from Java types
URL: https://github.com/apache/spark/pull/27980#issuecomment-602187307
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/24879/
Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on issue #27980: [WIP][SQL]
Rebase any date-times in conversions to/from Java types
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on issue #27980: [WIP][SQL] Rebase any date-times in conversions to/from Java types
URL: https://github.com/apache/spark/pull/27980#issuecomment-602250674
**[Test build #120169 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/120169/testReport)** for PR 27980 at commit [`0d4bc10`](https://github.com/apache/spark/commit/0d4bc108f490fa2367a4e0197dfce49b6edc4ddd).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #27980: [WIP][SQL]
Rebase any date-times in conversions to/from Java types
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #27980: [WIP][SQL] Rebase any date-times in conversions to/from Java types
URL: https://github.com/apache/spark/pull/27980#issuecomment-602265040
Merged build finished. Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #27980: [WIP][SQL]
Rebase any date-times in conversions to/from Java types
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #27980: [WIP][SQL] Rebase any date-times in conversions to/from Java types
URL: https://github.com/apache/spark/pull/27980#issuecomment-602303901
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/120170/
Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] cloud-fan closed pull request #27980: [SPARK-31221][SQL]
Rebase any date-times in conversions to/from Java types
Posted by GitBox <gi...@apache.org>.
cloud-fan closed pull request #27980: [SPARK-31221][SQL] Rebase any date-times in conversions to/from Java types
URL: https://github.com/apache/spark/pull/27980
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #27980: [WIP][SQL]
Rebase any date-times in conversions to/from Java types
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #27980: [WIP][SQL] Rebase any date-times in conversions to/from Java types
URL: https://github.com/apache/spark/pull/27980#issuecomment-602187302
Merged build finished. Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #27980: [SPARK-31221][SQL]
Rebase any date-times in conversions to/from Java types
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #27980: [SPARK-31221][SQL] Rebase any date-times in conversions to/from Java types
URL: https://github.com/apache/spark/pull/27980#issuecomment-603077369
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/24965/
Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #27980: [WIP][SQL]
Rebase any date-times in conversions to/from Java types
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #27980: [WIP][SQL] Rebase any date-times in conversions to/from Java types
URL: https://github.com/apache/spark/pull/27980#issuecomment-602228804
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/120166/
Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #27980:
[SPARK-31221][SQL] Rebase any date-times in conversions to/from Java types
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #27980: [SPARK-31221][SQL] Rebase any date-times in conversions to/from Java types
URL: https://github.com/apache/spark/pull/27980#issuecomment-602721271
Merged build finished. Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #27980: [WIP][SQL] Rebase
any date-times in conversions to/from Java types
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #27980: [WIP][SQL] Rebase any date-times in conversions to/from Java types
URL: https://github.com/apache/spark/pull/27980#issuecomment-602228801
Merged build finished. Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on issue #27980: [WIP][SQL]
Rebase any date-times in conversions to/from Java types
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on issue #27980: [WIP][SQL] Rebase any date-times in conversions to/from Java types
URL: https://github.com/apache/spark/pull/27980#issuecomment-602186764
**[Test build #120166 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/120166/testReport)** for PR 27980 at commit [`b466cac`](https://github.com/apache/spark/commit/b466cac1aeef90558be03b74ce26c9d81238a98c).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #27980: [WIP][SQL] Rebase
any date-times in conversions to/from Java types
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #27980: [WIP][SQL] Rebase any date-times in conversions to/from Java types
URL: https://github.com/apache/spark/pull/27980#issuecomment-602187302
Merged build finished. Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #27980: [WIP][SQL]
Rebase any date-times in conversions to/from Java types
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #27980: [WIP][SQL] Rebase any date-times in conversions to/from Java types
URL: https://github.com/apache/spark/pull/27980#issuecomment-602250806
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/24882/
Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #27980: [WIP][SQL]
Rebase any date-times in conversions to/from Java types
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #27980: [WIP][SQL] Rebase any date-times in conversions to/from Java types
URL: https://github.com/apache/spark/pull/27980#issuecomment-602187307
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/24879/
Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #27980: [WIP][SQL]
Rebase any date-times in conversions to/from Java types
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #27980: [WIP][SQL] Rebase any date-times in conversions to/from Java types
URL: https://github.com/apache/spark/pull/27980#issuecomment-602228801
Merged build finished. Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #27980: [WIP][SQL] Rebase
any date-times in conversions to/from Java types
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #27980: [WIP][SQL] Rebase any date-times in conversions to/from Java types
URL: https://github.com/apache/spark/pull/27980#issuecomment-602265040
Merged build finished. Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #27980: [WIP][SQL]
Rebase any date-times in conversions to/from Java types
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #27980: [WIP][SQL] Rebase any date-times in conversions to/from Java types
URL: https://github.com/apache/spark/pull/27980#issuecomment-602286510
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/120169/
Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on issue #27980: [SPARK-31221][SQL]
Rebase any date-times in conversions to/from Java types
Posted by GitBox <gi...@apache.org>.
SparkQA commented on issue #27980: [SPARK-31221][SQL] Rebase any date-times in conversions to/from Java types
URL: https://github.com/apache/spark/pull/27980#issuecomment-602532456
**[Test build #120197 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/120197/testReport)** for PR 27980 at commit [`6e8dba0`](https://github.com/apache/spark/commit/6e8dba065355d6f5a6fdd931221c832a0ed3bc99).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #27980: [WIP][SQL]
Rebase any date-times in conversions to/from Java types
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #27980: [WIP][SQL] Rebase any date-times in conversions to/from Java types
URL: https://github.com/apache/spark/pull/27980#issuecomment-602286507
Merged build finished. Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #27980:
[SPARK-31221][SQL] Rebase any date-times in conversions to/from Java types
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #27980: [SPARK-31221][SQL] Rebase any date-times in conversions to/from Java types
URL: https://github.com/apache/spark/pull/27980#issuecomment-603219797
Merged build finished. Test FAILed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #27980: [WIP][SQL] Rebase
any date-times in conversions to/from Java types
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #27980: [WIP][SQL] Rebase any date-times in conversions to/from Java types
URL: https://github.com/apache/spark/pull/27980#issuecomment-602286510
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/120169/
Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #27980: [WIP][SQL] Rebase
any date-times in conversions to/from Java types
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #27980: [WIP][SQL] Rebase any date-times in conversions to/from Java types
URL: https://github.com/apache/spark/pull/27980#issuecomment-602286507
Merged build finished. Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on issue #27980:
[SPARK-31221][SQL] Rebase any date-times in conversions to/from Java types
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on issue #27980: [SPARK-31221][SQL] Rebase any date-times in conversions to/from Java types
URL: https://github.com/apache/spark/pull/27980#issuecomment-602532456
**[Test build #120197 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/120197/testReport)** for PR 27980 at commit [`6e8dba0`](https://github.com/apache/spark/commit/6e8dba065355d6f5a6fdd931221c832a0ed3bc99).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on issue #27980:
[SPARK-31221][SQL] Rebase any date-times in conversions to/from Java types
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on issue #27980: [SPARK-31221][SQL] Rebase any date-times in conversions to/from Java types
URL: https://github.com/apache/spark/pull/27980#issuecomment-603076759
**[Test build #120251 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/120251/testReport)** for PR 27980 at commit [`46b6613`](https://github.com/apache/spark/commit/46b6613e4025f91487ce58e09cf0a1bccb17897e).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] cloud-fan commented on a change in pull request #27980:
[SPARK-31221][SQL] Rebase any date-times in conversions to/from Java types
Posted by GitBox <gi...@apache.org>.
cloud-fan commented on a change in pull request #27980: [SPARK-31221][SQL] Rebase any date-times in conversions to/from Java types
URL: https://github.com/apache/spark/pull/27980#discussion_r396291188
##########
File path: sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/util/DateTimeUtilsSuite.scala
##########
@@ -508,8 +504,8 @@ class DateTimeUtilsSuite extends SparkFunSuite with Matchers with SQLHelper {
test("2016-03-13 03:00:00", "PST", "2016-03-13 10:00:00.0")
test("2016-11-06 00:59:59", "PST", "2016-11-06 07:59:59.0")
// 2016-11-06 01:00:00 PST could be 2016-11-06 08:00:00 UTC or 2016-11-06 09:00:00 UTC
- test("2016-11-06 01:00:00", "PST", "2016-11-06 09:00:00.0")
- test("2016-11-06 01:59:59", "PST", "2016-11-06 09:59:59.0")
+ test("2016-11-06 01:00:00", "PST", "2016-11-06 08:00:00.0")
Review comment:
is it possible to work around this JDK bug in the test? e.g. not use PST
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #27980: [SPARK-31221][SQL]
Rebase any date-times in conversions to/from Java types
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #27980: [SPARK-31221][SQL] Rebase any date-times in conversions to/from Java types
URL: https://github.com/apache/spark/pull/27980#issuecomment-602532961
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/24910/
Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on issue #27980: [WIP][SQL]
Rebase any date-times in conversions to/from Java types
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on issue #27980: [WIP][SQL] Rebase any date-times in conversions to/from Java types
URL: https://github.com/apache/spark/pull/27980#issuecomment-602264902
**[Test build #120170 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/120170/testReport)** for PR 27980 at commit [`db89c92`](https://github.com/apache/spark/commit/db89c92257370c77b165e7d5afc1dcf035f4dfd2).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #27980:
[SPARK-31221][SQL] Rebase any date-times in conversions to/from Java types
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #27980: [SPARK-31221][SQL] Rebase any date-times in conversions to/from Java types
URL: https://github.com/apache/spark/pull/27980#issuecomment-602532961
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/24910/
Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #27980: [WIP][SQL] Rebase
any date-times in conversions to/from Java types
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #27980: [WIP][SQL] Rebase any date-times in conversions to/from Java types
URL: https://github.com/apache/spark/pull/27980#issuecomment-602303901
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/120170/
Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #27980: [SPARK-31221][SQL]
Rebase any date-times in conversions to/from Java types
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #27980: [SPARK-31221][SQL] Rebase any date-times in conversions to/from Java types
URL: https://github.com/apache/spark/pull/27980#issuecomment-602721271
Merged build finished. Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on issue #27980: [WIP][SQL] Rebase any
date-times in conversions to/from Java types
Posted by GitBox <gi...@apache.org>.
SparkQA commented on issue #27980: [WIP][SQL] Rebase any date-times in conversions to/from Java types
URL: https://github.com/apache/spark/pull/27980#issuecomment-602186764
**[Test build #120166 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/120166/testReport)** for PR 27980 at commit [`b466cac`](https://github.com/apache/spark/commit/b466cac1aeef90558be03b74ce26c9d81238a98c).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #27980: [WIP][SQL]
Rebase any date-times in conversions to/from Java types
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #27980: [WIP][SQL] Rebase any date-times in conversions to/from Java types
URL: https://github.com/apache/spark/pull/27980#issuecomment-602250802
Merged build finished. Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on issue #27980: [WIP][SQL] Rebase any
date-times in conversions to/from Java types
Posted by GitBox <gi...@apache.org>.
SparkQA commented on issue #27980: [WIP][SQL] Rebase any date-times in conversions to/from Java types
URL: https://github.com/apache/spark/pull/27980#issuecomment-602250674
**[Test build #120169 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/120169/testReport)** for PR 27980 at commit [`0d4bc10`](https://github.com/apache/spark/commit/0d4bc108f490fa2367a4e0197dfce49b6edc4ddd).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #27980: [WIP][SQL] Rebase
any date-times in conversions to/from Java types
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #27980: [WIP][SQL] Rebase any date-times in conversions to/from Java types
URL: https://github.com/apache/spark/pull/27980#issuecomment-602265046
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/24883/
Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on issue #27980: [WIP][SQL] Rebase any
date-times in conversions to/from Java types
Posted by GitBox <gi...@apache.org>.
SparkQA commented on issue #27980: [WIP][SQL] Rebase any date-times in conversions to/from Java types
URL: https://github.com/apache/spark/pull/27980#issuecomment-602228498
**[Test build #120166 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/120166/testReport)** for PR 27980 at commit [`b466cac`](https://github.com/apache/spark/commit/b466cac1aeef90558be03b74ce26c9d81238a98c).
* This patch passes all tests.
* This patch merges cleanly.
* This patch adds no public classes.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] MaxGekk commented on a change in pull request #27980:
[SPARK-31221][SQL] Rebase any date-times in conversions to/from Java types
Posted by GitBox <gi...@apache.org>.
MaxGekk commented on a change in pull request #27980: [SPARK-31221][SQL] Rebase any date-times in conversions to/from Java types
URL: https://github.com/apache/spark/pull/27980#discussion_r396354244
##########
File path: sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/util/DateTimeUtilsSuite.scala
##########
@@ -508,8 +504,8 @@ class DateTimeUtilsSuite extends SparkFunSuite with Matchers with SQLHelper {
test("2016-03-13 03:00:00", "PST", "2016-03-13 10:00:00.0")
test("2016-11-06 00:59:59", "PST", "2016-11-06 07:59:59.0")
// 2016-11-06 01:00:00 PST could be 2016-11-06 08:00:00 UTC or 2016-11-06 09:00:00 UTC
- test("2016-11-06 01:00:00", "PST", "2016-11-06 09:00:00.0")
- test("2016-11-06 01:59:59", "PST", "2016-11-06 09:59:59.0")
+ test("2016-11-06 01:00:00", "PST", "2016-11-06 08:00:00.0")
Review comment:
The following works:
```scala
withDefaultTimeZone(TimeZone.getTimeZone("-08:00")) {
test("2016-11-06 01:00:00", "-08:00", "2016-11-06 09:00:00.0")
test("2016-11-06 01:59:59", "-08:00", "2016-11-06 09:59:59.0")
}
```
@cloud-fan Should I replace `PST` by `-08:00` in the test?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on issue #27980: [WIP][SQL] Rebase any
date-times in conversions to/from Java types
Posted by GitBox <gi...@apache.org>.
SparkQA commented on issue #27980: [WIP][SQL] Rebase any date-times in conversions to/from Java types
URL: https://github.com/apache/spark/pull/27980#issuecomment-602303622
**[Test build #120170 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/120170/testReport)** for PR 27980 at commit [`db89c92`](https://github.com/apache/spark/commit/db89c92257370c77b165e7d5afc1dcf035f4dfd2).
* This patch passes all tests.
* This patch merges cleanly.
* This patch adds no public classes.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] MaxGekk commented on a change in pull request #27980:
[WIP][SQL] Rebase any date-times in conversions to/from Java types
Posted by GitBox <gi...@apache.org>.
MaxGekk commented on a change in pull request #27980: [WIP][SQL] Rebase any date-times in conversions to/from Java types
URL: https://github.com/apache/spark/pull/27980#discussion_r396128163
##########
File path: sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/util/DateTimeUtilsSuite.scala
##########
@@ -508,8 +504,8 @@ class DateTimeUtilsSuite extends SparkFunSuite with Matchers with SQLHelper {
test("2016-03-13 03:00:00", "PST", "2016-03-13 10:00:00.0")
test("2016-11-06 00:59:59", "PST", "2016-11-06 07:59:59.0")
// 2016-11-06 01:00:00 PST could be 2016-11-06 08:00:00 UTC or 2016-11-06 09:00:00 UTC
- test("2016-11-06 01:00:00", "PST", "2016-11-06 09:00:00.0")
- test("2016-11-06 01:59:59", "PST", "2016-11-06 09:59:59.0")
+ test("2016-11-06 01:00:00", "PST", "2016-11-06 08:00:00.0")
Review comment:
See the comment above. `08` or `09` depends on the implementation.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] MaxGekk commented on a change in pull request #27980:
[SPARK-31221][SQL] Rebase any date-times in conversions to/from Java types
Posted by GitBox <gi...@apache.org>.
MaxGekk commented on a change in pull request #27980: [SPARK-31221][SQL] Rebase any date-times in conversions to/from Java types
URL: https://github.com/apache/spark/pull/27980#discussion_r396897288
##########
File path: sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/util/DateTimeUtilsSuite.scala
##########
@@ -508,8 +504,8 @@ class DateTimeUtilsSuite extends SparkFunSuite with Matchers with SQLHelper {
test("2016-03-13 03:00:00", "PST", "2016-03-13 10:00:00.0")
test("2016-11-06 00:59:59", "PST", "2016-11-06 07:59:59.0")
// 2016-11-06 01:00:00 PST could be 2016-11-06 08:00:00 UTC or 2016-11-06 09:00:00 UTC
- test("2016-11-06 01:00:00", "PST", "2016-11-06 09:00:00.0")
- test("2016-11-06 01:59:59", "PST", "2016-11-06 09:59:59.0")
+ test("2016-11-06 01:00:00", "PST", "2016-11-06 08:00:00.0")
Review comment:
done
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #27980: [WIP][SQL] Rebase
any date-times in conversions to/from Java types
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #27980: [WIP][SQL] Rebase any date-times in conversions to/from Java types
URL: https://github.com/apache/spark/pull/27980#issuecomment-602250806
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/24882/
Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #27980: [SPARK-31221][SQL]
Rebase any date-times in conversions to/from Java types
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #27980: [SPARK-31221][SQL] Rebase any date-times in conversions to/from Java types
URL: https://github.com/apache/spark/pull/27980#issuecomment-602532951
Merged build finished. Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #27980:
[SPARK-31221][SQL] Rebase any date-times in conversions to/from Java types
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #27980: [SPARK-31221][SQL] Rebase any date-times in conversions to/from Java types
URL: https://github.com/apache/spark/pull/27980#issuecomment-603219806
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/120251/
Test FAILed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] MaxGekk commented on a change in pull request #27980:
[WIP][SQL] Rebase any date-times in conversions to/from Java types
Posted by GitBox <gi...@apache.org>.
MaxGekk commented on a change in pull request #27980: [WIP][SQL] Rebase any date-times in conversions to/from Java types
URL: https://github.com/apache/spark/pull/27980#discussion_r396135057
##########
File path: sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/util/DateTimeUtilsSuite.scala
##########
@@ -88,13 +88,9 @@ class DateTimeUtilsSuite extends SparkFunSuite with Matchers with SQLHelper {
}
test("SPARK-6785: java date conversion before and after epoch") {
- def format(d: Date): String = {
- TimestampFormatter("yyyy-MM-dd", defaultTimeZone().toZoneId)
- .format(millisToMicros(d.getTime))
- }
def checkFromToJavaDate(d1: Date): Unit = {
val d2 = toJavaDate(fromJavaDate(d1))
- assert(format(d2) === format(d1))
+ assert(d2.toString === d1.toString)
Review comment:
Here, I restored the code of Spark 2.4: https://github.com/apache/spark/blob/branch-2.4/sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/util/DateTimeUtilsSuite.scala#L88
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #27980: [SPARK-31221][SQL]
Rebase any date-times in conversions to/from Java types
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #27980: [SPARK-31221][SQL] Rebase any date-times in conversions to/from Java types
URL: https://github.com/apache/spark/pull/27980#issuecomment-603077363
Merged build finished. Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #27980:
[SPARK-31221][SQL] Rebase any date-times in conversions to/from Java types
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #27980: [SPARK-31221][SQL] Rebase any date-times in conversions to/from Java types
URL: https://github.com/apache/spark/pull/27980#issuecomment-602532951
Merged build finished. Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] MaxGekk commented on a change in pull request #27980:
[WIP][SQL] Rebase any date-times in conversions to/from Java types
Posted by GitBox <gi...@apache.org>.
MaxGekk commented on a change in pull request #27980: [WIP][SQL] Rebase any date-times in conversions to/from Java types
URL: https://github.com/apache/spark/pull/27980#discussion_r396128065
##########
File path: sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/expressions/CollectionExpressionsSuite.scala
##########
@@ -856,23 +858,23 @@ class CollectionExpressionsSuite extends SparkFunSuite with ExpressionEvalHelper
Literal(Timestamp.valueOf("2018-03-25 03:30:00")),
Literal(stringToInterval("interval 30 minutes"))),
Seq(
- Timestamp.valueOf("2018-03-25 01:30:00"),
- Timestamp.valueOf("2018-03-25 03:00:00"),
- Timestamp.valueOf("2018-03-25 03:30:00")))
+ ts("2018-03-25 01:30:00"),
+ ts("2018-03-25 03:00:00"),
+ ts("2018-03-25 03:30:00")))
// Autumn time change
checkEvaluation(new Sequence(
Literal(Timestamp.valueOf("2018-10-28 01:30:00")),
Literal(Timestamp.valueOf("2018-10-28 03:30:00")),
Literal(stringToInterval("interval 30 minutes"))),
Seq(
- Timestamp.valueOf("2018-10-28 01:30:00"),
- noDST(Timestamp.valueOf("2018-10-28 02:00:00")),
- noDST(Timestamp.valueOf("2018-10-28 02:30:00")),
- Timestamp.valueOf("2018-10-28 02:00:00"),
- Timestamp.valueOf("2018-10-28 02:30:00"),
- Timestamp.valueOf("2018-10-28 03:00:00"),
- Timestamp.valueOf("2018-10-28 03:30:00")))
+ ts("2018-10-28 01:30:00"),
+ ts("2018-10-28 02:00:00", noDST = true),
Review comment:
I had to change the test because of the 2 lines. I wasn't able to build 2 timestamps via `Timestamp.valueOf` after rebasing. `Timestamp` class does normalization underneath, and replaces milliseconds since the epoch, and as a consequence of that checking of the results fails. Even textual representation, and `year`, `month`, ... `nanos` are the same.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] cloud-fan commented on a change in pull request #27980:
[SPARK-31221][SQL] Rebase any date-times in conversions to/from Java types
Posted by GitBox <gi...@apache.org>.
cloud-fan commented on a change in pull request #27980: [SPARK-31221][SQL] Rebase any date-times in conversions to/from Java types
URL: https://github.com/apache/spark/pull/27980#discussion_r396243630
##########
File path: sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/util/DateTimeUtilsSuite.scala
##########
@@ -508,8 +504,8 @@ class DateTimeUtilsSuite extends SparkFunSuite with Matchers with SQLHelper {
test("2016-03-13 03:00:00", "PST", "2016-03-13 10:00:00.0")
test("2016-11-06 00:59:59", "PST", "2016-11-06 07:59:59.0")
// 2016-11-06 01:00:00 PST could be 2016-11-06 08:00:00 UTC or 2016-11-06 09:00:00 UTC
- test("2016-11-06 01:00:00", "PST", "2016-11-06 09:00:00.0")
- test("2016-11-06 01:59:59", "PST", "2016-11-06 09:59:59.0")
+ test("2016-11-06 01:00:00", "PST", "2016-11-06 08:00:00.0")
Review comment:
This is my only concern.
From what I know, Pacific Standard Time (PST) is UTC-8:00, and Pacific Daylight Time (PDT) is UTC-7:00. So `2016-11-06 09:00:00 UTC` is the only corrected answer.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #27980: [WIP][SQL] Rebase
any date-times in conversions to/from Java types
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #27980: [WIP][SQL] Rebase any date-times in conversions to/from Java types
URL: https://github.com/apache/spark/pull/27980#issuecomment-602303893
Merged build finished. Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on issue #27980: [SPARK-31221][SQL]
Rebase any date-times in conversions to/from Java types
Posted by GitBox <gi...@apache.org>.
SparkQA commented on issue #27980: [SPARK-31221][SQL] Rebase any date-times in conversions to/from Java types
URL: https://github.com/apache/spark/pull/27980#issuecomment-603218846
**[Test build #120251 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/120251/testReport)** for PR 27980 at commit [`46b6613`](https://github.com/apache/spark/commit/46b6613e4025f91487ce58e09cf0a1bccb17897e).
* This patch **fails PySpark pip packaging tests**.
* This patch merges cleanly.
* This patch adds no public classes.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org