[GitHub] [qpid-dispatch] kgiusti commented on a change in pull request #717: DISPATCH-975: Enforce max message size on message ingress

[GitBox <gi...@apache.org>]

kgiusti commented on a change in pull request #717: DISPATCH-975: Enforce max message size on message ingress
URL: https://github.com/apache/qpid-dispatch/pull/717#discussion_r408370278
 
 

 ##########
 File path: src/amqp.c
 ##########
 @@ -86,6 +86,7 @@ const char * const QD_AMQP_COND_RESOURCE_DELETED = "amqp:resource-deleted";
 const char * const QD_AMQP_COND_ILLEGAL_STATE = "amqp:illegal-state";
 const char * const QD_AMQP_COND_FRAME_SIZE_TOO_SMALL = "amqp:frame-size-too-small";
 const char * const QD_AMQP_COND_CONNECTION_FORCED = "amqp:connection:forced";
+const char * const QD_AMQP_COND_MESSAGE_SIZE_EXCEEDED = "amqp:connection:message-size-exceeded";
 
 Review comment:
   Not sure if this matters, but AMQP 1.0 defines a link-error for message-size-exceeded, not a connection-error:
   
   [AMQP 1.0 link-error](http://docs.oasis-open.org/amqp/core/v1.0/os/amqp-core-transport-v1.0-os.html#type-link-error)

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@qpid.apache.org
For additional commands, e-mail: dev-help@qpid.apache.org