You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@guacamole.apache.org by GitBox <gi...@apache.org> on 2021/04/01 19:11:45 UTC

[GitHub] [guacamole-client] mike-jumper commented on a change in pull request #600: GUACAMOLE-1298: Correct mismatched dependencies from migration to Jersey 2.x.

mike-jumper commented on a change in pull request #600:
URL: https://github.com/apache/guacamole-client/pull/600#discussion_r605886675



##########
File path: extensions/guacamole-auth-duo/src/main/java/org/apache/guacamole/auth/duo/form/DuoSignedResponseField.java
##########
@@ -81,8 +80,7 @@ public DuoSignedResponseField(String apiHost, String signedRequest) {
      * @return
      *     The hostname of the DuoWeb API endpoint.
      */
-    @JsonProperty("apiHost")
-    public String getAPIHost() {
+    public String getApiHost() {

Review comment:
       Nope - there aren't any such calls. This method serves only to expose data for serialization into JSON by Jackson. Renaming the function in this case allows the JSON property to be `apiHost` without requiring a Jackson-specific annotation to force that name.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org