You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2020/11/06 05:23:21 UTC
[GitHub] [spark] gengliangwang opened a new pull request #30273: [SPARK-33369][SQL] Skip schema inference in DataframeWriter.save() if table provider supports external metadata
gengliangwang opened a new pull request #30273:
URL: https://github.com/apache/spark/pull/30273
<!--
Thanks for sending a pull request! Here are some tips for you:
1. If this is your first time, please read our contributor guidelines: https://spark.apache.org/contributing.html
2. Ensure you have added or run the appropriate tests for your PR: https://spark.apache.org/developer-tools.html
3. If the PR is unfinished, add '[WIP]' in your PR title, e.g., '[WIP][SPARK-XXXX] Your PR title ...'.
4. Be sure to keep the PR description updated to reflect all changes.
5. Please write your PR title to summarize what this PR proposes.
6. If possible, provide a concise example to reproduce the issue for a faster review.
7. If you want to add a new configuration, please read the guideline first for naming configurations in
'core/src/main/scala/org/apache/spark/internal/config/ConfigEntry.scala'.
-->
### What changes were proposed in this pull request?
<!--
Please clarify what changes you are proposing. The purpose of this section is to outline the changes and how this PR fixes the issue.
If possible, please consider writing useful notes for better and faster reviews in your PR. See the examples below.
1. If you refactor some codes with changing classes, showing the class hierarchy will help reviewers.
2. If you fix some SQL features, you can provide some references of other DBMSes.
3. If there is design documentation, please add the link.
4. If there is a discussion in the mailing list, please add the link.
-->
When TableProvider.supportsExternalMetadata() is true, Spark will use the input Dataframe's schema in `DataframeWriter.save()` and skip schema/partitioning inference.
### Why are the changes needed?
<!--
Please clarify why the changes are needed. For instance,
1. If you propose a new API, clarify the use case for a new API.
2. If you fix a bug, you can clarify why it is a bug.
-->
For all the v2 data sources which are not FileDataSourceV2, Spark always infers the table schema/partitioning on `DataframeWriter.save()`.
The inference of table schema/partitioning can be expensive. However, there is no such trait or flag for indicating a V2 source can use the input DataFrame's schema on `DataframeWriter.save()`. We can resolve the problem by adding a new expected behavior for the method `TableProvider.supportsExternalMetadata()`.
### Does this PR introduce _any_ user-facing change?
<!--
Note that it means *any* user-facing change including all aspects such as the documentation fix.
If yes, please clarify the previous behavior and the change this PR proposes - provide the console output, description and/or an example to show the behavior difference if possible.
If possible, please also clarify if this is a user-facing change compared to the released Spark versions or within the unreleased branches such as master.
If no, write 'No'.
-->
Yes, a new behavior for the data source v2 API `TableProvider.supportsExternalMetadata()` when it returns true.
### How was this patch tested?
<!--
If tests were added, say they were added here. Please make sure to add some test cases that check the changes thoroughly including negative and positive cases if possible.
If it was tested in a way different from regular unit tests, please clarify how you tested step by step, ideally copy and paste-able, so that other reviewers can test and check, and descendants can verify in the future.
If tests were not added, please describe why they were not added and/or why it was difficult to add.
-->
Unit test
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] cloud-fan commented on a change in pull request #30273: [SPARK-33369][SQL] Skip schema inference in DataframeWriter.save() if table provider supports external metadata
Posted by GitBox <gi...@apache.org>.
cloud-fan commented on a change in pull request #30273:
URL: https://github.com/apache/spark/pull/30273#discussion_r519921569
##########
File path: sql/core/src/test/scala/org/apache/spark/sql/streaming/sources/StreamingDataSourceV2Suite.scala
##########
@@ -195,6 +196,31 @@ class FakeNoWrite extends DataSourceRegister with SimpleTableProvider {
}
}
+class FakeWriteSupportingExternalMetadata
+ extends DataSourceRegister
+ with TableProvider {
+ override def shortName(): String = "fake-write-supporting-external-metadata"
+
+ override def supportsExternalMetadata(): Boolean = true
+
+ override def inferSchema(options: CaseInsensitiveStringMap): StructType = {
+ throw new IllegalArgumentException(
+ "Data stream writer should not require inferring table schema the data source supports" +
+ " external Metadata.")
+ }
+
+ override def getTable(
+ tableSchema: StructType,
+ partitioning: Array[Transform],
+ properties: util.Map[String, String]): Table = {
+ LastWriteOptions.options = new CaseInsensitiveStringMap(properties)
Review comment:
We don't check it. I think we can remove this line.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #30273: [SPARK-33369][SQL] Skip schema inference in DataframeWriter.save() if table provider supports external metadata
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #30273:
URL: https://github.com/apache/spark/pull/30273#issuecomment-722938833
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #30273: [SPARK-33369][SQL] Skip schema inference in DataframeWriter.save() if table provider supports external metadata
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #30273:
URL: https://github.com/apache/spark/pull/30273#issuecomment-722938519
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #30273: [SPARK-33369][SQL] DSV2: Skip schema inference in write if table provider supports external metadata
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #30273:
URL: https://github.com/apache/spark/pull/30273#issuecomment-724158957
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #30273: [SPARK-33369][SQL] DSV2: Skip schema inference in write if table provider supports external metadata
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #30273:
URL: https://github.com/apache/spark/pull/30273#issuecomment-724141647
Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/35407/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #30273: [SPARK-33369][SQL] Skip schema inference in DataframeWriter.save() if table provider supports external metadata
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #30273:
URL: https://github.com/apache/spark/pull/30273#issuecomment-722840722
**[Test build #130690 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/130690/testReport)** for PR 30273 at commit [`72db8df`](https://github.com/apache/spark/commit/72db8df343e99fd2d87bb197b5ea1ab27fba2815).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] gengliangwang commented on a change in pull request #30273: [SPARK-33369][SQL] Skip schema inference in DataframeWriter.save() if table provider supports external metadata
Posted by GitBox <gi...@apache.org>.
gengliangwang commented on a change in pull request #30273:
URL: https://github.com/apache/spark/pull/30273#discussion_r519891333
##########
File path: sql/core/src/main/scala/org/apache/spark/sql/DataFrameWriter.scala
##########
@@ -325,11 +325,12 @@ final class DataFrameWriter[T] private[sql](ds: Dataset[T]) {
val dsOptions = new CaseInsensitiveStringMap(finalOptions.asJava)
def getTable: Table = {
- // For file source, it's expensive to infer schema/partition at each write. Here we pass
- // the schema of input query and the user-specified partitioning to `getTable`. If the
+ // If the source accepts external table metadata, here we pass the schema of input query
+ // and the user-specified partitioning to `getTable`. This is for avoiding
+ // schema/partitioning inference, which can be very expensive. If the
// query schema is not compatible with the existing data, the write can still success but
Review comment:
+1, thanks
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #30273: [SPARK-33369][SQL] DSV2: Skip schema inference in write if table provider supports external metadata
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #30273:
URL: https://github.com/apache/spark/pull/30273#issuecomment-724158957
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #30273: [SPARK-33369][SQL] Skip schema inference in DataframeWriter.save() if table provider supports external metadata
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #30273:
URL: https://github.com/apache/spark/pull/30273#issuecomment-722906405
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #30273: [SPARK-33369][SQL] DSV2: Skip schema inference in write if table provider supports external metadata
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #30273:
URL: https://github.com/apache/spark/pull/30273#issuecomment-724124309
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #30273: [SPARK-33369][SQL] DSV2: Skip schema inference in write if table provider supports external metadata
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #30273:
URL: https://github.com/apache/spark/pull/30273#issuecomment-724124309
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #30273: [SPARK-33369][SQL] Skip schema inference in DataframeWriter.save() if table provider supports external metadata
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #30273:
URL: https://github.com/apache/spark/pull/30273#issuecomment-722906390
Kubernetes integration test status success
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/35301/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #30273: [SPARK-33369][SQL] Skip schema inference in DataframeWriter.save() if table provider supports external metadata
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #30273:
URL: https://github.com/apache/spark/pull/30273#issuecomment-722880326
Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/35301/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] cloud-fan commented on a change in pull request #30273: [SPARK-33369][SQL] Skip schema inference in DataframeWriter.save() if table provider supports external metadata
Posted by GitBox <gi...@apache.org>.
cloud-fan commented on a change in pull request #30273:
URL: https://github.com/apache/spark/pull/30273#discussion_r518533903
##########
File path: sql/core/src/main/scala/org/apache/spark/sql/DataFrameWriter.scala
##########
@@ -325,11 +325,12 @@ final class DataFrameWriter[T] private[sql](ds: Dataset[T]) {
val dsOptions = new CaseInsensitiveStringMap(finalOptions.asJava)
def getTable: Table = {
- // For file source, it's expensive to infer schema/partition at each write. Here we pass
- // the schema of input query and the user-specified partitioning to `getTable`. If the
+ // If the source accepts external table metadata, here we pass the schema of input query
+ // and the user-specified partitioning to `getTable`. This is for avoiding
+ // schema/partitioning inference, which can be very expensive. If the
// query schema is not compatible with the existing data, the write can still success but
Review comment:
This is only true for file source. How about
```
If the query schema is not compatible with the existing data, the behavior is undefined.
For example, file source write will success but following reads would fail.
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #30273: [SPARK-33369][SQL] Skip schema inference in DataframeWriter.save() if table provider supports external metadata
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #30273:
URL: https://github.com/apache/spark/pull/30273#issuecomment-722938833
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] gengliangwang commented on a change in pull request #30273: [SPARK-33369][SQL] Skip schema inference in DataframeWriter.save() if table provider supports external metadata
Posted by GitBox <gi...@apache.org>.
gengliangwang commented on a change in pull request #30273:
URL: https://github.com/apache/spark/pull/30273#discussion_r519895339
##########
File path: sql/catalyst/src/main/java/org/apache/spark/sql/connector/catalog/TableProvider.java
##########
@@ -77,8 +77,10 @@
/**
* Returns true if the source has the ability of accepting external table metadata when getting
- * tables. The external table metadata includes user-specified schema from
- * `DataFrameReader`/`DataStreamReader` and schema/partitioning stored in Spark catalog.
+ * tables. The external table metadata includes:
+ * 1. For table reader: user-specified schema from `DataFrameReader`/`DataStreamReader` and
+ * schema/partitioning stored in Spark catalog.
+ * 2. For table writer: the schema of the input `Dataframe` of `DataframeWriter`.
Review comment:
Yes. I have just updated the code
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #30273: [SPARK-33369][SQL] DSV2: Skip schema inference in write if table provider supports external metadata
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #30273:
URL: https://github.com/apache/spark/pull/30273#issuecomment-724124281
Kubernetes integration test status success
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/35403/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #30273: [SPARK-33369][SQL] Skip schema inference in DataframeWriter.save() if table provider supports external metadata
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #30273:
URL: https://github.com/apache/spark/pull/30273#issuecomment-722938985
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/130691/
Test FAILed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #30273: [SPARK-33369][SQL] DSV2: Skip schema inference in write if table provider supports external metadata
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #30273:
URL: https://github.com/apache/spark/pull/30273#issuecomment-724236085
**[Test build #130794 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/130794/testReport)** for PR 30273 at commit [`2053372`](https://github.com/apache/spark/commit/2053372c5ae6fef173948d4cf5dc1f0543b650a3).
* This patch passes all tests.
* This patch merges cleanly.
* This patch adds no public classes.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #30273: [SPARK-33369][SQL] DSV2: Skip schema inference in write if table provider supports external metadata
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #30273:
URL: https://github.com/apache/spark/pull/30273#issuecomment-724237209
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #30273: [SPARK-33369][SQL] DSV2: Skip schema inference in write if table provider supports external metadata
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #30273:
URL: https://github.com/apache/spark/pull/30273#issuecomment-724237209
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] cloud-fan commented on a change in pull request #30273: [SPARK-33369][SQL] Skip schema inference in DataframeWriter.save() if table provider supports external metadata
Posted by GitBox <gi...@apache.org>.
cloud-fan commented on a change in pull request #30273:
URL: https://github.com/apache/spark/pull/30273#discussion_r518534178
##########
File path: sql/catalyst/src/main/java/org/apache/spark/sql/connector/catalog/TableProvider.java
##########
@@ -77,8 +77,10 @@
/**
* Returns true if the source has the ability of accepting external table metadata when getting
- * tables. The external table metadata includes user-specified schema from
- * `DataFrameReader`/`DataStreamReader` and schema/partitioning stored in Spark catalog.
+ * tables. The external table metadata includes:
+ * 1. For table reader: user-specified schema from `DataFrameReader`/`DataStreamReader` and
+ * schema/partitioning stored in Spark catalog.
+ * 2. For table writer: the schema of the input `Dataframe` of `DataframeWriter`.
Review comment:
how about `DataStreamWriter`?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #30273: [SPARK-33369][SQL] DSV2: Skip schema inference in write if table provider supports external metadata
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #30273:
URL: https://github.com/apache/spark/pull/30273#issuecomment-724277878
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #30273: [SPARK-33369][SQL] DSV2: Skip schema inference in write if table provider supports external metadata
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #30273:
URL: https://github.com/apache/spark/pull/30273#issuecomment-724277878
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on pull request #30273: [SPARK-33369][SQL] DSV2: Skip schema inference in write if table provider supports external metadata
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on pull request #30273:
URL: https://github.com/apache/spark/pull/30273#issuecomment-724079771
**[Test build #130794 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/130794/testReport)** for PR 30273 at commit [`2053372`](https://github.com/apache/spark/commit/2053372c5ae6fef173948d4cf5dc1f0543b650a3).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #30273: [SPARK-33369][SQL] DSV2: Skip schema inference in write if table provider supports external metadata
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #30273:
URL: https://github.com/apache/spark/pull/30273#issuecomment-724276771
**[Test build #130798 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/130798/testReport)** for PR 30273 at commit [`1176e82`](https://github.com/apache/spark/commit/1176e828084b1b34fe15880b03aa37e0458647c2).
* This patch passes all tests.
* This patch merges cleanly.
* This patch adds no public classes.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #30273: [SPARK-33369][SQL] DSV2: Skip schema inference in write if table provider supports external metadata
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #30273:
URL: https://github.com/apache/spark/pull/30273#issuecomment-724158933
Kubernetes integration test status success
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/35407/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #30273: [SPARK-33369][SQL] Skip schema inference in DataframeWriter.save() if table provider supports external metadata
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #30273:
URL: https://github.com/apache/spark/pull/30273#issuecomment-722938979
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #30273: [SPARK-33369][SQL] Skip schema inference in DataframeWriter.save() if table provider supports external metadata
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #30273:
URL: https://github.com/apache/spark/pull/30273#issuecomment-722906405
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on pull request #30273: [SPARK-33369][SQL] DSV2: Skip schema inference in write if table provider supports external metadata
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on pull request #30273:
URL: https://github.com/apache/spark/pull/30273#issuecomment-724113422
**[Test build #130798 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/130798/testReport)** for PR 30273 at commit [`1176e82`](https://github.com/apache/spark/commit/1176e828084b1b34fe15880b03aa37e0458647c2).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] cloud-fan commented on pull request #30273: [SPARK-33369][SQL] DSV2: Skip schema inference in write if table provider supports external metadata
Posted by GitBox <gi...@apache.org>.
cloud-fan commented on pull request #30273:
URL: https://github.com/apache/spark/pull/30273#issuecomment-724446704
thanks, merging to master!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #30273: [SPARK-33369][SQL] Skip schema inference in DataframeWriter.save() if table provider supports external metadata
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #30273:
URL: https://github.com/apache/spark/pull/30273#issuecomment-724110550
Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/35403/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #30273: [SPARK-33369][SQL] Skip schema inference in DataframeWriter.save() if table provider supports external metadata
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #30273:
URL: https://github.com/apache/spark/pull/30273#issuecomment-724113422
**[Test build #130798 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/130798/testReport)** for PR 30273 at commit [`1176e82`](https://github.com/apache/spark/commit/1176e828084b1b34fe15880b03aa37e0458647c2).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #30273: [SPARK-33369][SQL] Skip schema inference in DataframeWriter.save() if table provider supports external metadata
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #30273:
URL: https://github.com/apache/spark/pull/30273#issuecomment-724079771
**[Test build #130794 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/130794/testReport)** for PR 30273 at commit [`2053372`](https://github.com/apache/spark/commit/2053372c5ae6fef173948d4cf5dc1f0543b650a3).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #30273: [SPARK-33369][SQL] Skip schema inference in DataframeWriter.save() if table provider supports external metadata
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #30273:
URL: https://github.com/apache/spark/pull/30273#issuecomment-722847633
**[Test build #130691 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/130691/testReport)** for PR 30273 at commit [`073645e`](https://github.com/apache/spark/commit/073645e2b7756d9776118d28e00ada1d937577a0).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on pull request #30273: [SPARK-33369][SQL] Skip schema inference in DataframeWriter.save() if table provider supports external metadata
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on pull request #30273:
URL: https://github.com/apache/spark/pull/30273#issuecomment-722840722
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] cloud-fan closed pull request #30273: [SPARK-33369][SQL] DSV2: Skip schema inference in write if table provider supports external metadata
Posted by GitBox <gi...@apache.org>.
cloud-fan closed pull request #30273:
URL: https://github.com/apache/spark/pull/30273
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org