You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@doris.apache.org by GitBox <gi...@apache.org> on 2022/02/22 05:38:33 UTC

[GitHub] [incubator-doris] wangbo commented on a change in pull request #8186: [vectorization](storage)support seq column in storage layer

wangbo commented on a change in pull request #8186:
URL: https://github.com/apache/incubator-doris/pull/8186#discussion_r811592210



##########
File path: be/src/vec/olap/vgeneric_iterators.cpp
##########
@@ -166,6 +166,15 @@ class VMergeIteratorContext {
         if (cmp_res != 0) {
             return cmp_res > 0;
         }
+        
+        if (_sequence_id_idx != -1) {
+            int col_cmp_res = this->_block.compare_column_at(_index_in_block, rhs._index_in_block, _sequence_id_idx, rhs._block, -1);
+            auto left_col = this->_block.get_by_position(_sequence_id_idx).column;

Review comment:
       👌🏻




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org