You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ranger.apache.org by Andrew Charneski <ac...@gmail.com> on 2019/12/18 16:04:18 UTC
Re: Review Request 71921: Add support for ElasticSearch as an Audit
Database
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/71921/
-----------------------------------------------------------
(Updated Dec. 18, 2019, 4:04 p.m.)
Review request for ranger and Don Bosco Durai.
Repository: ranger
Description (updated)
-------
RANGER-2634 Add support for ElasticSearch as an Audit Database
Diffs
-----
agents-audit/pom.xml 8ac1edf4f
agents-audit/src/main/java/org/apache/ranger/audit/destination/ElasticSearchAuditDestination.java PRE-CREATION
agents-audit/src/main/java/org/apache/ranger/audit/provider/AuditProviderFactory.java 88cf99b6e
hbase-agent/conf/ranger-hbase-audit-changes.cfg 719c7cdbf
hbase-agent/scripts/install.properties f4fdb14ac
hdfs-agent/conf/ranger-hdfs-audit-changes.cfg e34d15451
hdfs-agent/pom.xml 5fe8a41f7
hdfs-agent/scripts/install.properties 54dc3a19e
hive-agent/conf/ranger-hive-audit-changes.cfg 3fd7e14bf
hive-agent/pom.xml fc4c18ed6
hive-agent/scripts/install.properties 3e8f59025
hive-agent/src/main/java/org/apache/ranger/authorization/hive/authorizer/RangerHiveAuditHandler.java a3d575c86
hive-agent/src/test/java/org/apache/ranger/services/hive/HIVERangerAuthorizerTest.java f901f71a3
kms/pom.xml 3bf20fdd4
kms/scripts/install.properties a30b1d3a9
kms/src/main/java/org/apache/hadoop/crypto/key/RangerSafenetKeySecure.java 371e367c1
knox-agent/conf/ranger-knox-audit-changes.cfg f0571e767
knox-agent/scripts/install.properties d2dbbc3fa
migration-util/ambari2.1-hdp2.3-ranger0.50/bin/import_ranger_to_ambari.py e25b8ae89
plugin-atlas/conf/ranger-atlas-audit-changes.cfg 07fc38279
plugin-atlas/conf/ranger-atlas-audit.xml 93ad238df
plugin-atlas/scripts/install.properties 511e6ae32
plugin-elasticsearch/conf/ranger-elasticsearch-audit-changes.cfg 8071e7b46
plugin-elasticsearch/scripts/install.properties 3a5b2132e
plugin-kafka/conf/ranger-kafka-audit-changes.cfg 661b498a2
plugin-kafka/scripts/install.properties 6b01aedcb
plugin-kms/conf/ranger-kms-audit-changes.cfg 69849d6a3
plugin-kylin/conf/ranger-kylin-audit-changes.cfg 8071e7b46
plugin-kylin/scripts/install.properties 126eebad0
plugin-ozone/conf/ranger-ozone-audit-changes.cfg e5adb7681
plugin-ozone/scripts/install.properties 276d192a0
plugin-presto/conf/ranger-presto-audit-changes.cfg 661b498a2
plugin-presto/scripts/install.properties 3110e2d01
plugin-solr/conf/ranger-solr-audit-changes.cfg 622052ed1
plugin-solr/scripts/install.properties 48a9af211
plugin-sqoop/conf/ranger-sqoop-audit-changes.cfg 8071e7b46
plugin-sqoop/scripts/install.properties 44f16dac8
plugin-yarn/conf/ranger-yarn-audit-changes.cfg 8071e7b46
plugin-yarn/scripts/install.properties f776c5f6f
pom.xml 90c395a8d
ranger-elasticsearch-plugin-shim/src/main/java/org/apache/ranger/authorization/elasticsearch/plugin/RangerElasticsearchPlugin.java f9a683706
ranger-hive-plugin-shim/pom.xml c27647034
ranger-util/src/test/LICENSE.txt PRE-CREATION
security-admin/pom.xml fc4a20020
security-admin/scripts/install.properties 155c42ccc
security-admin/scripts/ranger-admin-site-template.xml af345cf43
security-admin/scripts/setup.sh 9677f57b8
security-admin/scripts/upgrade_admin.py 28b7e9884
security-admin/src/main/java/org/apache/ranger/AccessAuditsService.java PRE-CREATION
security-admin/src/main/java/org/apache/ranger/biz/AssetMgr.java 0f4488861
security-admin/src/main/java/org/apache/ranger/biz/RangerBizUtil.java 974fc187e
security-admin/src/main/java/org/apache/ranger/biz/XAuditMgr.java 9eecc20a2
security-admin/src/main/java/org/apache/ranger/common/PropertiesUtil.java ee8ce8dfb
security-admin/src/main/java/org/apache/ranger/elasticsearch/ElasticSearchAccessAuditsService.java PRE-CREATION
security-admin/src/main/java/org/apache/ranger/elasticsearch/ElasticSearchMgr.java PRE-CREATION
security-admin/src/main/java/org/apache/ranger/elasticsearch/ElasticSearchUtil.java PRE-CREATION
security-admin/src/main/java/org/apache/ranger/solr/SolrAccessAuditsService.java b422e7c00
security-admin/src/main/resources/conf.dist/ranger-admin-site.xml 2e584a7a8
security-admin/src/test/java/org/apache/ranger/elasticsearch/ElasticSearchAccessAuditsServiceTest.java PRE-CREATION
security-admin/src/test/resources/log4j.xml 15ae2741c
src/main/assembly/hive-agent.xml 059c6a340
storm-agent/conf/ranger-storm-audit-changes.cfg 8071e7b46
storm-agent/scripts/install.properties e805b75fd
Diff: https://reviews.apache.org/r/71921/diff/1/
Testing
-------
Semi-automated tests write and then read a value from a local ElasticSearch instance. Also set up an admin server and client running hive-plugin and verified audit events were stored and indexed.
Thanks,
Andrew Charneski
Re: Review Request 71921: Add support for ElasticSearch as an Audit
Database
Posted by Velmurugan Periasamy <vp...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/71921/#review219376
-----------------------------------------------------------
kms/src/main/java/org/apache/hadoop/crypto/key/RangerSafenetKeySecure.java
Line 72 (original), 72 (patched)
<https://reviews.apache.org/r/71921/#comment307546>
Is this change required for this feature?
pom.xml
Line 72 (original), 72 (patched)
<https://reviews.apache.org/r/71921/#comment307547>
Is this change required for this patch?
- Velmurugan Periasamy
On Dec. 18, 2019, 4:04 p.m., Andrew Charneski wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/71921/
> -----------------------------------------------------------
>
> (Updated Dec. 18, 2019, 4:04 p.m.)
>
>
> Review request for ranger and Don Bosco Durai.
>
>
> Repository: ranger
>
>
> Description
> -------
>
> RANGER-2634 Add support for ElasticSearch as an Audit Database
>
>
> Diffs
> -----
>
> agents-audit/pom.xml 8ac1edf4f
> agents-audit/src/main/java/org/apache/ranger/audit/destination/ElasticSearchAuditDestination.java PRE-CREATION
> agents-audit/src/main/java/org/apache/ranger/audit/provider/AuditProviderFactory.java 88cf99b6e
> hbase-agent/conf/ranger-hbase-audit-changes.cfg 719c7cdbf
> hbase-agent/scripts/install.properties f4fdb14ac
> hdfs-agent/conf/ranger-hdfs-audit-changes.cfg e34d15451
> hdfs-agent/pom.xml 5fe8a41f7
> hdfs-agent/scripts/install.properties 54dc3a19e
> hive-agent/conf/ranger-hive-audit-changes.cfg 3fd7e14bf
> hive-agent/pom.xml fc4c18ed6
> hive-agent/scripts/install.properties 3e8f59025
> hive-agent/src/main/java/org/apache/ranger/authorization/hive/authorizer/RangerHiveAuditHandler.java a3d575c86
> hive-agent/src/test/java/org/apache/ranger/services/hive/HIVERangerAuthorizerTest.java f901f71a3
> kms/pom.xml 3bf20fdd4
> kms/scripts/install.properties a30b1d3a9
> kms/src/main/java/org/apache/hadoop/crypto/key/RangerSafenetKeySecure.java 371e367c1
> knox-agent/conf/ranger-knox-audit-changes.cfg f0571e767
> knox-agent/scripts/install.properties d2dbbc3fa
> migration-util/ambari2.1-hdp2.3-ranger0.50/bin/import_ranger_to_ambari.py e25b8ae89
> plugin-atlas/conf/ranger-atlas-audit-changes.cfg 07fc38279
> plugin-atlas/conf/ranger-atlas-audit.xml 93ad238df
> plugin-atlas/scripts/install.properties 511e6ae32
> plugin-elasticsearch/conf/ranger-elasticsearch-audit-changes.cfg 8071e7b46
> plugin-elasticsearch/scripts/install.properties 3a5b2132e
> plugin-kafka/conf/ranger-kafka-audit-changes.cfg 661b498a2
> plugin-kafka/scripts/install.properties 6b01aedcb
> plugin-kms/conf/ranger-kms-audit-changes.cfg 69849d6a3
> plugin-kylin/conf/ranger-kylin-audit-changes.cfg 8071e7b46
> plugin-kylin/scripts/install.properties 126eebad0
> plugin-ozone/conf/ranger-ozone-audit-changes.cfg e5adb7681
> plugin-ozone/scripts/install.properties 276d192a0
> plugin-presto/conf/ranger-presto-audit-changes.cfg 661b498a2
> plugin-presto/scripts/install.properties 3110e2d01
> plugin-solr/conf/ranger-solr-audit-changes.cfg 622052ed1
> plugin-solr/scripts/install.properties 48a9af211
> plugin-sqoop/conf/ranger-sqoop-audit-changes.cfg 8071e7b46
> plugin-sqoop/scripts/install.properties 44f16dac8
> plugin-yarn/conf/ranger-yarn-audit-changes.cfg 8071e7b46
> plugin-yarn/scripts/install.properties f776c5f6f
> pom.xml 90c395a8d
> ranger-elasticsearch-plugin-shim/src/main/java/org/apache/ranger/authorization/elasticsearch/plugin/RangerElasticsearchPlugin.java f9a683706
> ranger-hive-plugin-shim/pom.xml c27647034
> ranger-util/src/test/LICENSE.txt PRE-CREATION
> security-admin/pom.xml fc4a20020
> security-admin/scripts/install.properties 155c42ccc
> security-admin/scripts/ranger-admin-site-template.xml af345cf43
> security-admin/scripts/setup.sh 9677f57b8
> security-admin/scripts/upgrade_admin.py 28b7e9884
> security-admin/src/main/java/org/apache/ranger/AccessAuditsService.java PRE-CREATION
> security-admin/src/main/java/org/apache/ranger/biz/AssetMgr.java 0f4488861
> security-admin/src/main/java/org/apache/ranger/biz/RangerBizUtil.java 974fc187e
> security-admin/src/main/java/org/apache/ranger/biz/XAuditMgr.java 9eecc20a2
> security-admin/src/main/java/org/apache/ranger/common/PropertiesUtil.java ee8ce8dfb
> security-admin/src/main/java/org/apache/ranger/elasticsearch/ElasticSearchAccessAuditsService.java PRE-CREATION
> security-admin/src/main/java/org/apache/ranger/elasticsearch/ElasticSearchMgr.java PRE-CREATION
> security-admin/src/main/java/org/apache/ranger/elasticsearch/ElasticSearchUtil.java PRE-CREATION
> security-admin/src/main/java/org/apache/ranger/solr/SolrAccessAuditsService.java b422e7c00
> security-admin/src/main/resources/conf.dist/ranger-admin-site.xml 2e584a7a8
> security-admin/src/test/java/org/apache/ranger/elasticsearch/ElasticSearchAccessAuditsServiceTest.java PRE-CREATION
> security-admin/src/test/resources/log4j.xml 15ae2741c
> src/main/assembly/hive-agent.xml 059c6a340
> storm-agent/conf/ranger-storm-audit-changes.cfg 8071e7b46
> storm-agent/scripts/install.properties e805b75fd
>
>
> Diff: https://reviews.apache.org/r/71921/diff/1/
>
>
> Testing
> -------
>
> Semi-automated tests write and then read a value from a local ElasticSearch instance. Also set up an admin server and client running hive-plugin and verified audit events were stored and indexed.
>
>
> Thanks,
>
> Andrew Charneski
>
>
Re: Review Request 71921: Add support for ElasticSearch as an Audit
Database
Posted by Pradeep Agrawal <pr...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/71921/#review220719
-----------------------------------------------------------
security-admin/src/main/java/org/apache/ranger/solr/SolrAccessAuditsService.java
Line 45 (original), 42 (patched)
<https://reviews.apache.org/r/71921/#comment309393>
remove all unused imports to avoid pmd error
- Pradeep Agrawal
On March 26, 2020, 2:12 a.m., Andrew Charneski wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/71921/
> -----------------------------------------------------------
>
> (Updated March 26, 2020, 2:12 a.m.)
>
>
> Review request for ranger and Don Bosco Durai.
>
>
> Repository: ranger
>
>
> Description
> -------
>
> RANGER-2634 Add support for ElasticSearch as an Audit Database
>
>
> Diffs
> -----
>
> agents-audit/pom.xml 8ac1edf4f65ebd9746f37b17af7906f0e3e4101d
> agents-audit/src/main/java/org/apache/ranger/audit/destination/ElasticSearchAuditDestination.java PRE-CREATION
> agents-audit/src/main/java/org/apache/ranger/audit/provider/AuditProviderFactory.java 88cf99b6e8e9ef5486e8101ea6fdcbdbf7d1d1b3
> hbase-agent/conf/ranger-hbase-audit-changes.cfg 719c7cdbf16799c503d741c2fc582185f875fd02
> hbase-agent/scripts/install.properties f4fdb14ac0e357d5cad2a67c10fe4080fc39f370
> hdfs-agent/conf/ranger-hdfs-audit-changes.cfg e34d15451765d7eabfaa9c4e8a632e2c430be842
> hdfs-agent/scripts/install.properties 54dc3a19ef231e5f64d247e2775e5b7729509359
> hive-agent/conf/ranger-hive-audit-changes.cfg 3fd7e14bff93780e28bf52b97eec0ba26798ca9f
> hive-agent/scripts/install.properties 3e8f59025ae96921b86b450b03c7c11f2472198e
> kms/scripts/install.properties a30b1d3a90783e79810075a577241b2c5e87035d
> knox-agent/conf/ranger-knox-audit-changes.cfg f0571e7671681f94294e9ebd4b9287a75870936c
> knox-agent/scripts/install.properties d2dbbc3fad446f8ca94143b96f986bd8617bcefb
> plugin-atlas/conf/ranger-atlas-audit-changes.cfg 07fc38279878d819bbe7f8024ed7d57c9697cd7e
> plugin-atlas/conf/ranger-atlas-audit.xml 93ad238df6e07ec24d409b389224c45956e3ac0f
> plugin-atlas/scripts/install.properties 511e6ae32afbb41acdae1af6c00f943a56eb267f
> plugin-elasticsearch/conf/ranger-elasticsearch-audit-changes.cfg 8071e7b46b54d9052264540255bf58294a419e8a
> plugin-elasticsearch/scripts/install.properties 3a5b2132ef1f00a0008d3489a5bc18718106c0a2
> plugin-kafka/conf/ranger-kafka-audit-changes.cfg 661b498a24b95b9ba708f83b4b6c08f01c760fbd
> plugin-kafka/scripts/install.properties 6b01aedcb5c8c0090b0bf409285d240b2f713459
> plugin-kms/conf/ranger-kms-audit-changes.cfg 69849d6a3b8213b2ff3e24034f8d680cecbd423e
> plugin-kylin/conf/ranger-kylin-audit-changes.cfg 8071e7b46b54d9052264540255bf58294a419e8a
> plugin-kylin/scripts/install.properties 126eebad0b0718be44f936b677631b18daa8f06b
> plugin-ozone/conf/ranger-ozone-audit-changes.cfg e5adb76819277a1a75dcc6c3b7e6f3c127d49f2e
> plugin-ozone/scripts/install.properties 276d192a0f29db79fbab5c57f51bcc723420a364
> plugin-presto/conf/ranger-presto-audit-changes.cfg 661b498a24b95b9ba708f83b4b6c08f01c760fbd
> plugin-presto/scripts/install.properties 3110e2d015bd69f17fd09fc2d3b6b12b1c40fb1c
> plugin-solr/conf/ranger-solr-audit-changes.cfg 622052ed1ff45e09eb120c4889c7d1b2815f56eb
> plugin-solr/scripts/install.properties 48a9af211baef13e8fe9d0762e505a7e973d4ed9
> plugin-sqoop/conf/ranger-sqoop-audit-changes.cfg 8071e7b46b54d9052264540255bf58294a419e8a
> plugin-sqoop/scripts/install.properties 44f16dac87ad3c9b8f431dcc5713e219422bf3bd
> plugin-yarn/conf/ranger-yarn-audit-changes.cfg 8071e7b46b54d9052264540255bf58294a419e8a
> plugin-yarn/scripts/install.properties f776c5f6fa0e05cd950b854c79a3bfd6982bd602
> pom.xml 22926fd7d04feecf308f84d98c35ce2d084591ef
> ranger-elasticsearch-plugin-shim/src/main/java/org/apache/ranger/authorization/elasticsearch/plugin/RangerElasticsearchPlugin.java f9a683706468269bdc7936bdbcedfc357b5a04e9
> security-admin/scripts/install.properties 155c42ccced826e73696c3c1ff7393fedc0f2159
> security-admin/scripts/ranger-admin-site-template.xml af345cf436e8950af6a178de2f7a0559183d010b
> security-admin/scripts/setup.sh 9677f57b8cde2a0b3512c858f4b625e37234138c
> security-admin/scripts/upgrade_admin.py 28b7e9884907c7e9d4f492bbfda273ac5ec5916a
> security-admin/src/main/java/org/apache/ranger/AccessAuditsService.java PRE-CREATION
> security-admin/src/main/java/org/apache/ranger/biz/AssetMgr.java 17c105f7e332b7f024fa119289edad7774bf89f8
> security-admin/src/main/java/org/apache/ranger/biz/RangerBizUtil.java ebc72cf029ed06d6918fb8439c93a7ae3f49a333
> security-admin/src/main/java/org/apache/ranger/biz/XAuditMgr.java 9eecc20a2a61240912570d96492824268a749f92
> security-admin/src/main/java/org/apache/ranger/elasticsearch/ElasticSearchAccessAuditsService.java PRE-CREATION
> security-admin/src/main/java/org/apache/ranger/elasticsearch/ElasticSearchMgr.java PRE-CREATION
> security-admin/src/main/java/org/apache/ranger/elasticsearch/ElasticSearchUtil.java PRE-CREATION
> security-admin/src/main/java/org/apache/ranger/solr/SolrAccessAuditsService.java 453c7dcc8e05c4cd239bf0d7fb56e47814271524
> security-admin/src/main/resources/conf.dist/ranger-admin-site.xml 298f02b15e5ff990c99b1f46bda49b4d64ddff81
> security-admin/src/test/java/org/apache/ranger/elasticsearch/ElasticSearchAccessAuditsServiceTest.java PRE-CREATION
> storm-agent/conf/ranger-storm-audit-changes.cfg 8071e7b46b54d9052264540255bf58294a419e8a
> storm-agent/scripts/install.properties e805b75fd60fda31f94a96f881bb2f984d923876
>
>
> Diff: https://reviews.apache.org/r/71921/diff/4/
>
>
> Testing
> -------
>
> Semi-automated tests write and then read a value from a local ElasticSearch instance. Also set up an admin server and client running hive-plugin and verified audit events were stored and indexed.
>
>
> Thanks,
>
> Andrew Charneski
>
>
Re: Review Request 71921: Add support for ElasticSearch as an Audit
Database
Posted by Pradeep Agrawal <pr...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/71921/#review220853
-----------------------------------------------------------
Ship it!
Ship It!
- Pradeep Agrawal
On May 22, 2020, 6:47 p.m., Andrew Charneski wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/71921/
> -----------------------------------------------------------
>
> (Updated May 22, 2020, 6:47 p.m.)
>
>
> Review request for ranger and Don Bosco Durai.
>
>
> Repository: ranger
>
>
> Description
> -------
>
> RANGER-2634 Add support for ElasticSearch as an Audit Database
>
>
> Diffs
> -----
>
> agents-audit/pom.xml 8ac1edf4f65ebd9746f37b17af7906f0e3e4101d
> agents-audit/src/main/java/org/apache/ranger/audit/destination/ElasticSearchAuditDestination.java PRE-CREATION
> agents-audit/src/main/java/org/apache/ranger/audit/provider/AuditProviderFactory.java 88cf99b6e8e9ef5486e8101ea6fdcbdbf7d1d1b3
> hbase-agent/conf/ranger-hbase-audit-changes.cfg 719c7cdbf16799c503d741c2fc582185f875fd02
> hbase-agent/conf/ranger-hbase-audit.xml 5f882246e75c21c2fe28d6c6e5fa75e709df7271
> hbase-agent/scripts/install.properties f4fdb14ac0e357d5cad2a67c10fe4080fc39f370
> hdfs-agent/conf/ranger-hdfs-audit-changes.cfg e34d15451765d7eabfaa9c4e8a632e2c430be842
> hdfs-agent/conf/ranger-hdfs-audit.xml a380906524ed7f3951c0a43378af201288267583
> hdfs-agent/scripts/install.properties 54dc3a19ef231e5f64d247e2775e5b7729509359
> hive-agent/conf/ranger-hive-audit-changes.cfg 3fd7e14bff93780e28bf52b97eec0ba26798ca9f
> hive-agent/conf/ranger-hive-audit.xml ae1dce962a1d2cfb23537b6fb7092ac1b9e49403
> hive-agent/scripts/install.properties 3e8f59025ae96921b86b450b03c7c11f2472198e
> kms/scripts/install.properties a30b1d3a90783e79810075a577241b2c5e87035d
> knox-agent/conf/ranger-knox-audit-changes.cfg f0571e7671681f94294e9ebd4b9287a75870936c
> knox-agent/conf/ranger-knox-audit.xml 7b5bfb3294cbf33e9313bcab1816a330bac5b4e2
> knox-agent/scripts/install.properties d2dbbc3fad446f8ca94143b96f986bd8617bcefb
> plugin-atlas/conf/ranger-atlas-audit-changes.cfg 07fc38279878d819bbe7f8024ed7d57c9697cd7e
> plugin-atlas/conf/ranger-atlas-audit.xml 93ad238df6e07ec24d409b389224c45956e3ac0f
> plugin-atlas/scripts/install.properties 511e6ae32afbb41acdae1af6c00f943a56eb267f
> plugin-elasticsearch/conf/ranger-elasticsearch-audit-changes.cfg 8071e7b46b54d9052264540255bf58294a419e8a
> plugin-elasticsearch/conf/ranger-elasticsearch-audit.xml b9bdde57bcae18861cb35858d54ea3c894381bfe
> plugin-elasticsearch/scripts/install.properties 3a5b2132ef1f00a0008d3489a5bc18718106c0a2
> plugin-kafka/conf/ranger-kafka-audit-changes.cfg 661b498a24b95b9ba708f83b4b6c08f01c760fbd
> plugin-kafka/conf/ranger-kafka-audit.xml 5fbbf33c6e9b948170c2c5578108c029bc947424
> plugin-kafka/scripts/install.properties 6b01aedcb5c8c0090b0bf409285d240b2f713459
> plugin-kms/conf/ranger-kms-audit-changes.cfg 69849d6a3b8213b2ff3e24034f8d680cecbd423e
> plugin-kms/conf/ranger-kms-audit.xml 02c1a799ba55e38171da2e68988aee7e37491573
> plugin-kylin/conf/ranger-kylin-audit-changes.cfg 8071e7b46b54d9052264540255bf58294a419e8a
> plugin-kylin/conf/ranger-kylin-audit.xml 94fba58a07a844dd28d3fe68721d17b2fa11c4bc
> plugin-kylin/scripts/install.properties 126eebad0b0718be44f936b677631b18daa8f06b
> plugin-ozone/conf/ranger-ozone-audit-changes.cfg e5adb76819277a1a75dcc6c3b7e6f3c127d49f2e
> plugin-ozone/conf/ranger-ozone-audit.xml 05a18d6bea11c2a0235be0c5bb88a0520edbfc71
> plugin-ozone/scripts/install.properties 276d192a0f29db79fbab5c57f51bcc723420a364
> plugin-presto/conf/ranger-presto-audit-changes.cfg 661b498a24b95b9ba708f83b4b6c08f01c760fbd
> plugin-presto/conf/ranger-presto-audit.xml c72771e995e738a219c1a60e476c7292067b66b5
> plugin-presto/scripts/install.properties 3110e2d015bd69f17fd09fc2d3b6b12b1c40fb1c
> plugin-solr/conf/ranger-solr-audit-changes.cfg 622052ed1ff45e09eb120c4889c7d1b2815f56eb
> plugin-solr/conf/ranger-solr-audit.xml f55b6232aa1d4c5fdf703f9868f306cb01b4bacc
> plugin-solr/scripts/install.properties 48a9af211baef13e8fe9d0762e505a7e973d4ed9
> plugin-sqoop/conf/ranger-sqoop-audit-changes.cfg 8071e7b46b54d9052264540255bf58294a419e8a
> plugin-sqoop/conf/ranger-sqoop-audit.xml 013a84c115163581b32fbd001c33a5fd19ceba87
> plugin-sqoop/scripts/install.properties 44f16dac87ad3c9b8f431dcc5713e219422bf3bd
> plugin-yarn/conf/ranger-yarn-audit-changes.cfg 8071e7b46b54d9052264540255bf58294a419e8a
> plugin-yarn/conf/ranger-yarn-audit.xml 667419daf94038530e59865eee8b45d7f08fcc76
> plugin-yarn/scripts/install.properties f776c5f6fa0e05cd950b854c79a3bfd6982bd602
> pom.xml 0b2e092632ff83008a191d317c8462cb7fab9088
> ranger-elasticsearch-plugin-shim/src/main/java/org/apache/ranger/authorization/elasticsearch/plugin/RangerElasticsearchPlugin.java f9a683706468269bdc7936bdbcedfc357b5a04e9
> security-admin/scripts/install.properties 155c42ccced826e73696c3c1ff7393fedc0f2159
> security-admin/scripts/ranger-admin-site-template.xml af345cf436e8950af6a178de2f7a0559183d010b
> security-admin/scripts/setup.sh 9677f57b8cde2a0b3512c858f4b625e37234138c
> security-admin/scripts/upgrade_admin.py 28b7e9884907c7e9d4f492bbfda273ac5ec5916a
> security-admin/src/main/java/org/apache/ranger/AccessAuditsService.java PRE-CREATION
> security-admin/src/main/java/org/apache/ranger/biz/AssetMgr.java 17c105f7e332b7f024fa119289edad7774bf89f8
> security-admin/src/main/java/org/apache/ranger/biz/RangerBizUtil.java ebc72cf029ed06d6918fb8439c93a7ae3f49a333
> security-admin/src/main/java/org/apache/ranger/biz/XAuditMgr.java 9eecc20a2a61240912570d96492824268a749f92
> security-admin/src/main/java/org/apache/ranger/elasticsearch/ElasticSearchAccessAuditsService.java PRE-CREATION
> security-admin/src/main/java/org/apache/ranger/elasticsearch/ElasticSearchMgr.java PRE-CREATION
> security-admin/src/main/java/org/apache/ranger/elasticsearch/ElasticSearchUtil.java PRE-CREATION
> security-admin/src/main/java/org/apache/ranger/solr/SolrAccessAuditsService.java 453c7dcc8e05c4cd239bf0d7fb56e47814271524
> security-admin/src/main/resources/conf.dist/ranger-admin-site.xml 298f02b15e5ff990c99b1f46bda49b4d64ddff81
> security-admin/src/test/java/org/apache/ranger/elasticsearch/ElasticSearchAccessAuditsServiceTest.java PRE-CREATION
> storm-agent/conf/ranger-storm-audit-changes.cfg 8071e7b46b54d9052264540255bf58294a419e8a
> storm-agent/conf/ranger-storm-audit.xml c0c66d409177c89dfacf41680ea3e3d953c10cc8
> storm-agent/scripts/install.properties e805b75fd60fda31f94a96f881bb2f984d923876
>
>
> Diff: https://reviews.apache.org/r/71921/diff/5/
>
>
> Testing
> -------
>
> Semi-automated tests write and then read a value from a local ElasticSearch instance. Also set up an admin server and client running hive-plugin and verified audit events were stored and indexed.
>
>
> Thanks,
>
> Andrew Charneski
>
>
Re: Review Request 71921: Add support for ElasticSearch as an Audit
Database
Posted by bhavik patel <bh...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/71921/#review220880
-----------------------------------------------------------
Ship it!
Ship It!
- bhavik patel
On May 27, 2020, 12:22 a.m., Andrew Charneski wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/71921/
> -----------------------------------------------------------
>
> (Updated May 27, 2020, 12:22 a.m.)
>
>
> Review request for ranger and Don Bosco Durai.
>
>
> Repository: ranger
>
>
> Description
> -------
>
> RANGER-2634 Add support for ElasticSearch as an Audit Database
>
>
> Diffs
> -----
>
> agents-audit/pom.xml 8ac1edf4f65ebd9746f37b17af7906f0e3e4101d
> agents-audit/src/main/java/org/apache/ranger/audit/destination/ElasticSearchAuditDestination.java PRE-CREATION
> agents-audit/src/main/java/org/apache/ranger/audit/provider/AuditProviderFactory.java 88cf99b6e8e9ef5486e8101ea6fdcbdbf7d1d1b3
> hbase-agent/conf/ranger-hbase-audit-changes.cfg 719c7cdbf16799c503d741c2fc582185f875fd02
> hbase-agent/conf/ranger-hbase-audit.xml 5f882246e75c21c2fe28d6c6e5fa75e709df7271
> hbase-agent/scripts/install.properties f4fdb14ac0e357d5cad2a67c10fe4080fc39f370
> hdfs-agent/conf/ranger-hdfs-audit-changes.cfg e34d15451765d7eabfaa9c4e8a632e2c430be842
> hdfs-agent/conf/ranger-hdfs-audit.xml a380906524ed7f3951c0a43378af201288267583
> hdfs-agent/scripts/install.properties 54dc3a19ef231e5f64d247e2775e5b7729509359
> hive-agent/conf/ranger-hive-audit-changes.cfg 3fd7e14bff93780e28bf52b97eec0ba26798ca9f
> hive-agent/conf/ranger-hive-audit.xml ae1dce962a1d2cfb23537b6fb7092ac1b9e49403
> hive-agent/scripts/install.properties 3e8f59025ae96921b86b450b03c7c11f2472198e
> kms/scripts/install.properties a30b1d3a90783e79810075a577241b2c5e87035d
> knox-agent/conf/ranger-knox-audit-changes.cfg f0571e7671681f94294e9ebd4b9287a75870936c
> knox-agent/conf/ranger-knox-audit.xml 7b5bfb3294cbf33e9313bcab1816a330bac5b4e2
> knox-agent/scripts/install.properties d2dbbc3fad446f8ca94143b96f986bd8617bcefb
> plugin-atlas/conf/ranger-atlas-audit-changes.cfg 07fc38279878d819bbe7f8024ed7d57c9697cd7e
> plugin-atlas/conf/ranger-atlas-audit.xml 93ad238df6e07ec24d409b389224c45956e3ac0f
> plugin-atlas/scripts/install.properties 511e6ae32afbb41acdae1af6c00f943a56eb267f
> plugin-elasticsearch/conf/ranger-elasticsearch-audit-changes.cfg 8071e7b46b54d9052264540255bf58294a419e8a
> plugin-elasticsearch/conf/ranger-elasticsearch-audit.xml b9bdde57bcae18861cb35858d54ea3c894381bfe
> plugin-elasticsearch/scripts/install.properties 3a5b2132ef1f00a0008d3489a5bc18718106c0a2
> plugin-kafka/conf/ranger-kafka-audit-changes.cfg 661b498a24b95b9ba708f83b4b6c08f01c760fbd
> plugin-kafka/conf/ranger-kafka-audit.xml 5fbbf33c6e9b948170c2c5578108c029bc947424
> plugin-kafka/scripts/install.properties 6b01aedcb5c8c0090b0bf409285d240b2f713459
> plugin-kms/conf/ranger-kms-audit-changes.cfg 69849d6a3b8213b2ff3e24034f8d680cecbd423e
> plugin-kms/conf/ranger-kms-audit.xml 02c1a799ba55e38171da2e68988aee7e37491573
> plugin-kylin/conf/ranger-kylin-audit-changes.cfg 8071e7b46b54d9052264540255bf58294a419e8a
> plugin-kylin/conf/ranger-kylin-audit.xml 94fba58a07a844dd28d3fe68721d17b2fa11c4bc
> plugin-kylin/scripts/install.properties 126eebad0b0718be44f936b677631b18daa8f06b
> plugin-ozone/conf/ranger-ozone-audit-changes.cfg e5adb76819277a1a75dcc6c3b7e6f3c127d49f2e
> plugin-ozone/conf/ranger-ozone-audit.xml 05a18d6bea11c2a0235be0c5bb88a0520edbfc71
> plugin-ozone/scripts/install.properties 276d192a0f29db79fbab5c57f51bcc723420a364
> plugin-presto/conf/ranger-presto-audit-changes.cfg 661b498a24b95b9ba708f83b4b6c08f01c760fbd
> plugin-presto/conf/ranger-presto-audit.xml c72771e995e738a219c1a60e476c7292067b66b5
> plugin-presto/scripts/install.properties 3110e2d015bd69f17fd09fc2d3b6b12b1c40fb1c
> plugin-solr/conf/ranger-solr-audit-changes.cfg 622052ed1ff45e09eb120c4889c7d1b2815f56eb
> plugin-solr/conf/ranger-solr-audit.xml f55b6232aa1d4c5fdf703f9868f306cb01b4bacc
> plugin-solr/scripts/install.properties 48a9af211baef13e8fe9d0762e505a7e973d4ed9
> plugin-sqoop/conf/ranger-sqoop-audit-changes.cfg 8071e7b46b54d9052264540255bf58294a419e8a
> plugin-sqoop/conf/ranger-sqoop-audit.xml 013a84c115163581b32fbd001c33a5fd19ceba87
> plugin-sqoop/scripts/install.properties 44f16dac87ad3c9b8f431dcc5713e219422bf3bd
> plugin-yarn/conf/ranger-yarn-audit-changes.cfg 8071e7b46b54d9052264540255bf58294a419e8a
> plugin-yarn/conf/ranger-yarn-audit.xml 667419daf94038530e59865eee8b45d7f08fcc76
> plugin-yarn/scripts/install.properties f776c5f6fa0e05cd950b854c79a3bfd6982bd602
> pom.xml 0b2e092632ff83008a191d317c8462cb7fab9088
> ranger-elasticsearch-plugin-shim/src/main/java/org/apache/ranger/authorization/elasticsearch/plugin/RangerElasticsearchPlugin.java f9a683706468269bdc7936bdbcedfc357b5a04e9
> security-admin/contrib/es_for_audit_setup/README.txt PRE-CREATION
> security-admin/contrib/es_for_audit_setup/create_index.sh PRE-CREATION
> security-admin/contrib/es_for_audit_setup/enable_auth.sh PRE-CREATION
> security-admin/contrib/es_for_audit_setup/install_es.sh PRE-CREATION
> security-admin/scripts/install.properties 155c42ccced826e73696c3c1ff7393fedc0f2159
> security-admin/scripts/ranger-admin-site-template.xml af345cf436e8950af6a178de2f7a0559183d010b
> security-admin/scripts/setup.sh 9677f57b8cde2a0b3512c858f4b625e37234138c
> security-admin/scripts/upgrade_admin.py 28b7e9884907c7e9d4f492bbfda273ac5ec5916a
> security-admin/src/main/java/org/apache/ranger/AccessAuditsService.java PRE-CREATION
> security-admin/src/main/java/org/apache/ranger/biz/AssetMgr.java 17c105f7e332b7f024fa119289edad7774bf89f8
> security-admin/src/main/java/org/apache/ranger/biz/RangerBizUtil.java ebc72cf029ed06d6918fb8439c93a7ae3f49a333
> security-admin/src/main/java/org/apache/ranger/biz/XAuditMgr.java 9eecc20a2a61240912570d96492824268a749f92
> security-admin/src/main/java/org/apache/ranger/elasticsearch/ElasticSearchAccessAuditsService.java PRE-CREATION
> security-admin/src/main/java/org/apache/ranger/elasticsearch/ElasticSearchMgr.java PRE-CREATION
> security-admin/src/main/java/org/apache/ranger/elasticsearch/ElasticSearchUtil.java PRE-CREATION
> security-admin/src/main/java/org/apache/ranger/solr/SolrAccessAuditsService.java 453c7dcc8e05c4cd239bf0d7fb56e47814271524
> security-admin/src/main/resources/conf.dist/ranger-admin-site.xml 298f02b15e5ff990c99b1f46bda49b4d64ddff81
> security-admin/src/test/java/org/apache/ranger/elasticsearch/ElasticSearchAccessAuditsServiceTest.java PRE-CREATION
> storm-agent/conf/ranger-storm-audit-changes.cfg 8071e7b46b54d9052264540255bf58294a419e8a
> storm-agent/conf/ranger-storm-audit.xml c0c66d409177c89dfacf41680ea3e3d953c10cc8
> storm-agent/scripts/install.properties e805b75fd60fda31f94a96f881bb2f984d923876
>
>
> Diff: https://reviews.apache.org/r/71921/diff/6/
>
>
> Testing
> -------
>
> Semi-automated tests write and then read a value from a local ElasticSearch instance. Also set up an admin server and client running hive-plugin and verified audit events were stored and indexed.
>
>
> Thanks,
>
> Andrew Charneski
>
>
Re: Review Request 71921: Add support for ElasticSearch as an Audit
Database
Posted by Andrew Charneski <ac...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/71921/
-----------------------------------------------------------
(Updated May 27, 2020, 12:22 a.m.)
Review request for ranger and Don Bosco Durai.
Changes
-------
Scripts to support Elasticsearch service setup
Repository: ranger
Description
-------
RANGER-2634 Add support for ElasticSearch as an Audit Database
Diffs (updated)
-----
agents-audit/pom.xml 8ac1edf4f65ebd9746f37b17af7906f0e3e4101d
agents-audit/src/main/java/org/apache/ranger/audit/destination/ElasticSearchAuditDestination.java PRE-CREATION
agents-audit/src/main/java/org/apache/ranger/audit/provider/AuditProviderFactory.java 88cf99b6e8e9ef5486e8101ea6fdcbdbf7d1d1b3
hbase-agent/conf/ranger-hbase-audit-changes.cfg 719c7cdbf16799c503d741c2fc582185f875fd02
hbase-agent/conf/ranger-hbase-audit.xml 5f882246e75c21c2fe28d6c6e5fa75e709df7271
hbase-agent/scripts/install.properties f4fdb14ac0e357d5cad2a67c10fe4080fc39f370
hdfs-agent/conf/ranger-hdfs-audit-changes.cfg e34d15451765d7eabfaa9c4e8a632e2c430be842
hdfs-agent/conf/ranger-hdfs-audit.xml a380906524ed7f3951c0a43378af201288267583
hdfs-agent/scripts/install.properties 54dc3a19ef231e5f64d247e2775e5b7729509359
hive-agent/conf/ranger-hive-audit-changes.cfg 3fd7e14bff93780e28bf52b97eec0ba26798ca9f
hive-agent/conf/ranger-hive-audit.xml ae1dce962a1d2cfb23537b6fb7092ac1b9e49403
hive-agent/scripts/install.properties 3e8f59025ae96921b86b450b03c7c11f2472198e
kms/scripts/install.properties a30b1d3a90783e79810075a577241b2c5e87035d
knox-agent/conf/ranger-knox-audit-changes.cfg f0571e7671681f94294e9ebd4b9287a75870936c
knox-agent/conf/ranger-knox-audit.xml 7b5bfb3294cbf33e9313bcab1816a330bac5b4e2
knox-agent/scripts/install.properties d2dbbc3fad446f8ca94143b96f986bd8617bcefb
plugin-atlas/conf/ranger-atlas-audit-changes.cfg 07fc38279878d819bbe7f8024ed7d57c9697cd7e
plugin-atlas/conf/ranger-atlas-audit.xml 93ad238df6e07ec24d409b389224c45956e3ac0f
plugin-atlas/scripts/install.properties 511e6ae32afbb41acdae1af6c00f943a56eb267f
plugin-elasticsearch/conf/ranger-elasticsearch-audit-changes.cfg 8071e7b46b54d9052264540255bf58294a419e8a
plugin-elasticsearch/conf/ranger-elasticsearch-audit.xml b9bdde57bcae18861cb35858d54ea3c894381bfe
plugin-elasticsearch/scripts/install.properties 3a5b2132ef1f00a0008d3489a5bc18718106c0a2
plugin-kafka/conf/ranger-kafka-audit-changes.cfg 661b498a24b95b9ba708f83b4b6c08f01c760fbd
plugin-kafka/conf/ranger-kafka-audit.xml 5fbbf33c6e9b948170c2c5578108c029bc947424
plugin-kafka/scripts/install.properties 6b01aedcb5c8c0090b0bf409285d240b2f713459
plugin-kms/conf/ranger-kms-audit-changes.cfg 69849d6a3b8213b2ff3e24034f8d680cecbd423e
plugin-kms/conf/ranger-kms-audit.xml 02c1a799ba55e38171da2e68988aee7e37491573
plugin-kylin/conf/ranger-kylin-audit-changes.cfg 8071e7b46b54d9052264540255bf58294a419e8a
plugin-kylin/conf/ranger-kylin-audit.xml 94fba58a07a844dd28d3fe68721d17b2fa11c4bc
plugin-kylin/scripts/install.properties 126eebad0b0718be44f936b677631b18daa8f06b
plugin-ozone/conf/ranger-ozone-audit-changes.cfg e5adb76819277a1a75dcc6c3b7e6f3c127d49f2e
plugin-ozone/conf/ranger-ozone-audit.xml 05a18d6bea11c2a0235be0c5bb88a0520edbfc71
plugin-ozone/scripts/install.properties 276d192a0f29db79fbab5c57f51bcc723420a364
plugin-presto/conf/ranger-presto-audit-changes.cfg 661b498a24b95b9ba708f83b4b6c08f01c760fbd
plugin-presto/conf/ranger-presto-audit.xml c72771e995e738a219c1a60e476c7292067b66b5
plugin-presto/scripts/install.properties 3110e2d015bd69f17fd09fc2d3b6b12b1c40fb1c
plugin-solr/conf/ranger-solr-audit-changes.cfg 622052ed1ff45e09eb120c4889c7d1b2815f56eb
plugin-solr/conf/ranger-solr-audit.xml f55b6232aa1d4c5fdf703f9868f306cb01b4bacc
plugin-solr/scripts/install.properties 48a9af211baef13e8fe9d0762e505a7e973d4ed9
plugin-sqoop/conf/ranger-sqoop-audit-changes.cfg 8071e7b46b54d9052264540255bf58294a419e8a
plugin-sqoop/conf/ranger-sqoop-audit.xml 013a84c115163581b32fbd001c33a5fd19ceba87
plugin-sqoop/scripts/install.properties 44f16dac87ad3c9b8f431dcc5713e219422bf3bd
plugin-yarn/conf/ranger-yarn-audit-changes.cfg 8071e7b46b54d9052264540255bf58294a419e8a
plugin-yarn/conf/ranger-yarn-audit.xml 667419daf94038530e59865eee8b45d7f08fcc76
plugin-yarn/scripts/install.properties f776c5f6fa0e05cd950b854c79a3bfd6982bd602
pom.xml 0b2e092632ff83008a191d317c8462cb7fab9088
ranger-elasticsearch-plugin-shim/src/main/java/org/apache/ranger/authorization/elasticsearch/plugin/RangerElasticsearchPlugin.java f9a683706468269bdc7936bdbcedfc357b5a04e9
security-admin/contrib/es_for_audit_setup/README.txt PRE-CREATION
security-admin/contrib/es_for_audit_setup/create_index.sh PRE-CREATION
security-admin/contrib/es_for_audit_setup/enable_auth.sh PRE-CREATION
security-admin/contrib/es_for_audit_setup/install_es.sh PRE-CREATION
security-admin/scripts/install.properties 155c42ccced826e73696c3c1ff7393fedc0f2159
security-admin/scripts/ranger-admin-site-template.xml af345cf436e8950af6a178de2f7a0559183d010b
security-admin/scripts/setup.sh 9677f57b8cde2a0b3512c858f4b625e37234138c
security-admin/scripts/upgrade_admin.py 28b7e9884907c7e9d4f492bbfda273ac5ec5916a
security-admin/src/main/java/org/apache/ranger/AccessAuditsService.java PRE-CREATION
security-admin/src/main/java/org/apache/ranger/biz/AssetMgr.java 17c105f7e332b7f024fa119289edad7774bf89f8
security-admin/src/main/java/org/apache/ranger/biz/RangerBizUtil.java ebc72cf029ed06d6918fb8439c93a7ae3f49a333
security-admin/src/main/java/org/apache/ranger/biz/XAuditMgr.java 9eecc20a2a61240912570d96492824268a749f92
security-admin/src/main/java/org/apache/ranger/elasticsearch/ElasticSearchAccessAuditsService.java PRE-CREATION
security-admin/src/main/java/org/apache/ranger/elasticsearch/ElasticSearchMgr.java PRE-CREATION
security-admin/src/main/java/org/apache/ranger/elasticsearch/ElasticSearchUtil.java PRE-CREATION
security-admin/src/main/java/org/apache/ranger/solr/SolrAccessAuditsService.java 453c7dcc8e05c4cd239bf0d7fb56e47814271524
security-admin/src/main/resources/conf.dist/ranger-admin-site.xml 298f02b15e5ff990c99b1f46bda49b4d64ddff81
security-admin/src/test/java/org/apache/ranger/elasticsearch/ElasticSearchAccessAuditsServiceTest.java PRE-CREATION
storm-agent/conf/ranger-storm-audit-changes.cfg 8071e7b46b54d9052264540255bf58294a419e8a
storm-agent/conf/ranger-storm-audit.xml c0c66d409177c89dfacf41680ea3e3d953c10cc8
storm-agent/scripts/install.properties e805b75fd60fda31f94a96f881bb2f984d923876
Diff: https://reviews.apache.org/r/71921/diff/6/
Changes: https://reviews.apache.org/r/71921/diff/5-6/
Testing
-------
Semi-automated tests write and then read a value from a local ElasticSearch instance. Also set up an admin server and client running hive-plugin and verified audit events were stored and indexed.
Thanks,
Andrew Charneski
Re: Review Request 71921: Add support for ElasticSearch as an Audit
Database
Posted by Andrew Charneski <ac...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/71921/
-----------------------------------------------------------
(Updated May 22, 2020, 6:47 p.m.)
Review request for ranger and Don Bosco Durai.
Changes
-------
Action taken on recent review feedback, also re-tested build and fixed an additional error. Please re-review. Thanks!
Repository: ranger
Description
-------
RANGER-2634 Add support for ElasticSearch as an Audit Database
Diffs (updated)
-----
agents-audit/pom.xml 8ac1edf4f65ebd9746f37b17af7906f0e3e4101d
agents-audit/src/main/java/org/apache/ranger/audit/destination/ElasticSearchAuditDestination.java PRE-CREATION
agents-audit/src/main/java/org/apache/ranger/audit/provider/AuditProviderFactory.java 88cf99b6e8e9ef5486e8101ea6fdcbdbf7d1d1b3
hbase-agent/conf/ranger-hbase-audit-changes.cfg 719c7cdbf16799c503d741c2fc582185f875fd02
hbase-agent/conf/ranger-hbase-audit.xml 5f882246e75c21c2fe28d6c6e5fa75e709df7271
hbase-agent/scripts/install.properties f4fdb14ac0e357d5cad2a67c10fe4080fc39f370
hdfs-agent/conf/ranger-hdfs-audit-changes.cfg e34d15451765d7eabfaa9c4e8a632e2c430be842
hdfs-agent/conf/ranger-hdfs-audit.xml a380906524ed7f3951c0a43378af201288267583
hdfs-agent/scripts/install.properties 54dc3a19ef231e5f64d247e2775e5b7729509359
hive-agent/conf/ranger-hive-audit-changes.cfg 3fd7e14bff93780e28bf52b97eec0ba26798ca9f
hive-agent/conf/ranger-hive-audit.xml ae1dce962a1d2cfb23537b6fb7092ac1b9e49403
hive-agent/scripts/install.properties 3e8f59025ae96921b86b450b03c7c11f2472198e
kms/scripts/install.properties a30b1d3a90783e79810075a577241b2c5e87035d
knox-agent/conf/ranger-knox-audit-changes.cfg f0571e7671681f94294e9ebd4b9287a75870936c
knox-agent/conf/ranger-knox-audit.xml 7b5bfb3294cbf33e9313bcab1816a330bac5b4e2
knox-agent/scripts/install.properties d2dbbc3fad446f8ca94143b96f986bd8617bcefb
plugin-atlas/conf/ranger-atlas-audit-changes.cfg 07fc38279878d819bbe7f8024ed7d57c9697cd7e
plugin-atlas/conf/ranger-atlas-audit.xml 93ad238df6e07ec24d409b389224c45956e3ac0f
plugin-atlas/scripts/install.properties 511e6ae32afbb41acdae1af6c00f943a56eb267f
plugin-elasticsearch/conf/ranger-elasticsearch-audit-changes.cfg 8071e7b46b54d9052264540255bf58294a419e8a
plugin-elasticsearch/conf/ranger-elasticsearch-audit.xml b9bdde57bcae18861cb35858d54ea3c894381bfe
plugin-elasticsearch/scripts/install.properties 3a5b2132ef1f00a0008d3489a5bc18718106c0a2
plugin-kafka/conf/ranger-kafka-audit-changes.cfg 661b498a24b95b9ba708f83b4b6c08f01c760fbd
plugin-kafka/conf/ranger-kafka-audit.xml 5fbbf33c6e9b948170c2c5578108c029bc947424
plugin-kafka/scripts/install.properties 6b01aedcb5c8c0090b0bf409285d240b2f713459
plugin-kms/conf/ranger-kms-audit-changes.cfg 69849d6a3b8213b2ff3e24034f8d680cecbd423e
plugin-kms/conf/ranger-kms-audit.xml 02c1a799ba55e38171da2e68988aee7e37491573
plugin-kylin/conf/ranger-kylin-audit-changes.cfg 8071e7b46b54d9052264540255bf58294a419e8a
plugin-kylin/conf/ranger-kylin-audit.xml 94fba58a07a844dd28d3fe68721d17b2fa11c4bc
plugin-kylin/scripts/install.properties 126eebad0b0718be44f936b677631b18daa8f06b
plugin-ozone/conf/ranger-ozone-audit-changes.cfg e5adb76819277a1a75dcc6c3b7e6f3c127d49f2e
plugin-ozone/conf/ranger-ozone-audit.xml 05a18d6bea11c2a0235be0c5bb88a0520edbfc71
plugin-ozone/scripts/install.properties 276d192a0f29db79fbab5c57f51bcc723420a364
plugin-presto/conf/ranger-presto-audit-changes.cfg 661b498a24b95b9ba708f83b4b6c08f01c760fbd
plugin-presto/conf/ranger-presto-audit.xml c72771e995e738a219c1a60e476c7292067b66b5
plugin-presto/scripts/install.properties 3110e2d015bd69f17fd09fc2d3b6b12b1c40fb1c
plugin-solr/conf/ranger-solr-audit-changes.cfg 622052ed1ff45e09eb120c4889c7d1b2815f56eb
plugin-solr/conf/ranger-solr-audit.xml f55b6232aa1d4c5fdf703f9868f306cb01b4bacc
plugin-solr/scripts/install.properties 48a9af211baef13e8fe9d0762e505a7e973d4ed9
plugin-sqoop/conf/ranger-sqoop-audit-changes.cfg 8071e7b46b54d9052264540255bf58294a419e8a
plugin-sqoop/conf/ranger-sqoop-audit.xml 013a84c115163581b32fbd001c33a5fd19ceba87
plugin-sqoop/scripts/install.properties 44f16dac87ad3c9b8f431dcc5713e219422bf3bd
plugin-yarn/conf/ranger-yarn-audit-changes.cfg 8071e7b46b54d9052264540255bf58294a419e8a
plugin-yarn/conf/ranger-yarn-audit.xml 667419daf94038530e59865eee8b45d7f08fcc76
plugin-yarn/scripts/install.properties f776c5f6fa0e05cd950b854c79a3bfd6982bd602
pom.xml 0b2e092632ff83008a191d317c8462cb7fab9088
ranger-elasticsearch-plugin-shim/src/main/java/org/apache/ranger/authorization/elasticsearch/plugin/RangerElasticsearchPlugin.java f9a683706468269bdc7936bdbcedfc357b5a04e9
security-admin/scripts/install.properties 155c42ccced826e73696c3c1ff7393fedc0f2159
security-admin/scripts/ranger-admin-site-template.xml af345cf436e8950af6a178de2f7a0559183d010b
security-admin/scripts/setup.sh 9677f57b8cde2a0b3512c858f4b625e37234138c
security-admin/scripts/upgrade_admin.py 28b7e9884907c7e9d4f492bbfda273ac5ec5916a
security-admin/src/main/java/org/apache/ranger/AccessAuditsService.java PRE-CREATION
security-admin/src/main/java/org/apache/ranger/biz/AssetMgr.java 17c105f7e332b7f024fa119289edad7774bf89f8
security-admin/src/main/java/org/apache/ranger/biz/RangerBizUtil.java ebc72cf029ed06d6918fb8439c93a7ae3f49a333
security-admin/src/main/java/org/apache/ranger/biz/XAuditMgr.java 9eecc20a2a61240912570d96492824268a749f92
security-admin/src/main/java/org/apache/ranger/elasticsearch/ElasticSearchAccessAuditsService.java PRE-CREATION
security-admin/src/main/java/org/apache/ranger/elasticsearch/ElasticSearchMgr.java PRE-CREATION
security-admin/src/main/java/org/apache/ranger/elasticsearch/ElasticSearchUtil.java PRE-CREATION
security-admin/src/main/java/org/apache/ranger/solr/SolrAccessAuditsService.java 453c7dcc8e05c4cd239bf0d7fb56e47814271524
security-admin/src/main/resources/conf.dist/ranger-admin-site.xml 298f02b15e5ff990c99b1f46bda49b4d64ddff81
security-admin/src/test/java/org/apache/ranger/elasticsearch/ElasticSearchAccessAuditsServiceTest.java PRE-CREATION
storm-agent/conf/ranger-storm-audit-changes.cfg 8071e7b46b54d9052264540255bf58294a419e8a
storm-agent/conf/ranger-storm-audit.xml c0c66d409177c89dfacf41680ea3e3d953c10cc8
storm-agent/scripts/install.properties e805b75fd60fda31f94a96f881bb2f984d923876
Diff: https://reviews.apache.org/r/71921/diff/5/
Changes: https://reviews.apache.org/r/71921/diff/4-5/
Testing
-------
Semi-automated tests write and then read a value from a local ElasticSearch instance. Also set up an admin server and client running hive-plugin and verified audit events were stored and indexed.
Thanks,
Andrew Charneski
Re: Review Request 71921: Add support for ElasticSearch as an Audit
Database
Posted by Andrew Charneski <ac...@gmail.com>.
> On May 5, 2020, 9:06 a.m., Pradeep Agrawal wrote:
> > pom.xml
> > Lines 137 (patched)
> > <https://reviews.apache.org/r/71921/diff/4/?file=2215447#file2215447line137>
> >
> > Any specific reason to change httpmime version from 4.5.6 to 4.5.3 ?
I chose the version based on date. I've updated to 4.5.6.
- Andrew
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/71921/#review220629
-----------------------------------------------------------
On May 22, 2020, 6:47 p.m., Andrew Charneski wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/71921/
> -----------------------------------------------------------
>
> (Updated May 22, 2020, 6:47 p.m.)
>
>
> Review request for ranger and Don Bosco Durai.
>
>
> Repository: ranger
>
>
> Description
> -------
>
> RANGER-2634 Add support for ElasticSearch as an Audit Database
>
>
> Diffs
> -----
>
> agents-audit/pom.xml 8ac1edf4f65ebd9746f37b17af7906f0e3e4101d
> agents-audit/src/main/java/org/apache/ranger/audit/destination/ElasticSearchAuditDestination.java PRE-CREATION
> agents-audit/src/main/java/org/apache/ranger/audit/provider/AuditProviderFactory.java 88cf99b6e8e9ef5486e8101ea6fdcbdbf7d1d1b3
> hbase-agent/conf/ranger-hbase-audit-changes.cfg 719c7cdbf16799c503d741c2fc582185f875fd02
> hbase-agent/conf/ranger-hbase-audit.xml 5f882246e75c21c2fe28d6c6e5fa75e709df7271
> hbase-agent/scripts/install.properties f4fdb14ac0e357d5cad2a67c10fe4080fc39f370
> hdfs-agent/conf/ranger-hdfs-audit-changes.cfg e34d15451765d7eabfaa9c4e8a632e2c430be842
> hdfs-agent/conf/ranger-hdfs-audit.xml a380906524ed7f3951c0a43378af201288267583
> hdfs-agent/scripts/install.properties 54dc3a19ef231e5f64d247e2775e5b7729509359
> hive-agent/conf/ranger-hive-audit-changes.cfg 3fd7e14bff93780e28bf52b97eec0ba26798ca9f
> hive-agent/conf/ranger-hive-audit.xml ae1dce962a1d2cfb23537b6fb7092ac1b9e49403
> hive-agent/scripts/install.properties 3e8f59025ae96921b86b450b03c7c11f2472198e
> kms/scripts/install.properties a30b1d3a90783e79810075a577241b2c5e87035d
> knox-agent/conf/ranger-knox-audit-changes.cfg f0571e7671681f94294e9ebd4b9287a75870936c
> knox-agent/conf/ranger-knox-audit.xml 7b5bfb3294cbf33e9313bcab1816a330bac5b4e2
> knox-agent/scripts/install.properties d2dbbc3fad446f8ca94143b96f986bd8617bcefb
> plugin-atlas/conf/ranger-atlas-audit-changes.cfg 07fc38279878d819bbe7f8024ed7d57c9697cd7e
> plugin-atlas/conf/ranger-atlas-audit.xml 93ad238df6e07ec24d409b389224c45956e3ac0f
> plugin-atlas/scripts/install.properties 511e6ae32afbb41acdae1af6c00f943a56eb267f
> plugin-elasticsearch/conf/ranger-elasticsearch-audit-changes.cfg 8071e7b46b54d9052264540255bf58294a419e8a
> plugin-elasticsearch/conf/ranger-elasticsearch-audit.xml b9bdde57bcae18861cb35858d54ea3c894381bfe
> plugin-elasticsearch/scripts/install.properties 3a5b2132ef1f00a0008d3489a5bc18718106c0a2
> plugin-kafka/conf/ranger-kafka-audit-changes.cfg 661b498a24b95b9ba708f83b4b6c08f01c760fbd
> plugin-kafka/conf/ranger-kafka-audit.xml 5fbbf33c6e9b948170c2c5578108c029bc947424
> plugin-kafka/scripts/install.properties 6b01aedcb5c8c0090b0bf409285d240b2f713459
> plugin-kms/conf/ranger-kms-audit-changes.cfg 69849d6a3b8213b2ff3e24034f8d680cecbd423e
> plugin-kms/conf/ranger-kms-audit.xml 02c1a799ba55e38171da2e68988aee7e37491573
> plugin-kylin/conf/ranger-kylin-audit-changes.cfg 8071e7b46b54d9052264540255bf58294a419e8a
> plugin-kylin/conf/ranger-kylin-audit.xml 94fba58a07a844dd28d3fe68721d17b2fa11c4bc
> plugin-kylin/scripts/install.properties 126eebad0b0718be44f936b677631b18daa8f06b
> plugin-ozone/conf/ranger-ozone-audit-changes.cfg e5adb76819277a1a75dcc6c3b7e6f3c127d49f2e
> plugin-ozone/conf/ranger-ozone-audit.xml 05a18d6bea11c2a0235be0c5bb88a0520edbfc71
> plugin-ozone/scripts/install.properties 276d192a0f29db79fbab5c57f51bcc723420a364
> plugin-presto/conf/ranger-presto-audit-changes.cfg 661b498a24b95b9ba708f83b4b6c08f01c760fbd
> plugin-presto/conf/ranger-presto-audit.xml c72771e995e738a219c1a60e476c7292067b66b5
> plugin-presto/scripts/install.properties 3110e2d015bd69f17fd09fc2d3b6b12b1c40fb1c
> plugin-solr/conf/ranger-solr-audit-changes.cfg 622052ed1ff45e09eb120c4889c7d1b2815f56eb
> plugin-solr/conf/ranger-solr-audit.xml f55b6232aa1d4c5fdf703f9868f306cb01b4bacc
> plugin-solr/scripts/install.properties 48a9af211baef13e8fe9d0762e505a7e973d4ed9
> plugin-sqoop/conf/ranger-sqoop-audit-changes.cfg 8071e7b46b54d9052264540255bf58294a419e8a
> plugin-sqoop/conf/ranger-sqoop-audit.xml 013a84c115163581b32fbd001c33a5fd19ceba87
> plugin-sqoop/scripts/install.properties 44f16dac87ad3c9b8f431dcc5713e219422bf3bd
> plugin-yarn/conf/ranger-yarn-audit-changes.cfg 8071e7b46b54d9052264540255bf58294a419e8a
> plugin-yarn/conf/ranger-yarn-audit.xml 667419daf94038530e59865eee8b45d7f08fcc76
> plugin-yarn/scripts/install.properties f776c5f6fa0e05cd950b854c79a3bfd6982bd602
> pom.xml 0b2e092632ff83008a191d317c8462cb7fab9088
> ranger-elasticsearch-plugin-shim/src/main/java/org/apache/ranger/authorization/elasticsearch/plugin/RangerElasticsearchPlugin.java f9a683706468269bdc7936bdbcedfc357b5a04e9
> security-admin/scripts/install.properties 155c42ccced826e73696c3c1ff7393fedc0f2159
> security-admin/scripts/ranger-admin-site-template.xml af345cf436e8950af6a178de2f7a0559183d010b
> security-admin/scripts/setup.sh 9677f57b8cde2a0b3512c858f4b625e37234138c
> security-admin/scripts/upgrade_admin.py 28b7e9884907c7e9d4f492bbfda273ac5ec5916a
> security-admin/src/main/java/org/apache/ranger/AccessAuditsService.java PRE-CREATION
> security-admin/src/main/java/org/apache/ranger/biz/AssetMgr.java 17c105f7e332b7f024fa119289edad7774bf89f8
> security-admin/src/main/java/org/apache/ranger/biz/RangerBizUtil.java ebc72cf029ed06d6918fb8439c93a7ae3f49a333
> security-admin/src/main/java/org/apache/ranger/biz/XAuditMgr.java 9eecc20a2a61240912570d96492824268a749f92
> security-admin/src/main/java/org/apache/ranger/elasticsearch/ElasticSearchAccessAuditsService.java PRE-CREATION
> security-admin/src/main/java/org/apache/ranger/elasticsearch/ElasticSearchMgr.java PRE-CREATION
> security-admin/src/main/java/org/apache/ranger/elasticsearch/ElasticSearchUtil.java PRE-CREATION
> security-admin/src/main/java/org/apache/ranger/solr/SolrAccessAuditsService.java 453c7dcc8e05c4cd239bf0d7fb56e47814271524
> security-admin/src/main/resources/conf.dist/ranger-admin-site.xml 298f02b15e5ff990c99b1f46bda49b4d64ddff81
> security-admin/src/test/java/org/apache/ranger/elasticsearch/ElasticSearchAccessAuditsServiceTest.java PRE-CREATION
> storm-agent/conf/ranger-storm-audit-changes.cfg 8071e7b46b54d9052264540255bf58294a419e8a
> storm-agent/conf/ranger-storm-audit.xml c0c66d409177c89dfacf41680ea3e3d953c10cc8
> storm-agent/scripts/install.properties e805b75fd60fda31f94a96f881bb2f984d923876
>
>
> Diff: https://reviews.apache.org/r/71921/diff/5/
>
>
> Testing
> -------
>
> Semi-automated tests write and then read a value from a local ElasticSearch instance. Also set up an admin server and client running hive-plugin and verified audit events were stored and indexed.
>
>
> Thanks,
>
> Andrew Charneski
>
>
Re: Review Request 71921: Add support for ElasticSearch as an Audit
Database
Posted by Pradeep Agrawal <pr...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/71921/#review220629
-----------------------------------------------------------
pom.xml
Lines 137 (patched)
<https://reviews.apache.org/r/71921/#comment309199>
Any specific reason to change httpmime version from 4.5.6 to 4.5.3 ?
- Pradeep Agrawal
On March 26, 2020, 2:12 a.m., Andrew Charneski wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/71921/
> -----------------------------------------------------------
>
> (Updated March 26, 2020, 2:12 a.m.)
>
>
> Review request for ranger and Don Bosco Durai.
>
>
> Repository: ranger
>
>
> Description
> -------
>
> RANGER-2634 Add support for ElasticSearch as an Audit Database
>
>
> Diffs
> -----
>
> agents-audit/pom.xml 8ac1edf4f65ebd9746f37b17af7906f0e3e4101d
> agents-audit/src/main/java/org/apache/ranger/audit/destination/ElasticSearchAuditDestination.java PRE-CREATION
> agents-audit/src/main/java/org/apache/ranger/audit/provider/AuditProviderFactory.java 88cf99b6e8e9ef5486e8101ea6fdcbdbf7d1d1b3
> hbase-agent/conf/ranger-hbase-audit-changes.cfg 719c7cdbf16799c503d741c2fc582185f875fd02
> hbase-agent/scripts/install.properties f4fdb14ac0e357d5cad2a67c10fe4080fc39f370
> hdfs-agent/conf/ranger-hdfs-audit-changes.cfg e34d15451765d7eabfaa9c4e8a632e2c430be842
> hdfs-agent/scripts/install.properties 54dc3a19ef231e5f64d247e2775e5b7729509359
> hive-agent/conf/ranger-hive-audit-changes.cfg 3fd7e14bff93780e28bf52b97eec0ba26798ca9f
> hive-agent/scripts/install.properties 3e8f59025ae96921b86b450b03c7c11f2472198e
> kms/scripts/install.properties a30b1d3a90783e79810075a577241b2c5e87035d
> knox-agent/conf/ranger-knox-audit-changes.cfg f0571e7671681f94294e9ebd4b9287a75870936c
> knox-agent/scripts/install.properties d2dbbc3fad446f8ca94143b96f986bd8617bcefb
> plugin-atlas/conf/ranger-atlas-audit-changes.cfg 07fc38279878d819bbe7f8024ed7d57c9697cd7e
> plugin-atlas/conf/ranger-atlas-audit.xml 93ad238df6e07ec24d409b389224c45956e3ac0f
> plugin-atlas/scripts/install.properties 511e6ae32afbb41acdae1af6c00f943a56eb267f
> plugin-elasticsearch/conf/ranger-elasticsearch-audit-changes.cfg 8071e7b46b54d9052264540255bf58294a419e8a
> plugin-elasticsearch/scripts/install.properties 3a5b2132ef1f00a0008d3489a5bc18718106c0a2
> plugin-kafka/conf/ranger-kafka-audit-changes.cfg 661b498a24b95b9ba708f83b4b6c08f01c760fbd
> plugin-kafka/scripts/install.properties 6b01aedcb5c8c0090b0bf409285d240b2f713459
> plugin-kms/conf/ranger-kms-audit-changes.cfg 69849d6a3b8213b2ff3e24034f8d680cecbd423e
> plugin-kylin/conf/ranger-kylin-audit-changes.cfg 8071e7b46b54d9052264540255bf58294a419e8a
> plugin-kylin/scripts/install.properties 126eebad0b0718be44f936b677631b18daa8f06b
> plugin-ozone/conf/ranger-ozone-audit-changes.cfg e5adb76819277a1a75dcc6c3b7e6f3c127d49f2e
> plugin-ozone/scripts/install.properties 276d192a0f29db79fbab5c57f51bcc723420a364
> plugin-presto/conf/ranger-presto-audit-changes.cfg 661b498a24b95b9ba708f83b4b6c08f01c760fbd
> plugin-presto/scripts/install.properties 3110e2d015bd69f17fd09fc2d3b6b12b1c40fb1c
> plugin-solr/conf/ranger-solr-audit-changes.cfg 622052ed1ff45e09eb120c4889c7d1b2815f56eb
> plugin-solr/scripts/install.properties 48a9af211baef13e8fe9d0762e505a7e973d4ed9
> plugin-sqoop/conf/ranger-sqoop-audit-changes.cfg 8071e7b46b54d9052264540255bf58294a419e8a
> plugin-sqoop/scripts/install.properties 44f16dac87ad3c9b8f431dcc5713e219422bf3bd
> plugin-yarn/conf/ranger-yarn-audit-changes.cfg 8071e7b46b54d9052264540255bf58294a419e8a
> plugin-yarn/scripts/install.properties f776c5f6fa0e05cd950b854c79a3bfd6982bd602
> pom.xml 22926fd7d04feecf308f84d98c35ce2d084591ef
> ranger-elasticsearch-plugin-shim/src/main/java/org/apache/ranger/authorization/elasticsearch/plugin/RangerElasticsearchPlugin.java f9a683706468269bdc7936bdbcedfc357b5a04e9
> security-admin/scripts/install.properties 155c42ccced826e73696c3c1ff7393fedc0f2159
> security-admin/scripts/ranger-admin-site-template.xml af345cf436e8950af6a178de2f7a0559183d010b
> security-admin/scripts/setup.sh 9677f57b8cde2a0b3512c858f4b625e37234138c
> security-admin/scripts/upgrade_admin.py 28b7e9884907c7e9d4f492bbfda273ac5ec5916a
> security-admin/src/main/java/org/apache/ranger/AccessAuditsService.java PRE-CREATION
> security-admin/src/main/java/org/apache/ranger/biz/AssetMgr.java 17c105f7e332b7f024fa119289edad7774bf89f8
> security-admin/src/main/java/org/apache/ranger/biz/RangerBizUtil.java ebc72cf029ed06d6918fb8439c93a7ae3f49a333
> security-admin/src/main/java/org/apache/ranger/biz/XAuditMgr.java 9eecc20a2a61240912570d96492824268a749f92
> security-admin/src/main/java/org/apache/ranger/elasticsearch/ElasticSearchAccessAuditsService.java PRE-CREATION
> security-admin/src/main/java/org/apache/ranger/elasticsearch/ElasticSearchMgr.java PRE-CREATION
> security-admin/src/main/java/org/apache/ranger/elasticsearch/ElasticSearchUtil.java PRE-CREATION
> security-admin/src/main/java/org/apache/ranger/solr/SolrAccessAuditsService.java 453c7dcc8e05c4cd239bf0d7fb56e47814271524
> security-admin/src/main/resources/conf.dist/ranger-admin-site.xml 298f02b15e5ff990c99b1f46bda49b4d64ddff81
> security-admin/src/test/java/org/apache/ranger/elasticsearch/ElasticSearchAccessAuditsServiceTest.java PRE-CREATION
> storm-agent/conf/ranger-storm-audit-changes.cfg 8071e7b46b54d9052264540255bf58294a419e8a
> storm-agent/scripts/install.properties e805b75fd60fda31f94a96f881bb2f984d923876
>
>
> Diff: https://reviews.apache.org/r/71921/diff/4/
>
>
> Testing
> -------
>
> Semi-automated tests write and then read a value from a local ElasticSearch instance. Also set up an admin server and client running hive-plugin and verified audit events were stored and indexed.
>
>
> Thanks,
>
> Andrew Charneski
>
>
Re: Review Request 71921: Add support for ElasticSearch as an Audit
Database
Posted by bhavik patel <bh...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/71921/#review220591
-----------------------------------------------------------
agents-audit/pom.xml
Lines 164 (patched)
<https://reviews.apache.org/r/71921/#comment309067>
please define the version in the parent file.
agents-audit/src/main/java/org/apache/ranger/audit/provider/AuditProviderFactory.java
Lines 57 (patched)
<https://reviews.apache.org/r/71921/#comment309066>
This should be part of the configuration file.
security-admin/src/main/java/org/apache/ranger/elasticsearch/ElasticSearchUtil.java
Lines 277 (patched)
<https://reviews.apache.org/r/71921/#comment309068>
I think this condition can be removed as it will be always false.
- bhavik patel
On March 26, 2020, 2:12 a.m., Andrew Charneski wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/71921/
> -----------------------------------------------------------
>
> (Updated March 26, 2020, 2:12 a.m.)
>
>
> Review request for ranger and Don Bosco Durai.
>
>
> Repository: ranger
>
>
> Description
> -------
>
> RANGER-2634 Add support for ElasticSearch as an Audit Database
>
>
> Diffs
> -----
>
> agents-audit/pom.xml 8ac1edf4f65ebd9746f37b17af7906f0e3e4101d
> agents-audit/src/main/java/org/apache/ranger/audit/destination/ElasticSearchAuditDestination.java PRE-CREATION
> agents-audit/src/main/java/org/apache/ranger/audit/provider/AuditProviderFactory.java 88cf99b6e8e9ef5486e8101ea6fdcbdbf7d1d1b3
> hbase-agent/conf/ranger-hbase-audit-changes.cfg 719c7cdbf16799c503d741c2fc582185f875fd02
> hbase-agent/scripts/install.properties f4fdb14ac0e357d5cad2a67c10fe4080fc39f370
> hdfs-agent/conf/ranger-hdfs-audit-changes.cfg e34d15451765d7eabfaa9c4e8a632e2c430be842
> hdfs-agent/scripts/install.properties 54dc3a19ef231e5f64d247e2775e5b7729509359
> hive-agent/conf/ranger-hive-audit-changes.cfg 3fd7e14bff93780e28bf52b97eec0ba26798ca9f
> hive-agent/scripts/install.properties 3e8f59025ae96921b86b450b03c7c11f2472198e
> kms/scripts/install.properties a30b1d3a90783e79810075a577241b2c5e87035d
> knox-agent/conf/ranger-knox-audit-changes.cfg f0571e7671681f94294e9ebd4b9287a75870936c
> knox-agent/scripts/install.properties d2dbbc3fad446f8ca94143b96f986bd8617bcefb
> plugin-atlas/conf/ranger-atlas-audit-changes.cfg 07fc38279878d819bbe7f8024ed7d57c9697cd7e
> plugin-atlas/conf/ranger-atlas-audit.xml 93ad238df6e07ec24d409b389224c45956e3ac0f
> plugin-atlas/scripts/install.properties 511e6ae32afbb41acdae1af6c00f943a56eb267f
> plugin-elasticsearch/conf/ranger-elasticsearch-audit-changes.cfg 8071e7b46b54d9052264540255bf58294a419e8a
> plugin-elasticsearch/scripts/install.properties 3a5b2132ef1f00a0008d3489a5bc18718106c0a2
> plugin-kafka/conf/ranger-kafka-audit-changes.cfg 661b498a24b95b9ba708f83b4b6c08f01c760fbd
> plugin-kafka/scripts/install.properties 6b01aedcb5c8c0090b0bf409285d240b2f713459
> plugin-kms/conf/ranger-kms-audit-changes.cfg 69849d6a3b8213b2ff3e24034f8d680cecbd423e
> plugin-kylin/conf/ranger-kylin-audit-changes.cfg 8071e7b46b54d9052264540255bf58294a419e8a
> plugin-kylin/scripts/install.properties 126eebad0b0718be44f936b677631b18daa8f06b
> plugin-ozone/conf/ranger-ozone-audit-changes.cfg e5adb76819277a1a75dcc6c3b7e6f3c127d49f2e
> plugin-ozone/scripts/install.properties 276d192a0f29db79fbab5c57f51bcc723420a364
> plugin-presto/conf/ranger-presto-audit-changes.cfg 661b498a24b95b9ba708f83b4b6c08f01c760fbd
> plugin-presto/scripts/install.properties 3110e2d015bd69f17fd09fc2d3b6b12b1c40fb1c
> plugin-solr/conf/ranger-solr-audit-changes.cfg 622052ed1ff45e09eb120c4889c7d1b2815f56eb
> plugin-solr/scripts/install.properties 48a9af211baef13e8fe9d0762e505a7e973d4ed9
> plugin-sqoop/conf/ranger-sqoop-audit-changes.cfg 8071e7b46b54d9052264540255bf58294a419e8a
> plugin-sqoop/scripts/install.properties 44f16dac87ad3c9b8f431dcc5713e219422bf3bd
> plugin-yarn/conf/ranger-yarn-audit-changes.cfg 8071e7b46b54d9052264540255bf58294a419e8a
> plugin-yarn/scripts/install.properties f776c5f6fa0e05cd950b854c79a3bfd6982bd602
> pom.xml 22926fd7d04feecf308f84d98c35ce2d084591ef
> ranger-elasticsearch-plugin-shim/src/main/java/org/apache/ranger/authorization/elasticsearch/plugin/RangerElasticsearchPlugin.java f9a683706468269bdc7936bdbcedfc357b5a04e9
> security-admin/scripts/install.properties 155c42ccced826e73696c3c1ff7393fedc0f2159
> security-admin/scripts/ranger-admin-site-template.xml af345cf436e8950af6a178de2f7a0559183d010b
> security-admin/scripts/setup.sh 9677f57b8cde2a0b3512c858f4b625e37234138c
> security-admin/scripts/upgrade_admin.py 28b7e9884907c7e9d4f492bbfda273ac5ec5916a
> security-admin/src/main/java/org/apache/ranger/AccessAuditsService.java PRE-CREATION
> security-admin/src/main/java/org/apache/ranger/biz/AssetMgr.java 17c105f7e332b7f024fa119289edad7774bf89f8
> security-admin/src/main/java/org/apache/ranger/biz/RangerBizUtil.java ebc72cf029ed06d6918fb8439c93a7ae3f49a333
> security-admin/src/main/java/org/apache/ranger/biz/XAuditMgr.java 9eecc20a2a61240912570d96492824268a749f92
> security-admin/src/main/java/org/apache/ranger/elasticsearch/ElasticSearchAccessAuditsService.java PRE-CREATION
> security-admin/src/main/java/org/apache/ranger/elasticsearch/ElasticSearchMgr.java PRE-CREATION
> security-admin/src/main/java/org/apache/ranger/elasticsearch/ElasticSearchUtil.java PRE-CREATION
> security-admin/src/main/java/org/apache/ranger/solr/SolrAccessAuditsService.java 453c7dcc8e05c4cd239bf0d7fb56e47814271524
> security-admin/src/main/resources/conf.dist/ranger-admin-site.xml 298f02b15e5ff990c99b1f46bda49b4d64ddff81
> security-admin/src/test/java/org/apache/ranger/elasticsearch/ElasticSearchAccessAuditsServiceTest.java PRE-CREATION
> storm-agent/conf/ranger-storm-audit-changes.cfg 8071e7b46b54d9052264540255bf58294a419e8a
> storm-agent/scripts/install.properties e805b75fd60fda31f94a96f881bb2f984d923876
>
>
> Diff: https://reviews.apache.org/r/71921/diff/4/
>
>
> Testing
> -------
>
> Semi-automated tests write and then read a value from a local ElasticSearch instance. Also set up an admin server and client running hive-plugin and verified audit events were stored and indexed.
>
>
> Thanks,
>
> Andrew Charneski
>
>
Re: Review Request 71921: Add support for ElasticSearch as an Audit
Database
Posted by Andrew Charneski <ac...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/71921/
-----------------------------------------------------------
(Updated March 26, 2020, 2:12 a.m.)
Review request for ranger and Don Bosco Durai.
Repository: ranger
Description
-------
RANGER-2634 Add support for ElasticSearch as an Audit Database
Diffs (updated)
-----
agents-audit/pom.xml 8ac1edf4f65ebd9746f37b17af7906f0e3e4101d
agents-audit/src/main/java/org/apache/ranger/audit/destination/ElasticSearchAuditDestination.java PRE-CREATION
agents-audit/src/main/java/org/apache/ranger/audit/provider/AuditProviderFactory.java 88cf99b6e8e9ef5486e8101ea6fdcbdbf7d1d1b3
hbase-agent/conf/ranger-hbase-audit-changes.cfg 719c7cdbf16799c503d741c2fc582185f875fd02
hbase-agent/scripts/install.properties f4fdb14ac0e357d5cad2a67c10fe4080fc39f370
hdfs-agent/conf/ranger-hdfs-audit-changes.cfg e34d15451765d7eabfaa9c4e8a632e2c430be842
hdfs-agent/scripts/install.properties 54dc3a19ef231e5f64d247e2775e5b7729509359
hive-agent/conf/ranger-hive-audit-changes.cfg 3fd7e14bff93780e28bf52b97eec0ba26798ca9f
hive-agent/scripts/install.properties 3e8f59025ae96921b86b450b03c7c11f2472198e
kms/scripts/install.properties a30b1d3a90783e79810075a577241b2c5e87035d
knox-agent/conf/ranger-knox-audit-changes.cfg f0571e7671681f94294e9ebd4b9287a75870936c
knox-agent/scripts/install.properties d2dbbc3fad446f8ca94143b96f986bd8617bcefb
plugin-atlas/conf/ranger-atlas-audit-changes.cfg 07fc38279878d819bbe7f8024ed7d57c9697cd7e
plugin-atlas/conf/ranger-atlas-audit.xml 93ad238df6e07ec24d409b389224c45956e3ac0f
plugin-atlas/scripts/install.properties 511e6ae32afbb41acdae1af6c00f943a56eb267f
plugin-elasticsearch/conf/ranger-elasticsearch-audit-changes.cfg 8071e7b46b54d9052264540255bf58294a419e8a
plugin-elasticsearch/scripts/install.properties 3a5b2132ef1f00a0008d3489a5bc18718106c0a2
plugin-kafka/conf/ranger-kafka-audit-changes.cfg 661b498a24b95b9ba708f83b4b6c08f01c760fbd
plugin-kafka/scripts/install.properties 6b01aedcb5c8c0090b0bf409285d240b2f713459
plugin-kms/conf/ranger-kms-audit-changes.cfg 69849d6a3b8213b2ff3e24034f8d680cecbd423e
plugin-kylin/conf/ranger-kylin-audit-changes.cfg 8071e7b46b54d9052264540255bf58294a419e8a
plugin-kylin/scripts/install.properties 126eebad0b0718be44f936b677631b18daa8f06b
plugin-ozone/conf/ranger-ozone-audit-changes.cfg e5adb76819277a1a75dcc6c3b7e6f3c127d49f2e
plugin-ozone/scripts/install.properties 276d192a0f29db79fbab5c57f51bcc723420a364
plugin-presto/conf/ranger-presto-audit-changes.cfg 661b498a24b95b9ba708f83b4b6c08f01c760fbd
plugin-presto/scripts/install.properties 3110e2d015bd69f17fd09fc2d3b6b12b1c40fb1c
plugin-solr/conf/ranger-solr-audit-changes.cfg 622052ed1ff45e09eb120c4889c7d1b2815f56eb
plugin-solr/scripts/install.properties 48a9af211baef13e8fe9d0762e505a7e973d4ed9
plugin-sqoop/conf/ranger-sqoop-audit-changes.cfg 8071e7b46b54d9052264540255bf58294a419e8a
plugin-sqoop/scripts/install.properties 44f16dac87ad3c9b8f431dcc5713e219422bf3bd
plugin-yarn/conf/ranger-yarn-audit-changes.cfg 8071e7b46b54d9052264540255bf58294a419e8a
plugin-yarn/scripts/install.properties f776c5f6fa0e05cd950b854c79a3bfd6982bd602
pom.xml 22926fd7d04feecf308f84d98c35ce2d084591ef
ranger-elasticsearch-plugin-shim/src/main/java/org/apache/ranger/authorization/elasticsearch/plugin/RangerElasticsearchPlugin.java f9a683706468269bdc7936bdbcedfc357b5a04e9
security-admin/scripts/install.properties 155c42ccced826e73696c3c1ff7393fedc0f2159
security-admin/scripts/ranger-admin-site-template.xml af345cf436e8950af6a178de2f7a0559183d010b
security-admin/scripts/setup.sh 9677f57b8cde2a0b3512c858f4b625e37234138c
security-admin/scripts/upgrade_admin.py 28b7e9884907c7e9d4f492bbfda273ac5ec5916a
security-admin/src/main/java/org/apache/ranger/AccessAuditsService.java PRE-CREATION
security-admin/src/main/java/org/apache/ranger/biz/AssetMgr.java 17c105f7e332b7f024fa119289edad7774bf89f8
security-admin/src/main/java/org/apache/ranger/biz/RangerBizUtil.java ebc72cf029ed06d6918fb8439c93a7ae3f49a333
security-admin/src/main/java/org/apache/ranger/biz/XAuditMgr.java 9eecc20a2a61240912570d96492824268a749f92
security-admin/src/main/java/org/apache/ranger/elasticsearch/ElasticSearchAccessAuditsService.java PRE-CREATION
security-admin/src/main/java/org/apache/ranger/elasticsearch/ElasticSearchMgr.java PRE-CREATION
security-admin/src/main/java/org/apache/ranger/elasticsearch/ElasticSearchUtil.java PRE-CREATION
security-admin/src/main/resources/conf.dist/ranger-admin-site.xml 298f02b15e5ff990c99b1f46bda49b4d64ddff81
security-admin/src/test/java/org/apache/ranger/elasticsearch/ElasticSearchAccessAuditsServiceTest.java PRE-CREATION
storm-agent/conf/ranger-storm-audit-changes.cfg 8071e7b46b54d9052264540255bf58294a419e8a
storm-agent/scripts/install.properties e805b75fd60fda31f94a96f881bb2f984d923876
Diff: https://reviews.apache.org/r/71921/diff/3/
Changes: https://reviews.apache.org/r/71921/diff/2-3/
Testing
-------
Semi-automated tests write and then read a value from a local ElasticSearch instance. Also set up an admin server and client running hive-plugin and verified audit events were stored and indexed.
Thanks,
Andrew Charneski
Re: Review Request 71921: Add support for ElasticSearch as an Audit
Database
Posted by Andrew Charneski <ac...@gmail.com>.
> On March 7, 2020, 10:06 p.m., Don Bosco Durai wrote:
> >
Changes made. Please re-review. Thank you.
> On March 7, 2020, 10:06 p.m., Don Bosco Durai wrote:
> > agents-audit/pom.xml
> > Lines 118 (patched)
> > <https://reviews.apache.org/r/71921/diff/2/?file=2209519#file2209519line118>
> >
> > Any reason the version is hard coded?
Since it was only used once, I didn't see any reason to make it a property, if that's what you mean by "hard coded". I assume that is your intent, since it appears many existing dependencies do not use dependencyManagement, and have introduced a property.
> On March 7, 2020, 10:06 p.m., Don Bosco Durai wrote:
> > agents-audit/src/main/java/org/apache/ranger/audit/destination/ElasticSearchAuditDestination.java
> > Lines 160 (patched)
> > <https://reviews.apache.org/r/71921/diff/2/?file=2209520#file2209520line160>
> >
> > For debugging purpose, should we set this as member attributes and init load them and have it logged at INFO level (without the password)? This will help during debuging.
Done
> On March 7, 2020, 10:06 p.m., Don Bosco Durai wrote:
> > migration-util/ambari2.1-hdp2.3-ranger0.50/bin/import_ranger_to_ambari.py
> > Lines 292 (patched)
> > <https://reviews.apache.org/r/71921/diff/2/?file=2209536#file2209536line292>
> >
> > Do we need to update this file? Not sure whether anyone will need it. If it not used or tested, then we should probably not just add and risk breaking something else.
I was merely trying to replicate all occurances of the solr config entries. Seems reasonable to remove this one.
> On March 7, 2020, 10:06 p.m., Don Bosco Durai wrote:
> > security-admin/src/main/java/org/apache/ranger/elasticsearch/ElasticSearchAccessAuditsService.java
> > Lines 76 (patched)
> > <https://reviews.apache.org/r/71921/diff/2/?file=2209571#file2209571line76>
> >
> > Just curious if there are additional information that can be printed which would be useful for debug?
Added exception message.
> On March 7, 2020, 10:06 p.m., Don Bosco Durai wrote:
> > security-admin/src/main/java/org/apache/ranger/elasticsearch/ElasticSearchMgr.java
> > Lines 64 (patched)
> > <https://reviews.apache.org/r/71921/diff/2/?file=2209572#file2209572line64>
> >
> > I think we have org.apache.ranger.common.StringUtil.isEmpty() method which will check for null and empty string. It will take care if the value is ""
Changed as requested. Why is this method not static?
> On March 7, 2020, 10:06 p.m., Don Bosco Durai wrote:
> > security-admin/src/main/java/org/apache/ranger/elasticsearch/ElasticSearchUtil.java
> > Lines 73 (patched)
> > <https://reviews.apache.org/r/71921/diff/2/?file=2209573#file2209573line73>
> >
> > Can we use StringUtil.isEmpty() here and remove empty string check? Same for other methods also
This value isn't necessarily a string
- Andrew
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/71921/#review219835
-----------------------------------------------------------
On Jan. 24, 2020, 7:56 p.m., Andrew Charneski wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/71921/
> -----------------------------------------------------------
>
> (Updated Jan. 24, 2020, 7:56 p.m.)
>
>
> Review request for ranger and Don Bosco Durai.
>
>
> Repository: ranger
>
>
> Description
> -------
>
> RANGER-2634 Add support for ElasticSearch as an Audit Database
>
>
> Diffs
> -----
>
> agents-audit/pom.xml 8ac1edf4f
> agents-audit/src/main/java/org/apache/ranger/audit/destination/ElasticSearchAuditDestination.java PRE-CREATION
> agents-audit/src/main/java/org/apache/ranger/audit/provider/AuditProviderFactory.java 88cf99b6e
> hbase-agent/conf/ranger-hbase-audit-changes.cfg 719c7cdbf
> hbase-agent/scripts/install.properties f4fdb14ac
> hdfs-agent/conf/ranger-hdfs-audit-changes.cfg e34d15451
> hdfs-agent/pom.xml 5fe8a41f7
> hdfs-agent/scripts/install.properties 54dc3a19e
> hive-agent/conf/ranger-hive-audit-changes.cfg 3fd7e14bf
> hive-agent/pom.xml f219a375a
> hive-agent/scripts/install.properties 3e8f59025
> hive-agent/src/main/java/org/apache/ranger/authorization/hive/authorizer/RangerHiveAuditHandler.java a3d575c86
> hive-agent/src/test/java/org/apache/ranger/services/hive/HIVERangerAuthorizerTest.java f901f71a3
> kms/pom.xml 3bf20fdd4
> kms/scripts/install.properties a30b1d3a9
> knox-agent/conf/ranger-knox-audit-changes.cfg f0571e767
> knox-agent/scripts/install.properties d2dbbc3fa
> migration-util/ambari2.1-hdp2.3-ranger0.50/bin/import_ranger_to_ambari.py e25b8ae89
> plugin-atlas/conf/ranger-atlas-audit-changes.cfg 07fc38279
> plugin-atlas/conf/ranger-atlas-audit.xml 93ad238df
> plugin-atlas/scripts/install.properties 511e6ae32
> plugin-elasticsearch/conf/ranger-elasticsearch-audit-changes.cfg 8071e7b46
> plugin-elasticsearch/scripts/install.properties 3a5b2132e
> plugin-kafka/conf/ranger-kafka-audit-changes.cfg 661b498a2
> plugin-kafka/scripts/install.properties 6b01aedcb
> plugin-kms/conf/ranger-kms-audit-changes.cfg 69849d6a3
> plugin-kylin/conf/ranger-kylin-audit-changes.cfg 8071e7b46
> plugin-kylin/scripts/install.properties 126eebad0
> plugin-ozone/conf/ranger-ozone-audit-changes.cfg e5adb7681
> plugin-ozone/scripts/install.properties 276d192a0
> plugin-presto/conf/ranger-presto-audit-changes.cfg 661b498a2
> plugin-presto/scripts/install.properties 3110e2d01
> plugin-solr/conf/ranger-solr-audit-changes.cfg 622052ed1
> plugin-solr/scripts/install.properties 48a9af211
> plugin-sqoop/conf/ranger-sqoop-audit-changes.cfg 8071e7b46
> plugin-sqoop/scripts/install.properties 44f16dac8
> plugin-yarn/conf/ranger-yarn-audit-changes.cfg 8071e7b46
> plugin-yarn/scripts/install.properties f776c5f6f
> pom.xml e3c5ce3bc
> ranger-elasticsearch-plugin-shim/src/main/java/org/apache/ranger/authorization/elasticsearch/plugin/RangerElasticsearchPlugin.java f9a683706
> ranger-hive-plugin-shim/pom.xml c27647034
> ranger-util/src/test/LICENSE.txt PRE-CREATION
> security-admin/pom.xml fc4a20020
> security-admin/scripts/install.properties 155c42ccc
> security-admin/scripts/ranger-admin-site-template.xml af345cf43
> security-admin/scripts/setup.sh 9677f57b8
> security-admin/scripts/upgrade_admin.py 28b7e9884
> security-admin/src/main/java/org/apache/ranger/AccessAuditsService.java PRE-CREATION
> security-admin/src/main/java/org/apache/ranger/biz/AssetMgr.java 0f4488861
> security-admin/src/main/java/org/apache/ranger/biz/RangerBizUtil.java ebc72cf02
> security-admin/src/main/java/org/apache/ranger/biz/XAuditMgr.java 9eecc20a2
> security-admin/src/main/java/org/apache/ranger/common/PropertiesUtil.java 43bbdfb35
> security-admin/src/main/java/org/apache/ranger/elasticsearch/ElasticSearchAccessAuditsService.java PRE-CREATION
> security-admin/src/main/java/org/apache/ranger/elasticsearch/ElasticSearchMgr.java PRE-CREATION
> security-admin/src/main/java/org/apache/ranger/elasticsearch/ElasticSearchUtil.java PRE-CREATION
> security-admin/src/main/java/org/apache/ranger/solr/SolrAccessAuditsService.java b422e7c00
> security-admin/src/main/resources/conf.dist/ranger-admin-site.xml 298f02b15
> security-admin/src/test/java/org/apache/ranger/elasticsearch/ElasticSearchAccessAuditsServiceTest.java PRE-CREATION
> security-admin/src/test/resources/log4j.xml 15ae2741c
> storm-agent/conf/ranger-storm-audit-changes.cfg 8071e7b46
> storm-agent/scripts/install.properties e805b75fd
>
>
> Diff: https://reviews.apache.org/r/71921/diff/2/
>
>
> Testing
> -------
>
> Semi-automated tests write and then read a value from a local ElasticSearch instance. Also set up an admin server and client running hive-plugin and verified audit events were stored and indexed.
>
>
> Thanks,
>
> Andrew Charneski
>
>
Re: Review Request 71921: Add support for ElasticSearch as an Audit
Database
Posted by Don Bosco Durai <bo...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/71921/#review219835
-----------------------------------------------------------
agents-audit/pom.xml
Lines 118 (patched)
<https://reviews.apache.org/r/71921/#comment308058>
Any reason the version is hard coded?
agents-audit/src/main/java/org/apache/ranger/audit/destination/ElasticSearchAuditDestination.java
Lines 120 (patched)
<https://reviews.apache.org/r/71921/#comment308060>
Can we have this in if(LOG.isDebugEnabled()) { block }?
agents-audit/src/main/java/org/apache/ranger/audit/destination/ElasticSearchAuditDestination.java
Lines 160 (patched)
<https://reviews.apache.org/r/71921/#comment308061>
For debugging purpose, should we set this as member attributes and init load them and have it logged at INFO level (without the password)? This will help during debuging.
agents-audit/src/main/java/org/apache/ranger/audit/destination/ElasticSearchAuditDestination.java
Lines 200 (patched)
<https://reviews.apache.org/r/71921/#comment308062>
Can we print additional information like port, etc.
migration-util/ambari2.1-hdp2.3-ranger0.50/bin/import_ranger_to_ambari.py
Lines 292 (patched)
<https://reviews.apache.org/r/71921/#comment308063>
Do we need to update this file? Not sure whether anyone will need it. If it not used or tested, then we should probably not just add and risk breaking something else.
pom.xml
Lines 135 (patched)
<https://reviews.apache.org/r/71921/#comment308057>
Can we indent this as others?
security-admin/scripts/install.properties
Lines 85 (patched)
<https://reviews.apache.org/r/71921/#comment308064>
Can we keep plugin and admin config similar? In Plugin we are taking Port as config
security-admin/src/main/java/org/apache/ranger/elasticsearch/ElasticSearchAccessAuditsService.java
Lines 76 (patched)
<https://reviews.apache.org/r/71921/#comment308065>
Just curious if there are additional information that can be printed which would be useful for debug?
security-admin/src/main/java/org/apache/ranger/elasticsearch/ElasticSearchAccessAuditsService.java
Lines 105 (patched)
<https://reviews.apache.org/r/71921/#comment308066>
Can we print the request data? And also the execption?
security-admin/src/main/java/org/apache/ranger/elasticsearch/ElasticSearchMgr.java
Lines 58 (patched)
<https://reviews.apache.org/r/71921/#comment308067>
Seems we have the port configurable. But it is not in the properties file. It would be good to have it with the default value.
security-admin/src/main/java/org/apache/ranger/elasticsearch/ElasticSearchMgr.java
Lines 60 (patched)
<https://reviews.apache.org/r/71921/#comment308068>
Any reason this is WARN? Can we have it as INFO?
security-admin/src/main/java/org/apache/ranger/elasticsearch/ElasticSearchMgr.java
Lines 64 (patched)
<https://reviews.apache.org/r/71921/#comment308069>
I think we have org.apache.ranger.common.StringUtil.isEmpty() method which will check for null and empty string. It will take care if the value is ""
security-admin/src/main/java/org/apache/ranger/elasticsearch/ElasticSearchMgr.java
Lines 73 (patched)
<https://reviews.apache.org/r/71921/#comment308070>
Can we put an INFO log with the username that will be used to login? So we know it is trying authentication mechanism?
security-admin/src/main/java/org/apache/ranger/elasticsearch/ElasticSearchMgr.java
Lines 87 (patched)
<https://reviews.apache.org/r/71921/#comment308071>
Can we have other properties also?
security-admin/src/main/java/org/apache/ranger/elasticsearch/ElasticSearchMgr.java
Lines 99 (patched)
<https://reviews.apache.org/r/71921/#comment308072>
Since connect() is already synchronized, do we need this here also?
security-admin/src/main/java/org/apache/ranger/elasticsearch/ElasticSearchUtil.java
Lines 73 (patched)
<https://reviews.apache.org/r/71921/#comment308074>
Can we use StringUtil.isEmpty() here and remove empty string check? Same for other methods also
security-admin/src/main/java/org/apache/ranger/elasticsearch/ElasticSearchUtil.java
Lines 224 (patched)
<https://reviews.apache.org/r/71921/#comment308075>
Can we have curly braces here? It will avoid anyone make mistakes in the future wrt scope
security-admin/src/main/java/org/apache/ranger/elasticsearch/ElasticSearchUtil.java
Lines 288 (patched)
<https://reviews.apache.org/r/71921/#comment308076>
Can we print other parameter from the method also? Same for other log messages in this method
security-admin/src/main/resources/conf.dist/ranger-admin-site.xml
Lines 49 (patched)
<https://reviews.apache.org/r/71921/#comment308077>
Could we have port also here?
- Don Bosco Durai
On Jan. 24, 2020, 7:56 p.m., Andrew Charneski wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/71921/
> -----------------------------------------------------------
>
> (Updated Jan. 24, 2020, 7:56 p.m.)
>
>
> Review request for ranger and Don Bosco Durai.
>
>
> Repository: ranger
>
>
> Description
> -------
>
> RANGER-2634 Add support for ElasticSearch as an Audit Database
>
>
> Diffs
> -----
>
> agents-audit/pom.xml 8ac1edf4f
> agents-audit/src/main/java/org/apache/ranger/audit/destination/ElasticSearchAuditDestination.java PRE-CREATION
> agents-audit/src/main/java/org/apache/ranger/audit/provider/AuditProviderFactory.java 88cf99b6e
> hbase-agent/conf/ranger-hbase-audit-changes.cfg 719c7cdbf
> hbase-agent/scripts/install.properties f4fdb14ac
> hdfs-agent/conf/ranger-hdfs-audit-changes.cfg e34d15451
> hdfs-agent/pom.xml 5fe8a41f7
> hdfs-agent/scripts/install.properties 54dc3a19e
> hive-agent/conf/ranger-hive-audit-changes.cfg 3fd7e14bf
> hive-agent/pom.xml f219a375a
> hive-agent/scripts/install.properties 3e8f59025
> hive-agent/src/main/java/org/apache/ranger/authorization/hive/authorizer/RangerHiveAuditHandler.java a3d575c86
> hive-agent/src/test/java/org/apache/ranger/services/hive/HIVERangerAuthorizerTest.java f901f71a3
> kms/pom.xml 3bf20fdd4
> kms/scripts/install.properties a30b1d3a9
> knox-agent/conf/ranger-knox-audit-changes.cfg f0571e767
> knox-agent/scripts/install.properties d2dbbc3fa
> migration-util/ambari2.1-hdp2.3-ranger0.50/bin/import_ranger_to_ambari.py e25b8ae89
> plugin-atlas/conf/ranger-atlas-audit-changes.cfg 07fc38279
> plugin-atlas/conf/ranger-atlas-audit.xml 93ad238df
> plugin-atlas/scripts/install.properties 511e6ae32
> plugin-elasticsearch/conf/ranger-elasticsearch-audit-changes.cfg 8071e7b46
> plugin-elasticsearch/scripts/install.properties 3a5b2132e
> plugin-kafka/conf/ranger-kafka-audit-changes.cfg 661b498a2
> plugin-kafka/scripts/install.properties 6b01aedcb
> plugin-kms/conf/ranger-kms-audit-changes.cfg 69849d6a3
> plugin-kylin/conf/ranger-kylin-audit-changes.cfg 8071e7b46
> plugin-kylin/scripts/install.properties 126eebad0
> plugin-ozone/conf/ranger-ozone-audit-changes.cfg e5adb7681
> plugin-ozone/scripts/install.properties 276d192a0
> plugin-presto/conf/ranger-presto-audit-changes.cfg 661b498a2
> plugin-presto/scripts/install.properties 3110e2d01
> plugin-solr/conf/ranger-solr-audit-changes.cfg 622052ed1
> plugin-solr/scripts/install.properties 48a9af211
> plugin-sqoop/conf/ranger-sqoop-audit-changes.cfg 8071e7b46
> plugin-sqoop/scripts/install.properties 44f16dac8
> plugin-yarn/conf/ranger-yarn-audit-changes.cfg 8071e7b46
> plugin-yarn/scripts/install.properties f776c5f6f
> pom.xml e3c5ce3bc
> ranger-elasticsearch-plugin-shim/src/main/java/org/apache/ranger/authorization/elasticsearch/plugin/RangerElasticsearchPlugin.java f9a683706
> ranger-hive-plugin-shim/pom.xml c27647034
> ranger-util/src/test/LICENSE.txt PRE-CREATION
> security-admin/pom.xml fc4a20020
> security-admin/scripts/install.properties 155c42ccc
> security-admin/scripts/ranger-admin-site-template.xml af345cf43
> security-admin/scripts/setup.sh 9677f57b8
> security-admin/scripts/upgrade_admin.py 28b7e9884
> security-admin/src/main/java/org/apache/ranger/AccessAuditsService.java PRE-CREATION
> security-admin/src/main/java/org/apache/ranger/biz/AssetMgr.java 0f4488861
> security-admin/src/main/java/org/apache/ranger/biz/RangerBizUtil.java ebc72cf02
> security-admin/src/main/java/org/apache/ranger/biz/XAuditMgr.java 9eecc20a2
> security-admin/src/main/java/org/apache/ranger/common/PropertiesUtil.java 43bbdfb35
> security-admin/src/main/java/org/apache/ranger/elasticsearch/ElasticSearchAccessAuditsService.java PRE-CREATION
> security-admin/src/main/java/org/apache/ranger/elasticsearch/ElasticSearchMgr.java PRE-CREATION
> security-admin/src/main/java/org/apache/ranger/elasticsearch/ElasticSearchUtil.java PRE-CREATION
> security-admin/src/main/java/org/apache/ranger/solr/SolrAccessAuditsService.java b422e7c00
> security-admin/src/main/resources/conf.dist/ranger-admin-site.xml 298f02b15
> security-admin/src/test/java/org/apache/ranger/elasticsearch/ElasticSearchAccessAuditsServiceTest.java PRE-CREATION
> security-admin/src/test/resources/log4j.xml 15ae2741c
> storm-agent/conf/ranger-storm-audit-changes.cfg 8071e7b46
> storm-agent/scripts/install.properties e805b75fd
>
>
> Diff: https://reviews.apache.org/r/71921/diff/2/
>
>
> Testing
> -------
>
> Semi-automated tests write and then read a value from a local ElasticSearch instance. Also set up an admin server and client running hive-plugin and verified audit events were stored and indexed.
>
>
> Thanks,
>
> Andrew Charneski
>
>
Re: Review Request 71921: Add support for ElasticSearch as an Audit
Database
Posted by Andrew Charneski <ac...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/71921/
-----------------------------------------------------------
(Updated Jan. 24, 2020, 7:56 p.m.)
Review request for ranger and Don Bosco Durai.
Changes
-------
Updated patch to latest master, confirmed removal of changes questioned by review.
Repository: ranger
Description
-------
RANGER-2634 Add support for ElasticSearch as an Audit Database
Diffs (updated)
-----
agents-audit/pom.xml 8ac1edf4f
agents-audit/src/main/java/org/apache/ranger/audit/destination/ElasticSearchAuditDestination.java PRE-CREATION
agents-audit/src/main/java/org/apache/ranger/audit/provider/AuditProviderFactory.java 88cf99b6e
hbase-agent/conf/ranger-hbase-audit-changes.cfg 719c7cdbf
hbase-agent/scripts/install.properties f4fdb14ac
hdfs-agent/conf/ranger-hdfs-audit-changes.cfg e34d15451
hdfs-agent/pom.xml 5fe8a41f7
hdfs-agent/scripts/install.properties 54dc3a19e
hive-agent/conf/ranger-hive-audit-changes.cfg 3fd7e14bf
hive-agent/pom.xml f219a375a
hive-agent/scripts/install.properties 3e8f59025
hive-agent/src/main/java/org/apache/ranger/authorization/hive/authorizer/RangerHiveAuditHandler.java a3d575c86
hive-agent/src/test/java/org/apache/ranger/services/hive/HIVERangerAuthorizerTest.java f901f71a3
kms/pom.xml 3bf20fdd4
kms/scripts/install.properties a30b1d3a9
knox-agent/conf/ranger-knox-audit-changes.cfg f0571e767
knox-agent/scripts/install.properties d2dbbc3fa
migration-util/ambari2.1-hdp2.3-ranger0.50/bin/import_ranger_to_ambari.py e25b8ae89
plugin-atlas/conf/ranger-atlas-audit-changes.cfg 07fc38279
plugin-atlas/conf/ranger-atlas-audit.xml 93ad238df
plugin-atlas/scripts/install.properties 511e6ae32
plugin-elasticsearch/conf/ranger-elasticsearch-audit-changes.cfg 8071e7b46
plugin-elasticsearch/scripts/install.properties 3a5b2132e
plugin-kafka/conf/ranger-kafka-audit-changes.cfg 661b498a2
plugin-kafka/scripts/install.properties 6b01aedcb
plugin-kms/conf/ranger-kms-audit-changes.cfg 69849d6a3
plugin-kylin/conf/ranger-kylin-audit-changes.cfg 8071e7b46
plugin-kylin/scripts/install.properties 126eebad0
plugin-ozone/conf/ranger-ozone-audit-changes.cfg e5adb7681
plugin-ozone/scripts/install.properties 276d192a0
plugin-presto/conf/ranger-presto-audit-changes.cfg 661b498a2
plugin-presto/scripts/install.properties 3110e2d01
plugin-solr/conf/ranger-solr-audit-changes.cfg 622052ed1
plugin-solr/scripts/install.properties 48a9af211
plugin-sqoop/conf/ranger-sqoop-audit-changes.cfg 8071e7b46
plugin-sqoop/scripts/install.properties 44f16dac8
plugin-yarn/conf/ranger-yarn-audit-changes.cfg 8071e7b46
plugin-yarn/scripts/install.properties f776c5f6f
pom.xml e3c5ce3bc
ranger-elasticsearch-plugin-shim/src/main/java/org/apache/ranger/authorization/elasticsearch/plugin/RangerElasticsearchPlugin.java f9a683706
ranger-hive-plugin-shim/pom.xml c27647034
ranger-util/src/test/LICENSE.txt PRE-CREATION
security-admin/pom.xml fc4a20020
security-admin/scripts/install.properties 155c42ccc
security-admin/scripts/ranger-admin-site-template.xml af345cf43
security-admin/scripts/setup.sh 9677f57b8
security-admin/scripts/upgrade_admin.py 28b7e9884
security-admin/src/main/java/org/apache/ranger/AccessAuditsService.java PRE-CREATION
security-admin/src/main/java/org/apache/ranger/biz/AssetMgr.java 0f4488861
security-admin/src/main/java/org/apache/ranger/biz/RangerBizUtil.java ebc72cf02
security-admin/src/main/java/org/apache/ranger/biz/XAuditMgr.java 9eecc20a2
security-admin/src/main/java/org/apache/ranger/common/PropertiesUtil.java 43bbdfb35
security-admin/src/main/java/org/apache/ranger/elasticsearch/ElasticSearchAccessAuditsService.java PRE-CREATION
security-admin/src/main/java/org/apache/ranger/elasticsearch/ElasticSearchMgr.java PRE-CREATION
security-admin/src/main/java/org/apache/ranger/elasticsearch/ElasticSearchUtil.java PRE-CREATION
security-admin/src/main/java/org/apache/ranger/solr/SolrAccessAuditsService.java b422e7c00
security-admin/src/main/resources/conf.dist/ranger-admin-site.xml 298f02b15
security-admin/src/test/java/org/apache/ranger/elasticsearch/ElasticSearchAccessAuditsServiceTest.java PRE-CREATION
security-admin/src/test/resources/log4j.xml 15ae2741c
storm-agent/conf/ranger-storm-audit-changes.cfg 8071e7b46
storm-agent/scripts/install.properties e805b75fd
Diff: https://reviews.apache.org/r/71921/diff/2/
Changes: https://reviews.apache.org/r/71921/diff/1-2/
Testing
-------
Semi-automated tests write and then read a value from a local ElasticSearch instance. Also set up an admin server and client running hive-plugin and verified audit events were stored and indexed.
Thanks,
Andrew Charneski