You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by "michael-s-molina (via GitHub)" <gi...@apache.org> on 2023/04/23 15:52:40 UTC
[GitHub] [superset] michael-s-molina opened a new pull request, #23785: chore: Deprecates 3.0 consented feature flags
michael-s-molina opened a new pull request, #23785:
URL: https://github.com/apache/superset/pull/23785
### SUMMARY
Deprecates the following feature flags that received lazy consensus for 3.0:
- `CLIENT_CACHE`
- `DASHBOARD_CACHE`
- `DASHBOARD_FILTERS_EXPERIMENTAL`
- `DASHBOARD_NATIVE_FILTERS`
- `DASHBOARD_NATIVE_FILTERS_SET`
- `DISABLE_DATASET_SOURCE_EDIT`
- `ENABLE_EXPLORE_JSON_CSRF_PROTECTION`
- `REMOVE_SLICE_LEVEL_LABEL_COLORS`
`DASHBOARD_EDIT_CHART_IN_NEW_TAB` was removed as the feature is supported without the need for a feature flag.
### ADDITIONAL INFORMATION
- [ ] Has associated issue:
- [ ] Required feature flags:
- [ ] Changes UI
- [ ] Includes DB Migration (follow approval process in [SIP-59](https://github.com/apache/superset/issues/13351))
- [ ] Migration is atomic, supports rollback & is backwards-compatible
- [ ] Confirm DB migration upgrade and downgrade tested
- [ ] Runtime estimates and downtime expectations provided
- [ ] Introduces new feature or API
- [ ] Removes existing feature or API
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] chore: Deprecates 3.0 consented feature flags [superset]
Posted by "wdepiatti (via GitHub)" <gi...@apache.org>.
wdepiatti commented on PR #23785:
URL: https://github.com/apache/superset/pull/23785#issuecomment-2060009188
I have a problem with the native filter that disappears, when I use docker-compose-image-tag.yml, the version is 3.1.1
. But... when I run docker-compose-non-dev.yml, version 0.0.0-dev and native filters appear, I've already carried out a search, I can't activate the filter in version 3.1.1
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov[bot] commented on pull request #23785: chore: Deprecates 3.0 consented feature flags
Posted by "codecov[bot] (via GitHub)" <gi...@apache.org>.
codecov[bot] commented on PR #23785:
URL: https://github.com/apache/superset/pull/23785#issuecomment-1519113939
## [Codecov](https://codecov.io/gh/apache/superset/pull/23785?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#23785](https://codecov.io/gh/apache/superset/pull/23785?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (c37c73d) into [master](https://codecov.io/gh/apache/superset/commit/35f36a20ffe075b97ff1eef26e1876b6c4e9619a?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (35f36a2) will **decrease** coverage by `11.22%`.
> The diff coverage is `56.66%`.
> :exclamation: Current head c37c73d differs from pull request most recent head 2ff4626. Consider uploading reports for the commit 2ff4626 to get more accurate results
```diff
@@ Coverage Diff @@
## master #23785 +/- ##
===========================================
- Coverage 67.87% 56.65% -11.22%
===========================================
Files 1925 1926 +1
Lines 74389 74494 +105
Branches 8108 8104 -4
===========================================
- Hits 50494 42208 -8286
- Misses 21818 30210 +8392
+ Partials 2077 2076 -1
```
| Flag | Coverage Δ | |
|---|---|---|
| hive | `52.93% <55.83%> (+<0.01%)` | :arrow_up: |
| mysql | `?` | |
| postgres | `?` | |
| presto | `52.85% <55.83%> (+<0.01%)` | :arrow_up: |
| python | `59.38% <56.66%> (-23.27%)` | :arrow_down: |
| sqlite | `?` | |
| unit | `52.73% <56.66%> (+<0.01%)` | :arrow_up: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/23785?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...ackages/superset-ui-core/src/utils/featureFlags.ts](https://codecov.io/gh/apache/superset/pull/23785?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvcGFja2FnZXMvc3VwZXJzZXQtdWktY29yZS9zcmMvdXRpbHMvZmVhdHVyZUZsYWdzLnRz) | `100.00% <ø> (ø)` | |
| [.../src/dashboard/components/gridComponents/Chart.jsx](https://codecov.io/gh/apache/superset/pull/23785?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL2dyaWRDb21wb25lbnRzL0NoYXJ0LmpzeA==) | `56.48% <ø> (+1.02%)` | :arrow_up: |
| [...ntend/src/dashboard/util/getSliceHeaderTooltip.tsx](https://codecov.io/gh/apache/superset/pull/23785?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC91dGlsL2dldFNsaWNlSGVhZGVyVG9vbHRpcC50c3g=) | `83.33% <ø> (+8.33%)` | :arrow_up: |
| [superset/config.py](https://codecov.io/gh/apache/superset/pull/23785?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvY29uZmlnLnB5) | `91.27% <ø> (-0.59%)` | :arrow_down: |
| [...uperset/utils/dashboard\_filter\_scopes\_converter.py](https://codecov.io/gh/apache/superset/pull/23785?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvdXRpbHMvZGFzaGJvYXJkX2ZpbHRlcl9zY29wZXNfY29udmVydGVyLnB5) | `8.77% <0.00%> (-7.02%)` | :arrow_down: |
| [superset/views/sql\_lab/views.py](https://codecov.io/gh/apache/superset/pull/23785?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvdmlld3Mvc3FsX2xhYi92aWV3cy5weQ==) | `56.57% <ø> (-7.24%)` | :arrow_down: |
| [superset/models/sql\_lab.py](https://codecov.io/gh/apache/superset/pull/23785?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvbW9kZWxzL3NxbF9sYWIucHk=) | `74.00% <42.85%> (-5.51%)` | :arrow_down: |
| [superset/db\_engine\_specs/ocient.py](https://codecov.io/gh/apache/superset/pull/23785?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL29jaWVudC5weQ==) | `57.28% <57.28%> (ø)` | |
| [superset/db\_engine\_specs/base.py](https://codecov.io/gh/apache/superset/pull/23785?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL2Jhc2UucHk=) | `76.56% <100.00%> (-14.27%)` | :arrow_down: |
| [superset/db\_engine\_specs/mysql.py](https://codecov.io/gh/apache/superset/pull/23785?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL215c3FsLnB5) | `77.64% <100.00%> (-21.18%)` | :arrow_down: |
... and [296 files with indirect coverage changes](https://codecov.io/gh/apache/superset/pull/23785/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
:mega: We’re building smart automated test selection to slash your CI/CD build times. [Learn more](https://about.codecov.io/iterative-testing/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] michael-s-molina merged pull request #23785: chore: Deprecates 3.0 consented feature flags
Posted by "michael-s-molina (via GitHub)" <gi...@apache.org>.
michael-s-molina merged PR #23785:
URL: https://github.com/apache/superset/pull/23785
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org