You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@commons.apache.org by GitBox <gi...@apache.org> on 2021/08/01 06:24:24 UTC

[GitHub] [commons-ognl] arturobernalg opened a new pull request #48: Simplify conditions.

arturobernalg opened a new pull request #48:
URL: https://github.com/apache/commons-ognl/pull/48


   * Remove Unused import
   * Simplify conditions. 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@commons.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [commons-ognl] lukaszlenart commented on a change in pull request #48: Simplify conditions.

Posted by GitBox <gi...@apache.org>.

lukaszlenart commented on a change in pull request #48:
URL: https://github.com/apache/commons-ognl/pull/48#discussion_r693669574



##########
File path: src/main/java/org/apache/commons/ognl/enhance/ExpressionCompiler.java
##########
@@ -157,7 +157,7 @@ public static String getRootExpression( Node expression, Object root, OgnlContex
 
             Class<?> castClass = OgnlRuntime.getCompiler( context ).getRootExpressionClass( expression, context );
 
-            if ( castClass.isArray() || expression instanceof ASTRootVarRef || expression instanceof ASTThisVarRef)

Review comment:
       Why `ASTThisVarRef` was removed?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@commons.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org