You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2022/05/04 08:58:01 UTC
[GitHub] [spark] 1104056452 opened a new pull request, #36447: [SPARK-38807][CORE] Fix the startup error of spark shell on Windows S…
1104056452 opened a new pull request, #36447:
URL: https://github.com/apache/spark/pull/36447
What changes were proposed in this pull request?
The File.getCanonicalPath method will return the drive letter in the windows system. The RpcEnvFileServer.validateDirectoryUri method uses the File.getCanonicalPath method to process the baseuri, which will cause the baseuri not to comply with the URI verification rules. For example, the / classes is processed into F: \ classes.This causes the sparkcontext to fail to start on windows.
This PR modifies the RpcEnvFileServer.validateDirectoryUri method and replaces `new File(baseUri).getCanonicalPath` with
`new URI(baseUri).normalize().getPath`. This method can work normally in windows.
Why are the changes needed?
Fix the startup error of spark shell on Windows system
[[SPARK-35691](https://issues.apache.org/jira/browse/SPARK-35691)] introduced this regression.
Does this PR introduce any user-facing change?
No
How was this patch tested?
CI
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] Ngone51 commented on pull request #36447: [SPARK-38807][CORE] Fix the startup error of spark shell on Windows S…
Posted by GitBox <gi...@apache.org>.
Ngone51 commented on PR #36447:
URL: https://github.com/apache/spark/pull/36447#issuecomment-1142218019
cc @pingsutw @HyukjinKwon
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] 1104056452 commented on pull request #36447: [SPARK-38807][CORE] Fix the startup error of spark shell on Windows S…
Posted by GitBox <gi...@apache.org>.
1104056452 commented on PR #36447:
URL: https://github.com/apache/spark/pull/36447#issuecomment-1142132713
cc @Ngone51 @jiangxb1987 @xuanyuanking, could you please help review this PR? Thanks.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] 1104056452 commented on pull request #36447: [SPARK-38807][CORE] Fix the startup error of spark shell on Windows S…
Posted by GitBox <gi...@apache.org>.
1104056452 commented on PR #36447:
URL: https://github.com/apache/spark/pull/36447#issuecomment-1117093074
@HyukjinKwon It has been revised according to your suggestion.
mind taking a look when you find some time please. Thank you very much 🙏
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #36447: [SPARK-38807][CORE] Fix the startup error of spark shell on Windows S…
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on PR #36447:
URL: https://github.com/apache/spark/pull/36447#issuecomment-1117163227
Can one of the admins verify this patch?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] 1104056452 commented on pull request #36447: [SPARK-38807][CORE] Fix the startup error of spark shell on Windows S…
Posted by GitBox <gi...@apache.org>.
1104056452 commented on PR #36447:
URL: https://github.com/apache/spark/pull/36447#issuecomment-1141086939
Can someone help review this patch？thanks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] HyukjinKwon commented on pull request #36447: [SPARK-38807][CORE] Fix the startup error of spark shell on Windows
Posted by GitBox <gi...@apache.org>.
HyukjinKwon commented on PR #36447:
URL: https://github.com/apache/spark/pull/36447#issuecomment-1144231341
Yup, that test is broken a while ago..
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] srowen closed pull request #36447: [SPARK-38807][CORE] Fix the startup error of spark shell on Windows
Posted by GitBox <gi...@apache.org>.
srowen closed pull request #36447: [SPARK-38807][CORE] Fix the startup error of spark shell on Windows
URL: https://github.com/apache/spark/pull/36447
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] srowen commented on pull request #36447: [SPARK-38807][CORE] Fix the startup error of spark shell on Windows
Posted by GitBox <gi...@apache.org>.
srowen commented on PR #36447:
URL: https://github.com/apache/spark/pull/36447#issuecomment-1144821083
Merged to master/3.3/3.2
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] HyukjinKwon commented on pull request #36447: [SPARK-38807][CORE] Fix the startup error of spark shell on Windows
Posted by GitBox <gi...@apache.org>.
HyukjinKwon commented on PR #36447:
URL: https://github.com/apache/spark/pull/36447#issuecomment-1143591932
Looks fine to me 2
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] srowen commented on pull request #36447: [SPARK-38807][CORE] Fix the startup error of spark shell on Windows
Posted by GitBox <gi...@apache.org>.
srowen commented on PR #36447:
URL: https://github.com/apache/spark/pull/36447#issuecomment-1144172443
The windows tests failed, but, it appears unrelated?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org