[GitHub] [james-project] Arsnael commented on a change in pull request #487: JAMES-3596 Collocate all server applications in server/apps folder

[GitBox <gi...@apache.org>]

Arsnael commented on a change in pull request #487:
URL: https://github.com/apache/james-project/pull/487#discussion_r649668840



##########
File path: server/apps/cassandra-app-ldap-tests/pom.xml
##########
@@ -23,21 +23,33 @@
 
     <parent>
         <groupId>org.apache.james</groupId>
-        <artifactId>james-server-guice</artifactId>
+        <artifactId>james-server</artifactId>
         <version>3.7.0-SNAPSHOT</version>
-        <relativePath>../pom.xml</relativePath>
+        <relativePath>../../pom.xml</relativePath>
     </parent>
 
-    <artifactId>james-server-cassandra-ldap-guice</artifactId>
+    <artifactId>james-server-cassandra-app-ldap-tessts</artifactId>

Review comment:
       ```suggestion
       <artifactId>james-server-cassandra-app-ldap-tests</artifactId>
   ```

##########
File path: core/src/test/java/org/apache/james/core/UsernameTest.java
##########
@@ -148,9 +149,9 @@ void fromUsernameShouldThrowWhenTooLong() {
     }
 
     @Test
-    void fromUsernameShouldThrowWhenMultipleDomainDelimiter() {
-        assertThatThrownBy(() -> Username.of("aa@aa@aa"))
-            .isInstanceOf(IllegalArgumentException.class);
+    void arbitraryCharInLocalPart() {
+        assertThatCode(() -> Username.of("Whatever_I- want3$$$###_! as lons I do not give a domain"))
+            .doesNotThrowAnyException();

Review comment:
       Why do you change a test for Username in this commit/PR? Mix up with something else maybe?

##########
File path: server/container/guice/mailbox-jpa/pom.xml
##########
@@ -0,0 +1,85 @@
+<?xml version="1.0" encoding="UTF-8"?>
+<!--
+    Licensed to the Apache Software Foundation (ASF) under one
+    or more contributor license agreements. See the NOTICE file
+    distributed with this work for additional information
+    regarding copyright ownership. The ASF licenses this file
+    to you under the Apache License, Version 2.0 (the
+    "License"); you may not use this file except in compliance
+    with the License. You may obtain a copy of the License at
+
+    http://www.apache.org/licenses/LICENSE-2.0
+
+    Unless required by applicable law or agreed to in writing,
+    software distributed under the License is distributed on an
+    "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+    KIND, either express or implied. See the License for the
+    specific language governing permissions and limitations
+    under the License.
+-->
+<project xmlns="http://maven.apache.org/POM/4.0.0" xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 http://maven.apache.org/maven-v4_0_0.xsd">
+
+    <modelVersion>4.0.0</modelVersion>
+
+    <parent>
+        <groupId>org.apache.james</groupId>
+        <artifactId>james-server-guice</artifactId>
+        <version>3.7.0-SNAPSHOT</version>
+        <relativePath>../pom.xml</relativePath>
+    </parent>
+
+    <artifactId>james-server-guice-mailbox-jpa</artifactId>
+    <packaging>jar</packaging>
+
+    <name>Apache James :: Server :: JPA - guice injection</name>
+    <description>An advanced email server - JPA backend with guice injection</description>
+
+    <properties>
+        <jpa.includes>empty</jpa.includes>

Review comment:
       What is this for?

##########
File path: server/apps/cassandra-app-ldap-tests/pom.xml
##########
@@ -23,21 +23,33 @@
 
     <parent>
         <groupId>org.apache.james</groupId>
-        <artifactId>james-server-guice</artifactId>
+        <artifactId>james-server</artifactId>
         <version>3.7.0-SNAPSHOT</version>
-        <relativePath>../pom.xml</relativePath>
+        <relativePath>../../pom.xml</relativePath>
     </parent>
 
-    <artifactId>james-server-cassandra-ldap-guice</artifactId>
+    <artifactId>james-server-cassandra-app-ldap-tessts</artifactId>

Review comment:
       Solved in a later commit, don't bother!




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@james.apache.org
For additional commands, e-mail: notifications-help@james.apache.org