You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@tomcat.apache.org by bu...@apache.org on 2015/10/25 23:43:35 UTC
[Bug 58544] New: RequestDumperFilter contentLength inefficiently
creating Integer
https://bz.apache.org/bugzilla/show_bug.cgi?id=58544
Bug ID: 58544
Summary: RequestDumperFilter contentLength inefficiently
creating Integer
Product: Tomcat 8
Version: trunk
Hardware: Macintosh
OS: Mac OS X 10.1
Status: NEW
Severity: trivial
Priority: P2
Component: Catalina
Assignee: dev@tomcat.apache.org
Reporter: anthony@whitford.com
Created attachment 33216
--> https://bz.apache.org/bugzilla/attachment.cgi?id=33216&action=edit
Corrects contentLength logging to use less resources
The contentLength logging in RequestDumperFilter is calling:
Integer.valueOf(request.getContentLength()).toString()
instead of:
Integer.toString(request.getContentLength())
--
You are receiving this mail because:
You are the assignee for the bug.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org
[Bug 58544] RequestDumperFilter contentLength inefficiently creating
Integer
Posted by bu...@apache.org.
https://bz.apache.org/bugzilla/show_bug.cgi?id=58544
Violeta Georgieva <vi...@apache.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|NEW |RESOLVED
Resolution|--- |FIXED
--- Comment #1 from Violeta Georgieva <vi...@apache.org> ---
Hi,
Thanks for the report and the patch.
I applied the same fix on other places in the code also.
The fix is available in trunk, 8.0.x (for 8.0.29 onwards) and 7.0.x (for 7.0.66
onwards)
Regards,
Violeta
--
You are receiving this mail because:
You are the assignee for the bug.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org
[Bug 58544] RequestDumperFilter contentLength inefficiently creating
Integer
Posted by bu...@apache.org.
https://bz.apache.org/bugzilla/show_bug.cgi?id=58544
--- Comment #4 from Remy Maucherat <re...@apache.org> ---
Good move, the "efficiency" of the request dumper valve is meaningless, this
issue is really nonsense. However, using the int version may not work properly,
so that's a real fix.
--
You are receiving this mail because:
You are the assignee for the bug.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org
[Bug 58544] RequestDumperFilter contentLength inefficiently creating
Integer
Posted by bu...@apache.org.
https://bz.apache.org/bugzilla/show_bug.cgi?id=58544
--- Comment #2 from Christopher Schultz <ch...@christopherschultz.net> ---
Should this usage of request.getContentLength be changed to use
request.getHeader("Content-Length") to avoid the 2GiB primitive int limit?
--
You are receiving this mail because:
You are the assignee for the bug.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org
[Bug 58544] RequestDumperFilter contentLength inefficiently creating
Integer
Posted by bu...@apache.org.
https://bz.apache.org/bugzilla/show_bug.cgi?id=58544
--- Comment #3 from Violeta Georgieva <vi...@apache.org> ---
I switched to request.getContentLengthLong in trunk and Tomcat 8 trunk
--
You are receiving this mail because:
You are the assignee for the bug.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org