You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2022/03/29 19:47:49 UTC
[GitHub] [airflow] kaxil opened a new pull request #22599: Bump black version for other pre-commit hooks
kaxil opened a new pull request #22599:
URL: https://github.com/apache/airflow/pull/22599
This PR/commit bumps the black version used in other pre-commit hooks as a follow up of https://github.com/apache/airflow/pull/22598
<!--
Thank you for contributing! Please make sure that your code changes
are covered with tests. And in case of new features or big changes
remember to adjust the documentation.
Feel free to ping committers for the review!
In case of existing issue, reference it using one of the following:
closes: #ISSUE
related: #ISSUE
How to write a good git commit message:
http://chris.beams.io/posts/git-commit/
-->
---
**^ Add meaningful description above**
Read the **[Pull Request Guidelines](https://github.com/apache/airflow/blob/main/CONTRIBUTING.rst#pull-request-guidelines)** for more information.
In case of fundamental code change, Airflow Improvement Proposal ([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvements+Proposals)) is needed.
In case of a new dependency, check compliance with the [ASF 3rd Party License Policy](https://www.apache.org/legal/resolved.html#category-x).
In case of backwards incompatible changes please leave a note in [UPDATING.md](https://github.com/apache/airflow/blob/main/UPDATING.md).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk commented on pull request #22599: Bump black version for other pre-commit hooks
Posted by GitBox <gi...@apache.org>.
potiuk commented on pull request #22599:
URL: https://github.com/apache/airflow/pull/22599#issuecomment-1082391497
WAT ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk commented on pull request #22599: Bump black version for other pre-commit hooks
Posted by GitBox <gi...@apache.org>.
potiuk commented on pull request #22599:
URL: https://github.com/apache/airflow/pull/22599#issuecomment-1083001535
BTW. The `:#$%^QW? errors` reffered to some Black errors (blacken docs) when I tried it before :)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk merged pull request #22599: Bump black version for other pre-commit hooks
Posted by GitBox <gi...@apache.org>.
potiuk merged pull request #22599:
URL: https://github.com/apache/airflow/pull/22599
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] eladkal commented on pull request #22599: Bump black version for other pre-commit hooks
Posted by GitBox <gi...@apache.org>.
eladkal commented on pull request #22599:
URL: https://github.com/apache/airflow/pull/22599#issuecomment-1082739177
> There is a problem with PROD build but I saw ?:#$%^QW? errors when I tried it ... I wonder what magic is in operations here :)
```
#64 13.65 The conflict is caused by:
#64 13.65 apache-airflow[amazon,async,celery,cncf-kubernetes,dask,docker,elasticsearch,ftp,google,google-auth,grpc,hashicorp,http,ldap,microsoft-azure,mysql,odbc,pandas,postgres,redis,sendgrid,sftp,slack,ssh,statsd,virtualenv] 2.3.0.dev0 depends on flask-appbuilder==3.4.5
#64 13.65 The user requested (constraint) flask-appbuilder==3.4.4
#64 13.65
#64 13.65 To fix this you could try to:
#64 13.65 1. loosen the range of package versions you've specified
#64 13.65 2. remove package versions to allow pip attempt to solve the dependency conflict
```
probably just need a rebase after https://github.com/apache/airflow/pull/22596 ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] kaxil commented on pull request #22599: Bump black version for other pre-commit hooks
Posted by GitBox <gi...@apache.org>.
kaxil commented on pull request #22599:
URL: https://github.com/apache/airflow/pull/22599#issuecomment-1083426145
All passed :) @potiuk
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] kaxil commented on pull request #22599: Bump black version for other pre-commit hooks
Posted by GitBox <gi...@apache.org>.
kaxil commented on pull request #22599:
URL: https://github.com/apache/airflow/pull/22599#issuecomment-1082368302
> I must disappoint you @kaxil . I tried it before and welll ... more changes are needed ... You will see :).
https://github.com/apache/airflow/runs/5744294853?check_suite_focus=true -- passed 🎉 😄
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk commented on pull request #22599: Bump black version for other pre-commit hooks
Posted by GitBox <gi...@apache.org>.
potiuk commented on pull request #22599:
URL: https://github.com/apache/airflow/pull/22599#issuecomment-1082392782
There is a problem with PROD build but I saw ?:#$%^QW? errors when I tried it ... I wonder what magic is in operations here :)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk commented on pull request #22599: Bump black version for other pre-commit hooks
Posted by GitBox <gi...@apache.org>.
potiuk commented on pull request #22599:
URL: https://github.com/apache/airflow/pull/22599#issuecomment-1083529096
I am surprised :) . But .... Well..
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk commented on pull request #22599: Bump black version for other pre-commit hooks
Posted by GitBox <gi...@apache.org>.
potiuk commented on pull request #22599:
URL: https://github.com/apache/airflow/pull/22599#issuecomment-1082310430
I must disappoint you @kaxil . I tried it before and welll ... more changes are needed ... You will see :).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk commented on pull request #22599: Bump black version for other pre-commit hooks
Posted by GitBox <gi...@apache.org>.
potiuk commented on pull request #22599:
URL: https://github.com/apache/airflow/pull/22599#issuecomment-1083000514
It needed constraints bump :). Fixed it. This one needs rebase now :)
But I am still suspicious why it worked - when I tried it, it did not :)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org